Bug#675081: proftpd-basic: logrotate kills proftpd instead of restarting it

[David North]

Package: proftpd-basic
Version: 1.3.3a-6squeeze4
Severity: important


Every time my /var/log/proftpd/proftpd.log gets long enough to be rotated
by the logrotate job supplied with the package, proftpd is killed instead of
restarted.

It seems that the logrotate job does:

    # reload could be not sufficient for all logs, a restart is safer
    invoke-rc.d proftpd restart 2>/dev/null >/dev/null || true

This looks reasonable enough, but the first two lines of the log file after
rotation are:

May 27 06:27:49 mybox proftpd[4847] mybox.example.com: Failed binding to 0.0.0.0, port 21: Address already in use
May 27 06:27:49 mybox proftpd[4847] mybox.example.com: Check the ServerType directive to ensure you are configured correctly.

Perhaps the restart component of the init script is not properly verifying
ProFTPD has exited before restarting it?

My configuration is as described at http://www.dnorth.net/2012/02/27/sftpscp-without-shell-access-on-debian/

This problem also seems to have been found in Ubuntu:

http://ubuntuforums.org/showthread.php?t=816156

Note that unlike the guy in the Ubuntu thread, I do *not* have any passphrase-protected keys involved in
my setup.

-- System Information:
Debian Release: 6.0.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-xen-amd64 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages proftpd-basic depends on:
ii  adduser               3.112+nmu2         add and remove users and groups
ii  debconf               1.5.36.1           Debian configuration management sy
ii  debianutils           3.4                Miscellaneous utilities specific t
ii  libacl1               2.2.49-4           Access control list shared library
ii  libattr1              1:2.4.44-2         Extended attribute shared library
ii  libc6                 2.11.3-3           Embedded GNU C Library: Shared lib
ii  libcap2               1:2.19-3           support for getting/setting POSIX.
ii  libncurses5           5.7+20100313-5     shared libraries for terminal hand
ii  libpam-runtime        1.1.1-6.1+squeeze1 Runtime support for the PAM librar
ii  libpam0g              1.1.1-6.1+squeeze1 Pluggable Authentication Modules l
ii  libssl0.9.8           0.9.8o-4squeeze13  SSL shared libraries
ii  libwrap0              7.6.q-19           Wietse Venema's TCP wrappers libra
ii  netbase               4.45               Basic TCP/IP networking system
ii  sed                   4.2.1-7            The GNU sed stream editor
ii  ucf                   3.0025+nmu1        Update Configuration File: preserv
ii  update-inetd          4.38+nmu1+squeeze1 inetd configuration file updater
ii  zlib1g                1:1.2.3.4.dfsg-3   compression library - runtime

proftpd-basic recommends no packages.

Versions of packages proftpd-basic suggests:
pn  openbsd-inetd | inet-s <none>            (no description available)
ii  openssl                0.9.8o-4squeeze13 Secure Socket Layer (SSL) binary a
pn  proftpd-doc            <none>            (no description available)
pn  proftpd-mod-ldap       <none>            (no description available)
pn  proftpd-mod-mysql      <none>            (no description available)
pn  proftpd-mod-odbc       <none>            (no description available)
pn  proftpd-mod-pgsql      <none>            (no description available)
pn  proftpd-mod-sqlite     <none>            (no description available)

-- debconf information:
* shared/proftpd/inetd_or_standalone: standalone