Bug#699775: Patch does not apply to the version in experimental

Adrian Knoth adi at drcomp.erfurt.thur.de
Mon Feb 4 21:23:22 UTC 2013


Hi!

I've just noticed that upstream decided to divide by 1024 in newer
versions of src/fsio.c:


    /* In order to return a size in KB, as get_fs_size() does, we need
     * to divide by 1024.
     */
    *fs_size = (((off_t) fs.f_bavail * (off_t) fs.f_frsize) / 1024);

So they're effectively hiding the bug. I suggest to at least put a
comment before pr_fs_getsize2 that the returned number is in KB, not in
bytes.


Cheers



More information about the Pkg-proftpd-maintainers mailing list