Bug#721201: proftpd-basic: Without sleep 2, doing /etc/init.d/proftpd restart doesn't restart the daemon, but only stops it.

[Prisma Computer - G. Fischer]

Hello Francesco,

you're right. Sleep is no good solution. But my post is about:

    if [ -f "$PIDFILE" ]; then
    	start-stop-daemon --stop --signal $SIGNAL --retry 1 --quiet
--pidfile "$PIDFILE"
   	 if [ $? = 0 ]; then
        	log_end_msg 0
    	else
		SIGNAL="KILL"
		start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE"
--retry=TERM/10/KILL/5

You need a "--retry" in the first "start-stop-daemon" call. It seems
that "$? = 0", but the daemon is STILL RUNNING. SIGNAL="KILL" and the
second "--retry" is not reached. For this reason the start of the daemon
shows [OK]. But the daemon is not started. In the meantime it is
stopped... Horrible.

Tested with Ubuntu 14.04 beta.

Mit freundlichen Grüßen / Best regards

Gregor Fischer

Prisma Computer GmbH
Sternallee 89  -  68723 Schwetzingen
Fon 0 62 02.5 75 68 10
Fax 0 62 02.5 75 68 75
eMail: g.fischer at prisma-computer.de
Internet: www.prisma-computer.de

Geschäftsführung: Gerald Wilkens, Bernhard Goebel
Amtsgericht Mannheim HRB 420986 S
USt-IdNr.: DE 144 278 153

Am 11.04.2014 15:40, schrieb Francesco P. Lovergine:
> On Mon, Apr 07, 2014 at 12:33:01PM +0200, Prisma Computer - G. Fischer wrote:
>> Hello,
>>
>> I'm able to confirm this bug with ProFTPD Version 1.3.5rc3. This is an
>> evil bug, leading to logrotate is killing proftpd. When is it expected
>> to be fixed?
>>
>> Mit freundlichen Grüßen / Best regards
>>
>> Gregor Fischer
>>
>>> 		start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE" --retry=TERM/10/KILL/5
> 
> This version is already using the sleeping thanks to the --retry flag. You are
> talking about what exactly? The next systemd will not appreciate sleeps
> around in init scripts, so this is the proper way of fixing that issue.
>