[Bug 1356719] [NEW] Incorrect "ALLO" command handling, can't upload file

[Sergiy Gipsy]

Public bug reported:

File cannot be uploaded with error "552 xxxxxx: No space left on
device", but there are enough free space to upload file:

lftp ftp at localhost:/incoming> put 111.file 
---> TYPE I
<--- 200 Type set to I
---> PASV
<--- 227 Entering Passive Mode (127,0,0,1,178,244).
---- Connecting data socket to (127.0.0.1) port 45812
---> ALLO 4559208448
<--- 552 4559208448: No space left on device
---> STOR 111.file
---> ABOR
put: Access failed: 552 4559208448: No space left on device (111.file)

$ df -k /
Filesystem                   1K-blocks      Used Available Use% Mounted on
/dev/mapper/xubuntu--vg-root 952960924 508509592 396020640  57% /

# proftpd debug level 5 log fragment:
2014-08-13 20:49:57,425 host proftpd[17989] host (localhost[127.0.0.1]): dispatching CMD command 'ALLO 4559208448' to mod_xfer
2014-08-13 20:49:57,425 host proftpd[17989] host (localhost[127.0.0.1]): ALLO requested 4559208448 bytes, only 396020652 bytes available on '/incoming'

# Versions

$ lsb_release -rd
Description:	Ubuntu 14.04.1 LTS
Release:	14.04

$ apt-cache policy proftpd-basic
proftpd-basic:
  Installed: 1.3.5~rc3-2.1ubuntu2
  Candidate: 1.3.5~rc3-2.1ubuntu2
  Version table:
 *** 1.3.5~rc3-2.1ubuntu2 0
        500 http://ua.archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages
        100 /var/lib/dpkg/status

### 
Problem caused by following code:
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/proftpd-dfsg/trusty/view/head:/modules/mod_xfer.c
2371:    res = pr_fs_getsize2((char *) path, &avail_sz);
.....
2381:     if (requested_sz > avail_sz) {

But function pr_fs_getsize2 retunrs avail_sz is in kilobytes,  while
requested_sz in bytes.

** Affects: proftpd-dfsg (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of ProFTPD
Maintainance Team, which is subscribed to proftpd-dfsg in Ubuntu.
https://bugs.launchpad.net/bugs/1356719

Title:
  Incorrect "ALLO" command handling, can't upload file

Status in “proftpd-dfsg” package in Ubuntu:
  New

Bug description:
  File cannot be uploaded with error "552 xxxxxx: No space left on
  device", but there are enough free space to upload file:

  lftp ftp at localhost:/incoming> put 111.file 
  ---> TYPE I
  <--- 200 Type set to I
  ---> PASV
  <--- 227 Entering Passive Mode (127,0,0,1,178,244).
  ---- Connecting data socket to (127.0.0.1) port 45812
  ---> ALLO 4559208448
  <--- 552 4559208448: No space left on device
  ---> STOR 111.file
  ---> ABOR
  put: Access failed: 552 4559208448: No space left on device (111.file)

  $ df -k /
  Filesystem                   1K-blocks      Used Available Use% Mounted on
  /dev/mapper/xubuntu--vg-root 952960924 508509592 396020640  57% /

  # proftpd debug level 5 log fragment:
  2014-08-13 20:49:57,425 host proftpd[17989] host (localhost[127.0.0.1]): dispatching CMD command 'ALLO 4559208448' to mod_xfer
  2014-08-13 20:49:57,425 host proftpd[17989] host (localhost[127.0.0.1]): ALLO requested 4559208448 bytes, only 396020652 bytes available on '/incoming'

  # Versions

  $ lsb_release -rd
  Description:	Ubuntu 14.04.1 LTS
  Release:	14.04

  $ apt-cache policy proftpd-basic
  proftpd-basic:
    Installed: 1.3.5~rc3-2.1ubuntu2
    Candidate: 1.3.5~rc3-2.1ubuntu2
    Version table:
   *** 1.3.5~rc3-2.1ubuntu2 0
          500 http://ua.archive.ubuntu.com/ubuntu/ trusty/universe amd64 Packages
          100 /var/lib/dpkg/status

  ### 
  Problem caused by following code:
  http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/proftpd-dfsg/trusty/view/head:/modules/mod_xfer.c
  2371:    res = pr_fs_getsize2((char *) path, &avail_sz);
  .....
  2381:     if (requested_sz > avail_sz) {

  But function pr_fs_getsize2 retunrs avail_sz is in kilobytes,  while
  requested_sz in bytes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1356719/+subscriptions