[Bug 1246245] Re: proftpd service failed to restart
Joel
joel.forsberg at bahnhof.net
Mon Oct 27 16:14:59 UTC 2014
Upstream already had changed the init script, but I don't understand it
fully.
(looking at master, commit b63ec2128f324610404efa991456b6206095531d File: debian/proftp-basic.init )
My questions:
1) Why exit if $2 is 0? (row 118)
2) Is it necessary to call start-stop-daemon twice if the first it exits with nonzero return value? (row 111 and 115)
3) row 123 looks wrong, attaching simple patch.
4) what is missing to close this ticket and make a corrected .deb? I'm willing to help but know little.
** Patch removed: "proftp.patch"
https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243699/+files/proftp.patch
** Patch removed: "proftp.patch"
https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+attachment/4243717/+files/proftp.patch
--
You received this bug notification because you are a member of ProFTPD
Maintainance Team, which is subscribed to proftpd-dfsg in Ubuntu.
https://bugs.launchpad.net/bugs/1246245
Title:
proftpd service failed to restart
Status in “proftpd-dfsg” package in Ubuntu:
Confirmed
Bug description:
proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10
proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04
Init script from proftpd-basic package contains the BUG: when you run
/etc/init.d/proftpd restart it fails because of there is the race
between pidfile removal and start() which checks pidfile existency:
---
ProFTPD is started in standalone mode, currently running.
root at aa:~# /etc/init.d/proftpd restart
* Stopping ftp server proftpd [ OK ]
* Starting ftp server proftpd [ OK ]
root at aa:~# /etc/init.d/proftpd status
ProFTPD is started in standalone mode, currently not running.
---
the next workaround helps:
---
--- /etc/init.d/proftpd.orig 2013-10-30 13:52:46.791265726 +0400
+++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400
@@ -107,6 +107,7 @@
fi
if [ -f "$PIDFILE" ]; then
start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE"
+ sleep 1
if [ $? = 0 ]; then
log_end_msg 0
else
---
Please, fix.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/proftpd-dfsg/+bug/1246245/+subscriptions
More information about the Pkg-proftpd-maintainers
mailing list