Bug#836759: proftpd-dfsg: please drop the build dependency on hardening-wrapper

[Mattia Rizzolo]

On Tue, Oct 25, 2016 at 11:35:42PM +0200, Hilmar Preuße wrote:
> > 3) configure done by dh_auto_configure
> > 
> I'd simply replace
> 
> ./configure $(shell dpkg-buildflags --export=configure) $(CONF_ARGS)
> --with-shared=$(DSOMODS1)$(DSOMODS2)$(DSOMODS3)$(DSOMODS4)
> 
> by
> 
> dh_auto_configure -- $(shell dpkg-buildflags --export=configure)
> $(CONF_ARGS) --with-shared=$(DSOMODS1)$(DSOMODS2)$(DSOMODS3)$(DSOMODS4)
> 
> Is that correct? This will give me a lot of duplicate parameters e.g.
> --prefix=/usr will be specified twice in the configure call. This can be
> cleaned up later on.

That, and remove some options from CONF_ARGS that are already passed by
dh_auto_configure.
Also the change at point 4 should allow you to drop that $(shell
dpkg-buildpackage ..), and if not that can be considered some bad habit
from the the build system.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-proftpd-maintainers/attachments/20161025/cb5cfd1a/attachment-0001.sig>