[proftpd-dfsg] branch master updated (dc5027e -> 1e3bae5)

[Hilmar Preuße]

On 05.01.2018 09:50, Francesco P. Lovergine wrote:
> On Thu, Jan 04, 2018 at 09:45:09PM +0100, Hilmar Preuße wrote:
>> On 04.01.2018 16:47, Francesco Lovergine wrote:

Hi,

>> 1. We call "update-rc.d" w/ params "defaults 50". According to my test
>> [1] the value 50 is default anyway so it can simply be dropped. Correct?
> 
> Indeed the int value argument is simply ignored, it is an heritage of 
> the past (I think when the initscripts system was strictly serial) 
> never catched. So, yes it has to be dropped. 
> 
Done.

>> 2. I don't understand that DONTSTART test. AFAICT the variable DONTSTART
>> is set to 0 at the top of the script and then never touched again. So I
>> can't imagine a situation where DONTSTART should have a different value
>> than 0. So the test is surplus, correct?
> 
> I think that the whole thing (postinst and init) needs to be revised to be compliant 
> with the new policy 9.3.3.1. Anyway, I'm afraid it is currently a non-sense
> due to some past feature (debconf?) So, correct: it has to be revised.
> 
Will remove ASAP.

>> 3. We test for the correctness proftp configuration before we start the
>> init script. If we really need to do that (instead of simply start and
>> eventually fail) I suggest to move it to the init script and simplify
>> the postinst script.
> 
> Currently I have not a clear tought about that. I don't remember
> if it is something introduced by me or not, but anyway the idea is communicating
> ASAP the problems to admin without interrupting the service, but I'm not sure
> if the service at that stage is *already* stopped in any case.
> 
OK, I found a bug for this: #379503. If a postinst fails (and hence a
package upgrade) due to a wrong config file this needs to be handeled.
However I tend to leave that job to the init script instead of postinst.

> I would start with a separate 1.3.6 branch with substantial changes to
> debian stuff, e.g. use of dh approach and auto stuff. 
> 
I guess there is still a long way until we can use purely dh. ;-)

H.
-- 
#206401 http://counter.li.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-proftpd-maintainers/attachments/20180106/ca70cd91/attachment.sig>