[ProFTP] (New) Modules zu activate

[Hilmar Preuße]

On 07.05.2018 11:09, Hilmar Preuße wrote:

Hi Francesco,

this issue is still open: IMHO our logic to update config files is
broken. Do you agree? If yes, I'd fix that and replace it by normal
Debian config file handling.

> 1. I intend like to package the module mod_snmp; would be done in a
> separate Debian binary package. Objections?
> 
OK, I pushed my new package into the report, will go to the NEW queue
upon next upload.

I also provide a new file modules.conf containing two commented lines:

# Install proftpd-mod-snmp to use the SNMP feature
#LoadModule mod_snmp.c

----

I noticed that the file already sitting in /etc/proftpd was not replaced
during upgrade from 1.3.6-2 to 1.3.6-3. To me the logic to replace the
config files do not look OK.

proftpd-basic.postinst

    # use current configuration files or generate new ones from scratch
    for name in proftpd modules sql ldap tls virtuals
    do
      if [ ! -f $ETC_DIR/$name.conf ]; then
          cp  /usr/share/proftpd/templates/$name.conf
$ETC_DIR/$name.conf.proftpd-new
      else
          cp  $ETC_DIR/$name.conf $ETC_DIR/$name.conf.proftpd-new
      fi
    done

In case of an upgrade the config file in /etc is already present and
copied to ..proftpd-new . Later on there is the "do_update
/etc/proftpd/modules.conf" call, which checks if the new file is
identical to the "old" file and removes the "new" one.

In case of upgrades the config files are never replaced, if already
present, which does not make sense to me.
Why don't we install the config files into etc from the beginning and
leave the handling of them to the normal Debian mechanisms?

Hilmar
-- 
sigfault
#206401 http://counter.li.org