[Pkg-pulseaudio-devel] Bug#488754: initscript should wait for pulseaudio to stop

[Aron Griffis]

Package: pulseaudio
Version: 0.9.10-2
Severity: normal

Sometimes pulseaudio takes a second to stop. This can cause
restart to fail:

$ sudo /etc/init.d/pulseaudio restart
Stopping PulseAudio Daemon.
Starting PulseAudio Daemon/usr/bin/pulseaudio already running.

This can be fixed by using the --retry option to
start-stop-daemon.  With the following patch, the initscript will
wait 3 seconds for pulseaudio to stop, and report the final status
appropriately.  Note this is *up to* 3 seconds; start-stop-daemon
will poll regularly and exit early if possible.

--- /etc/init.d/pulseaudio.agriffis	2008-06-30 22:25:11.000000000 -0400
+++ /etc/init.d/pulseaudio	2008-06-30 22:24:29.000000000 -0400
@@ -42,9 +42,15 @@
 }
 
 pulseaudio_stop () {
+	declare status
 	log_begin_msg "Stopping PulseAudio Daemon"
-	start-stop-daemon -p $PIDFILE --stop || echo -n "... pulseaudio is not running"
-	log_end_msg $?
+	start-stop-daemon -p $PIDFILE --stop --retry TERM/3
+	status=$?
+	case $status in
+	    1) echo -n "... pulseaudio is not running" ;;
+	    2) echo -n "... pulseaudio still running after timeout" ;;
+	esac
+	log_end_msg $status
 }
 
 case "$1" in

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable'), (550, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages pulseaudio depends on:
ii  adduser                       3.108      add and remove users and groups
ii  libasound2                    1.0.16-2   ALSA library
ii  libasyncns0                   0.3-1      Asyncronous name service query lib
ii  libc6                         2.7-10     GNU C Library: Shared libraries
ii  libcap1                       1:1.10-14  support for getting/setting POSIX.
ii  libdbus-1-3                   1.2.1-2    simple interprocess messaging syst
ii  libflac8                      1.2.1-1.2  Free Lossless Audio Codec - runtim
ii  libltdl3                      1.5.26-4   A system independent dlopen wrappe
ii  libogg0                       1.1.3-4    Ogg Bitstream Library
ii  liboil0.3                     0.3.14-5   Library of Optimized Inner Loops
ii  libpulsecore5                 0.9.10-2   PulseAudio sound server core
ii  libsamplerate0                0.1.3-1    audio rate conversion library
ii  libsndfile1                   1.0.17-4   Library for reading/writing audio 
ii  libwrap0                      7.6.q-15   Wietse Venema's TCP wrappers libra
ii  lsb-base                      3.2-12     Linux Standard Base 3.2 init scrip

Versions of packages pulseaudio recommends:
ii  gstreamer0.10-pulseaudio     0.9.7-2     GStreamer plugin for PulseAudio
ii  libasound2-plugins           1.0.16-1+b1 ALSA library additional plugins
ii  padevchooser                 0.9.3-2     PulseAudio Device Chooser
ii  paprefs                      0.9.6-2     PulseAudio Preferences
ii  pulseaudio-esound-compat     0.9.10-2    PulseAudio ESD compatibility layer
pn  pulseaudio-module-hal        <none>      (no description available)
ii  pulseaudio-module-x11        0.9.10-2    X11 module for PulseAudio sound se

-- no debconf information