Bug#644809: pulseaudio: Confusing warning `PulseAudio configured for per-user sessions`

[Paul Vojta]

On Wed, Jun 06, 2012 at 02:30:03AM +0200, Tobias Diedrich wrote:
> Paul Vojta wrote:
> > On Sun, Feb 05, 2012 at 01:24:38PM +0100, Tobias Diedrich wrote:
> > > Package: pulseaudio
> > > Version: 1.1-2
> > > Followup-For: Bug #644809
> > > 
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > > 
> > > Dear Maintainer,
> > > 
> > > FWIW I also found this confusing on package upgrade:
> > > Processing triggers for man-db ...
> > > Setting up pulseaudio (1.1-2) ...
> > > PulseAudio configured for per-user sessions ... (warning).
> > > 
> > > Especially since dpkg-reconfigure then offers no options, but also prints the warning (because it reloads the init script):
> > > sudo dpkg-reconfigure pulseaudio
> > > PulseAudio configured for per-user sessions ... (warning).
> > > PulseAudio configured for per-user sessions ... (warning).
> > > 
> > > Cheers,
> > > Tobias
> > >
> > 
> > How about the following:
> > 
> > --- /root/pulseaudio-prev	2012-05-19 13:05:24.000000000 -0700
> > +++ /etc/init.d/pulseaudio	2012-06-04 16:06:01.813487453 -0700
> > @@ -26,7 +26,7 @@
> >  DISALLOW_MODULE_LOADING=1
> >  test -f /etc/default/pulseaudio && . /etc/default/pulseaudio
> >  if [ "$PULSEAUDIO_SYSTEM_START" != "1" ]; then
> > -	log_warning_msg "PulseAudio configured for per-user sessions"
> > +	log_action_msg "Configuring PulseAudio for per-user sessions (not starting system daemon)"
> >  	exit 0
> >  fi
> >  
> 
> How about:
> 
> log_action_msg "PulseAudio not started: Configured for per-user sessions"
> 
> I wouldn't say "Configuring PulseAudio for per-user sessions" since
> it's not actually configuring anything. :)
> The above would instead say what action was taken (none) and why.
> 
> Cheers,
> 
> -- 
> Tobias						PGP: http://8ef7ddba.uguu.de

Sounds good.

Most such messages use parentheses, though; for example:

log_action_msg "PulseAudio not started (it is configured for per-user sessions)"

Sincerely,


Paul Vojta