Bug#756914: pulseaudio: FTBFS on kfreebsd-*: portability issue

[Cyril Brulebois]

Source: pulseaudio
Version: 5.0-3
Severity: serious
Justification: FTBFS
Usertags: kfreebsd

Hi,

your package has been failing to build on kfreebsd-* since 5.0-3, as can
be seen here:
  https://buildd.debian.org/status/logs.php?pkg=pulseaudio&arch=kfreebsd-amd64

Build log excerpt:
| libtool: link: ranlib .libs/liblo-test-util.a
| libtool: link: ( cd ".libs" && rm -f "liblo-test-util.la" && ln -s "../liblo-test-util.la" "liblo-test-util.la" )
| /bin/bash ../libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../src -I../src/modules -I../src/modules -DPA_ALSA_PATHS_DIR=\"\" -DPA_ALSA_PROFILE_SETS_DIR=\"\" -D_FORTIFY_SOURCE=2 -DFASTPATH -pthread -DPA_SRCDIR=\"/«PKGBUILDDIR»/src\" -DPA_BUILDDIR=\"/«PKGBUILDDIR»/src\"  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option -c -o utils/libpulsedsp_la-padsp.lo `test -f 'utils/padsp.c' || echo './'`utils/padsp.c
| libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../src -I../src/modules -I../src/modules -DPA_ALSA_PATHS_DIR=\"\" -DPA_ALSA_PROFILE_SETS_DIR=\"\" -D_FORTIFY_SOURCE=2 -DFASTPATH -pthread -DPA_SRCDIR=\"/«PKGBUILDDIR»/src\" -DPA_BUILDDIR=\"/«PKGBUILDDIR»/src\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option -c utils/padsp.c  -fPIC -DPIC -o utils/.libs/libpulsedsp_la-padsp.o
| In file included from utils/padsp.c:45:0:
| utils/padsp.c: In function 'open':
| utils/padsp.c:1522:33: warning: 'short unsigned int' is promoted to 'int' when passed through '...'
|              mode = va_arg(args, mode_t);
|                                  ^
| utils/padsp.c:1522:33: note: (so you should pass 'int' not 'short unsigned int' to 'va_arg')
| utils/padsp.c:1522:33: note: if this code is reached, the program will abort
| utils/padsp.c: In function 'open64':
| utils/padsp.c:2561:33: warning: 'short unsigned int' is promoted to 'int' when passed through '...'
|              mode = va_arg(args, mode_t);
|                                  ^
| utils/padsp.c:2561:33: note: if this code is reached, the program will abort
| /bin/bash ../libtool  --tag=CC   --mode=link gcc -std=gnu99 -pthread -DPA_SRCDIR=\"/«PKGBUILDDIR»/src\" -DPA_BUILDDIR=\"/«PKGBUILDDIR»/src\"  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option -Wl,-z,nodelete    -avoid-version -disable-static -Wl,-z,relro -Wl,--no-as-needed -o libpulsedsp.la -rpath /usr/lib/x86_64-kfreebsd-gnu/pulseaudio utils/libpulsedsp_la-padsp.lo   libpulse.la libpulsecommon-5.0.la -lpthread -lrt -ldl -lm 
| libtool: link: gcc -std=gnu99 -shared  -fPIC -DPIC  utils/.libs/libpulsedsp_la-padsp.o   -Wl,-rpath -Wl,/«PKGBUILDDIR»/src/.libs -Wl,-rpath -Wl,/usr/lib/x86_64-kfreebsd-gnu/pulseaudio ./.libs/libpulse.so ./.libs/libpulsecommon-5.0.so -lpthread -lrt -ldl -lm  -pthread -O2 -Wl,-z -Wl,nodelete -Wl,-z -Wl,relro -Wl,--no-as-needed   -pthread -Wl,-soname -Wl,libpulsedsp.so -o .libs/libpulsedsp.so
| libtool: link: ( cd ".libs" && rm -f "libpulsedsp.la" && ln -s "../libpulsedsp.la" "libpulsedsp.la" )
| gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../src -I../src/modules -I../src/modules -DPA_ALSA_PATHS_DIR=\"\" -DPA_ALSA_PROFILE_SETS_DIR=\"\" -D_FORTIFY_SOURCE=2 -DFASTPATH -pthread -DPA_SRCDIR=\"/«PKGBUILDDIR»/src\" -DPA_BUILDDIR=\"/«PKGBUILDDIR»/src\"   -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-kfreebsd-gnu/dbus-1.0/include  -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wformat-security -Wmissing-include-dirs -Wformat-nonliteral -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter -ffast-math -fno-common -fdiagnostics-show-option -c -o daemon/pulseaudio-caps.o `test -f 'daemon/caps.c' || echo './'`daemon/caps.c
| daemon/caps.c: In function 'pa_drop_caps':
| daemon/caps.c:93:2: error: #error "Don't know how to do capabilities on your system.  Please send a patch."
|  #error "Don't know how to do capabilities on your system.  Please send a patch."
|   ^
| make[4]: *** [daemon/pulseaudio-caps.o] Error 1
| Makefile:9400: recipe for target 'daemon/pulseaudio-caps.o' failed
| make[4]: Leaving directory '/«PKGBUILDDIR»/src'
| make[3]: *** [all] Error 2

Full build logs:
  https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=kfreebsd-amd64&ver=5.0-4&stamp=1406737770
  https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=kfreebsd-i386&ver=5.0-4&stamp=1406737149

Mraw,
KiBi.