Bug#735898: pavucontrol segmentation fault

[Vincent Lefevre]

Control: tags -1 patch

On 2014-02-23 04:52:46 +0100, Vincent Lefevre wrote:
> data can be NULL and the code is obviously buggy.

gnome-control-center seemed to have similar code, thus was also buggy:

  https://bugzilla.gnome.org/show_bug.cgi?id=689079

which has a patch:

  https://bug689079.bugzilla-attachments.gnome.org/attachment.cgi?id=229897

This would give here:

--- src/mainwindow.cc~  2012-05-19 23:17:28.000000000 +0200
+++ src/mainwindow.cc   2014-02-23 04:58:35.142596137 +0100
@@ -379,6 +379,11 @@
         return;
     }
 
+    if (!data) {
+        pa_stream_drop(s);
+        return;
+    }
+
     assert(length > 0);
     assert(length % sizeof(float) == 0);
 

Could you try this patch?

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)