[Pkg-puppet-devel] [SCM] Packaging of Facter for debian branch, master, updated. debian/1.5.6-1-3-gf695058

[Andrew Pollock]

On Tue, Jun 30, 2009 at 05:00:18PM -0400, Micah Anderson wrote:

[snip]
 
> > So a big fat +1 for a nice detailed commit message, but a big fat -1 for the
> > resulting change. 
> 
> I would also say a big fat -1 for switching to CDBS, something I am not
> really a fan of and something that isn't particularly nice to do without
> talking with people first (maybe thats a big fat -2?).

Oh yeah, I totally forgot about that :-(
 
[snip]

> 
> Part of me thinks that if individual users in your environment mess up
> their ruby runtime, that is on them, and solving it by hard-coding the
> package so all debian users must use a specific ruby version because
> some of your users can't keep their grubby little hands off of the
> system doesn't seem like the right way to solve your problem as any time
> you find yourself solving a social problem with a technical one, then
> its time to rethink things :)

Heh. If only. 

I also have a few issues with using #!/usr/bin/env in general, be it Ruby or
Python. We really want to avoid situations where the user having root on
their desktop manages to break Puppet before it has a chance to rectify
things.
 
> However, maybe there is some middle-ground. Perhaps by having the
> shebang use /usr/bin/ruby (which is going to be a symlink to the
> preferred version of ruby on the system), instead of #!/usr/bin/env ruby 
> 
> Would that work?

Well, yeah, unless someone dicks with the /usr/bin/ruby symlink. An ignorant
user (at least at our site) is more likely to just mess with the filesystem
than they are to uninstall a package.

What problem are you trying to solve by allowing ruby1.8 or ruby1.9, anyway?
I'd be inclined to pick one or the other and stick with it. I'd suggest
ruby1.8 until such time that Puppet itself will work with ruby1.9 and just
transition over. There's no problem with installing ruby1.8 and ruby1.9 at
the same time is there? It's not like having Facter installed locks you into
having only Ruby 1.8 installed is there?

My understanding is that Puppet only works with ruby1.8 at the moment, so if
you allow Facter to run by hand with ruby1.9, but be loaded into a ruby1.8
runtime when loaded by Puppet, won't this leave things open to inconsistent
behaviour between running it interactively (with say ruby1.8) and running
internally to Puppet (with ruby1.8)?
 
> > I'd like to move to a development model where we're not all working in
> > isolation commiting changes, but send patches to the list, and reach some
> > sort of agreement or at the very least obtain some peer review/feedback
> > before submitting. I'm not exactly sure how to accomplish this yet though.
> 
> Absolutely! I'm open to discussing and figuring out the best way to deal
> with both of these issues. I've been kind of used to being on a team of
> 1 for a while, and when you guys blew in and started pushing changes and
> uploading packages without any discussion, I was not hurt in the
> least. In fact I was relieved that someone else was doing some work so
> I welcomed it! :) Alas, when you are working with others, sometimes
> there are competing priorities and goals and so in the end you simply
> must communicate. 

Well we pretty much blew in because there'd been no evidence of activity for
some time prior. Had we known you were still doing stuff, we'd have been
more communicative from the outset, so sorry about that.

With respect to the development model, this is my first major foray into
Git, my first foray into collaborative maintenance with it on Alioth, and my
first foray into collaborative maintenance, period. So I'm totally open to
suggestions.
 
> This is a good first step in that direction. Perhaps one other step we
> could make would be to take a step back before uploading and ask the
> list before pulling the trigger? 

Yes, that's a good starting point.
 
> micah
> 
> ps - I'm on IRC frequently, and welcome conversation there (either in
> the upstream #puppet channel, in #debian-ruby, #debian-devel, or
> whatever) too.
 
Yeah I idle in #debian-devel, but I don't pay close attention to it during
the day, so I may not be enormously responsive. I'll see if I can make
screen yell at me more obviously when there's activity in the window with
irssi in it.

Perhaps we should organise a time to have a meeting on IRC and just throw
some ideas around?

regards

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20090701/2b480738/attachment.pgp>