[Pkg-puppet-devel] [SCM] Puppet packaging for Debian branch, upstream, created. puppet-0.24.5-rc3-1379-gb1eddbb
James Turnbull
james at lovedthanlost.net
Wed Sep 9 15:00:53 UTC 2009
The branch, upstream has been created
at b1eddbb6acf2b8ad2a564b0d75ef52c196357427 (commit)
- Shortlog ------------------------------------------------------------
commit b1eddbb6acf2b8ad2a564b0d75ef52c196357427
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Sep 5 09:39:36 2009 +1000
Updated and created new CHANGELOG format
commit 994d6e08e8cb43b871fbac0b255718a7050a67b3
Author: Luke Kanies <luke at madstop.com>
Date: Fri Sep 4 16:22:42 2009 -0700
Adding tests for the #2599 fix
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 42ab73f29ada8e045e6638ccb454b12595220fe1
Author: Markus Roberts <Markus at reality.com>
Date: Fri Sep 4 16:10:20 2009 -0700
Ticket #2525 don't fail find_manifest on invalid module names
The patch that put validity assertions in for module names broke
find_manifest because rather than returning a failure it now rasies
an exception. This patch catches the exception and treats it as
a negative result.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit a0f0dccb0f42140b9e1cec0cc551b3860c7089c1
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Sep 5 09:27:26 2009 +1000
Updated permissions on test files
commit d45812bc31a5a4517bbafb50fc7f9a15fca8d0a9
Author: Markus Roberts <Markus at reality.com>
Date: Thu Sep 3 22:05:11 2009 -0700
Refactoring tests to reduce code size, increase coverage, and make
Luke happy.
commit aba2f6600062c6935b65ebc2eeae0802e1f89a89
Author: Markus Roberts <Markus at reality.com>
Date: Thu Sep 3 17:43:24 2009 -0700
This further normalizes the handling of init-style services (including
the redhat "service" wrapper script). Removes special case handling of
non-zero exit code in redhat (base already did this) and centralizes
scattered @resource[:has_____] checks. Tests that proper versions of
each are called and one level of fallbacks.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit fb236a00459c375e4f2a94bdd924ed4e7fbd25eb
Author: Markus Roberts <markus at phage.local>
Date: Tue Sep 1 15:11:05 2009 -0700
Combined fix for #2525, #2552 -- RedHat service issues
This patch normalizes the structure of the RH service routines which
should clear up any lingering issues; xxxcmd routines always return
an appropriate array, while the coresponding routines (status/restart/
etc.) either call super or take the needed actions.
Signed-off-by: Markus Roberts <markus at phage.local>
commit d40b942d14d1da0341fb95835a28e0f7b8d88ab8
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Sep 4 15:47:00 2009 +1000
Fixed #2589 - Renamed zfs delete to destroy and added tests
commit 4aa7fcec3d05a45c3a9d8b76fd9892ae28e7618b
Author: Markus Roberts <Markus at reality.com>
Date: Fri Sep 4 13:00:30 2009 -0700
Monkey patch to improve yaml compatibility between ruby versions
Ruby 1.8.1 can not parse the yanl produced by later versions because
it requires explict type tagging of symbols. This patch adds the
tagging on to later versions so that mixed version instalations can
use yaml.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 1f6c74dbdfe8e0d27f74dd08c474747d24fafb61
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Sep 5 09:11:45 2009 +1000
Fixed typo in parser test
commit 2e9b706898225f319ab90123d24efc215173d25f
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Sep 5 09:00:00 2009 +1000
Updated Red Hat spec file and RH patches for 0.25.0.
Thanks to Todd Zullinger for the patch and the updates.
commit 19815dd32891eb182a3ad4d5937ba6ec9eda1261
Author: Luke Kanies <luke at madstop.com>
Date: Thu Sep 3 17:22:08 2009 -0700
Fixing #2592 - you can escape slashes in regexes
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ea5847875b5fd7e2d13470d9e74bb0f671ee4d95
Author: Luke Kanies <luke at madstop.com>
Date: Thu Sep 3 17:41:42 2009 -0700
Fixing #2590 - modulepath is not cached inappropriately
It was getting cached by Environment instances too early, thus causing some
executables to use the default even when it was overridden.
We're taking the slightly extreme step of clearing the environment
list if any parameter is set, but this is relatively inexpensive and
is the only way to always be correct.
The reason that the environments cache this value at all is that to build
up their module path they have to search through every known module for a lib
or plugins directory, which is then done every time a class is sought in
the language. Caching it saves a *ton* of file accesses.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1a3d0c876121561173c485b2e4d0dd7131f43eab
Author: John A. Barbuto <jbarbuto at corp.sourceforge.com>
Date: Thu Sep 3 12:16:50 2009 -0700
Fixed #2593: puppet init script status command not returning proper exit code
Signed-off-by: John A. Barbuto <jbarbuto at corp.sourceforge.com>
commit 8dabc72dd016aa24a86311c81049793eb139ccce
Author: Steven Jenkins <steven at endpoint.com>
Date: Thu Sep 3 14:19:38 2009 -0400
Update documentation string to reflect actual intent of Puppet::Node::Facts::Rest
commit b30a3c772f5f2cbedacfe596c5fbd376d30994f6
Author: Nigel Kersten <nigelk at google.com>
Date: Tue Sep 1 12:04:45 2009 -0700
Fixes #2581. Use new 10.6 global launchd overrides file for service status/enabled
commit 7f054695e2b80c00d3b3fd821a7845be91ab6092
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Sep 3 09:46:55 2009 +1000
Fixed Naginator link
commit e589cd39cc1d76de59cf4758bb986fa15f64571c
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 31 23:23:57 2009 -0700
Fixing #2582 - / no longer autorequires /
This was obviously resulting in a dep cycle.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3342b73b6acf5e7c492fa352b16ba9aba3c60da8
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 31 23:38:26 2009 -0700
Fixing #2577 - clarifying and demoting the deprecation notice
It's now just notice instead of a warning, and it clarifies
that 0.24 clients can't be present.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d397f8d1d1092067f7ca52449ce9af63f02f44e1
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 31 16:01:17 2009 -0700
Fixing #2574 - autoloading finds plugins in modules
We had some stupid errors that were preventing this
from happening; this fixes them and adds an
integration test.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 800a78b993f15e2d77312bf207929ec876e9b227
Author: Luke Kanies <luke at madstop.com>
Date: Tue Sep 1 00:20:15 2009 -0700
The first regex node now matches first
Before it was undefined, but now we always match
the first defined node.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6750aeb90a4d19a2cd1de3ff007f216d31c4e65d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Sep 1 00:12:07 2009 -0700
Fixing #2563 - multiple regex nodes now work together
The problem was that we were needing to convert
one of the regexes to a string, which wasn't working well.
This adds specific rules for how regexes vs. strings
get compared.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b728b931e5914cfeaf3d072fb77870e9a8ecf6cd
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Aug 31 15:18:05 2009 +0200
Fixes #724 - false is equivalent to 'ruby -W1'
Signed-off-by: Marc Fournier <marc.fournier at camptocamp.com>
commit a9d5863145ef2373bbd25e92e1fc1a0071076afd
Author: Todd Zullinger <tmz at pobox.com>
Date: Sun Aug 23 21:30:35 2009 -0400
Fix parser error output
The 'value' passed to on_error in Puppet::Parser::Parser is a hash, and
we only want to print the 'value' key, rather than a flattened string of
the hash.
commit ee4f6ba312387c1b93f850cee1507f6ab749f953
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 23 23:54:03 2009 -0700
Fixing #2551 - fixing content changed logs
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c8f859e5def012ce582d73152fae54bb039c4155
Author: Markus Roberts <Markus at reality.com>
Date: Sun Aug 23 15:45:58 2009 -0700
Fix for test isolation portion of Ticket #2511
Ticket #2511 comprises two distinct problems with very similar
symptoms. This patch addresses one of them, the test failures
which result from spec/units/util/backups.rb directly requiering
type/file.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 6fa9271a944f4167f82cb51affe1c0b795428b73
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 18 18:14:19 2009 -0700
Fixing #2549 - autoloading of top-level classes works again
This was broken in the recent refactor around autoloading,
which didn't special-case classes that specified that they
were top-level.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c7526808c9d2d7efbcc39f33112001bd9bd42b56
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 18 18:14:10 2009 -0700
Fixing a heisenbug resulting from a race condition
We had a case where an expectation could be triggered
before the thread finished, in which case it was marked
as a failure.
We just stub the Thread.new to avoid creating a "real"
thread, thus skipping the race condition.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ea417d60915fcb68aeebaf750abb57cb5604fe6d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 17:49:04 2009 -0700
Fixing #2460 - puppetmasterd can now read the cert and key
This follows on to the previous commits which made Puppet
resilient to the service user being absent. This just
changes the default owner of all of the cert-related files
to now be the service user, which means that on the server
all of these files will be owned by that user and on
the client, at least when the service user does not exist,
they will be owned by root.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a49915ad928e01aa1a5505ae52125fac6f4f2744
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 17:27:35 2009 -0700
Not using the service user in settings when it's unavailable
This gets us most of the way toward fixing #2460 - we can
now have the certificate information owned by the service
user when it's available, thus making it so that puppetmasterd
(not running as root) can read it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 14ec838c0aad75098c5c86f77603640f6b1e7efc
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 17:26:36 2009 -0700
Explicitly loading all facts in the directory service provider
We otherwise have load-order issues, where this provider tries
to use the facts but they aren't currently autoloaded by default
in Facter.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5ee660276f3e4f6519b1257673fa690be0416fbd
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 17:04:20 2009 -0700
Adding an 'exists?' delegator from user type to provider
We need this knowledge from the Settings class, and it makes
more sense to delegate than to use direct access to the provider.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 06fcece75ef52168a73013eba2b8bfc50cf71c97
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 15:24:10 2009 -0700
Switching the owner/group settings to use symbolic values
We previously allowed the owner and group to be set to
arbitrary values but we never actually used it -- we always
just set them to '$user' or '$group'. This commit changes
the model to allow 'root' or 'service', where 'service'
is converted to the actual service user/group.
This has the potential to have backward compatibility concerns,
because users could have changed the owner/group in puppet.conf,
but the chances of that are fantastically small.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4eb325a1839e7803e50f148b999952a0c5abd959
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 14:25:52 2009 -0700
Fixing the yamldir group to be a group instead of user
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 058514aaf44f981a3239b402f2ff116ebf0d951f
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 11:31:19 2009 -0700
Moving Setting classes into separate files
This isn't really a refactor, just moving code around.
I did some simple method renaming, also.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b0f219ad177c8e9c261578586f0324cef0c71cd2
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 11:20:14 2009 -0700
Removing chuser on darwin restriction
For too long we have refused to change users
on Darwin because a long time ago the ruby they
shipped with was really, really broken.
It's been fixed for a while, so this just removes
the restriction.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7f749cb93787dc3a0f70b0e24ddda1e0cdfecb3d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 19 11:17:45 2009 -0700
Fixing a ruby warning in the authstore test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c0da3bfebb40198703d7d99f2809b315682e28fc
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 23 12:10:35 2009 -0700
Fixing #2558 - propagating recent fileserving changes
I'd made changes to the internals of the fileserving
system to fix #2544 (mostly switched from passing
the node around and then calculating the environment to just
passing the environment around), but those changes weren't consistent
throughout the fileserving code.
In the process of making them consistent, I realized that the
plain file server actually needs the node name rather than
the environment, so I switched to passing the request around,
because it has both pieces of information.
Also added further integration tests which will hopefully keep
this from cropping up again.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ff39bc707e7f37ddeb28203a9e1bfaddcb9dc641
Author: Markus Roberts <Markus at reality.com>
Date: Wed Aug 19 17:06:41 2009 -0700
Fixes #2550 Handles case where metadata is nil
The checksum function assumed that if the source was present the
metadata (including checksum) was also, and thus that the type of
the checksum could be extracated with a simple RegExp match. When
metadata is nil it returns nil for the source checksum and the
modified function passes this on.
Alternatives would be to default to :md5 or to pass on to checking
the :checksum parameter as if there were no source.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 47dee83464cd2ba95c931e1e4f7d2a018225c351
Author: Markus Roberts <Markus at reality.com>
Date: Fri Aug 21 17:46:57 2009 -0700
Ticket 2559 -- parseonly ignored specified file
In the command-line option parsing refactor from 0.24.x the manifest
specification was lost for --parseonly, so site.pp was always used.
This patch adds the parsing back in.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit a4f68969c04bc19b3382a9d068dee6721caec1c7
Author: John A. Barbuto <jbarbuto at corp.sourceforge.com>
Date: Fri Aug 21 20:18:32 2009 -0700
Fixed #2562 - Recognize the usecacheonfailure option again
Signed-off-by: John A. Barbuto <jbarbuto at corp.sourceforge.com>
commit e408d6c7d562f126df97cd57e04fd7802bc53390
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 18 16:00:21 2009 -0700
Refactoring the Module/Environment co-interface
This simplifies who owns what code in these two classes,
and the result should be much cleaner and simpler.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 796ba5c4ccec117bbc4dec69c670337e70b48634
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 18 15:58:38 2009 -0700
Fixing #1544 - plugins in modules now works again
We had to fix the fileserving plumbing to use the request
environment instead of trying to use the node environment.
This was apparently never fixed after we added the environment
to the URI in REST calls.
There's still a bit of refactoring left to clean up the APIs used
in some of this code.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6bd3627d606cde4bea9293b855be0dd2b1170a92
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 18 15:57:55 2009 -0700
Adding a global cleanup to the spec_helper
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0ef5f228c20a34a562a1c20b206acf2af0eb41ba
Author: Markus Roberts <Markus at reality.com>
Date: Mon Aug 17 21:30:44 2009 -0700
Removed misguided case sensitivity tests
Removed two failing tests added in the process of reproducing #2493
because they enforced case-insensitivity in excess of that provided
by 0.24.8 and thus contrary to user expectations.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit c1967bb8d2e98d53182ea15fb13ac68d7bff7d84
Author: Nigel Kersten <nigelk at google.com>
Date: Fri Aug 14 13:35:24 2009 -0700
Fixes #2513. debian service provider now uses invoke-rc.d to determine enabled? status
commit 7e0924737d817644402b1c3d2d5abb2cf006e76b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 14 13:52:03 2009 -0700
Fixing fact-missing problem when puppet.conf is reparsed
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a35e9bf918db0f6fca45d8b0b002a372cff4f982
Author: Markus Roberts <Markus at reality.com>
Date: Fri Aug 14 19:41:54 2009 -0700
Fix for #2531; adds tests to confirm problem and related cases,
notes fixes specific issue by eliminating the specal case for
opaque strings which caused them to be strings when everything else
was arrays; adds nots and pending tests where FQDN support could be
added but stops short of a full refactor.
commit 299eadb7d903d250c8340049bd78611f0c705920
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Aug 13 21:10:26 2009 +1000
Fixed #2530 - Fixed status setting in the SMF provider
commit e6a7e82dd549ee2aa1dc864937a2d0e5577d50e2
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Aug 15 00:31:13 2009 +1000
Fixed spec typo
commit 75c6e4aed8bf60fbb1bd535fcdd5504f48ce9dde
Author: Markus Roberts <Markus at reality.com>
Date: Thu Aug 6 22:26:27 2009 -0700
Fixes #2493
Added downcasing into find_or_load (which replaced fqfind) to get
back the old behaviour. Adjusted tests so that they would catch
the problem & confirmed that they fail without the downcasing.
Added tests to confirm the existance of #2493; improved
existing autoload tests (removed inter-test interactions)
and noted (with a TODO) that there was dead code in the
feature loading test; added analogus case sensitivity tests
where apropriate.
commit b62d9668e04f40f2e3aa6c0f26dd26d1f75d8e22
Author: Todd Zullinger <tmz at pobox.com>
Date: Thu Aug 6 12:36:20 2009 -0400
conf/redhat/*.init: Fix condrestart/try-restart
Previously, the Red Hat init scripts used the $pidfile or $lockfile as a
test for whether to restart the daemons. This caused condrestart to
start the daemons even when they were not running, in cases where they
had died or been killed without cleaning up the $pidfile/$lockfile.
This was reported by Ingvar Hagelund in Red Hat bug #480600.
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit e9fbd4c9a21f1030f8fef1cd561fc3951399ad31
Author: Todd Zullinger <tmz at pobox.com>
Date: Thu Aug 6 12:34:56 2009 -0400
conf/redhat/client.init: Fix #2123, status options on older RHEL
On RHEL < 5, the status function does not accept a -p option. Using it
causes 'service puppet status' to produce erroneous output. This was
also reported by Aaron Dummer in Red Hat bug #501577.
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit 0461a0250dd8641523e27a22901988564fe94aae
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Aug 11 21:56:10 2009 +1000
Updates to Solaris smf files to reflect new binary locations
commit 55a9cdbac71ef303c4905330b946586262297672
Author: Markus Roberts <Markus at reality.com>
Date: Tue Aug 11 22:58:34 2009 -0700
Fix #2517 - Stack overflow when CA cert missing
This was a "There's A Hole In The Bucket" problem caused when trying
to establish a connection to get a certificate before there was
a certificate with which to establish the connection, ad
infinitum. The solution was to test for the presence of the
CA cert as well as the host cert before attempting to use them.
This patch modifies existing tests to pass with the new code (by
stubbing out the additional FileTests) and adds a new test which
catches the original problem.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 601a2e54aecccedfc0bdd94939d44cc07b4d6588
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Aug 10 23:08:21 2009 +0200
Fix #2516 - Fix format detection when content-type contains charset
Even though Puppet never transmist a charset information in its
response/request content-type, some proxy (especially Apache with the
infamous AddDefaultCharset configuration) may add this "incorrect"
information.
This patch makes sure that only the mime-type is used when looking
for the format associated with a response or a request.
The patch also provides a better error message when the client or server
code is fed with a request whose mime-type can not be mapped to a known
format.
It also fixes a typo noticed by the original reporter.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d86bc889390e56aa007b0099f9f407d4be98c876
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Aug 10 20:08:18 2009 +0200
Fix #2507 - Add missing integration tests
Some of the integration tests were either missing or not complete,
especially tests about exported non virtual resources or virtual
and exported resources.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit aad3b76da045d2fd845866fb6e8a7c9866307cd8
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Aug 7 22:45:12 2009 +0200
Fix #2507 - Exported resources were not correctly collected.
#2507 contains two issues:
* a crash when we filters-out an unwanted resource which had edges
pointing to it.
* resources are losing their virtuality when they are transformed from
Puppet::Parser::Resource to Puppet::Resource. This means we weren't able
to distinguish anymore between an exported resource collected in the same
node as it was exported and an exported resource collected in another node.
The net result is that we can't apply exported resources that are
collected in the same node because they are filtered out by the catalog
filter (see the commits for #2391 for more information).
The fix is to keep the virtuality of the resources so that we can
differentiate those two types of exported resources. We keep this until
the catalog is ready to be sent, where we filter out the virtual resouces
only, the other still exported ones needs to be sent to the client.
To be real sure, the transaction also skips virtual resources.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 63cb1ade80187ebc6f7f24c74e4d1e4db53422c1
Author: Markus Roberts <Markus at reality.com>
Date: Thu Aug 6 14:52:16 2009 -0700
Fixes #2503
Added a random suffex to the temporary file name and verify that
the name is not in use (retry on collison). No additional
tests added as the lifetime of the temporary file is bound by
the routine, making spec driven tests impraticable.
Includes logic to account for dead-end symlinks as well, as per Luke.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit c129f2a15fdccc12baa3d929531221cbade7ff10
Author: Andrew Shafer <andrew at reductivelabs.com>
Date: Mon Aug 10 18:24:48 2009 -0600
Fixes #2360 - Removed annoying log message
This change will effect all the properties implemented with list.rb
(groups, roles, auths, profiles). The change will match [] values for
should as insync when none exist. (so no more log message)
commit b1ffffada99ce12b64bed7f93d4352317d1263b9
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Aug 11 08:17:42 2009 +1000
Fixed #2525 - Wrong method being overridden in Red Hat services
commit a88fc4d24c50d91aa764fa8f52797e86bb6d8965
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 10 04:31:26 2009 +0000
Fixing more tests broken from missing libraries
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9a356ab289a64245cf59cd763dc953a93d71682b
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 10 04:20:54 2009 +0000
Fixing ActiveRecord Indirector tests to skip w/out Rails
Signed-off-by: Luke Kanies <luke at madstop.com>
commit acc5a964738871539cf38675ad3b56d512d3c860
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 10 04:10:51 2009 +0000
Fixing #2489 - queue integration tests are skipped w/out json
All of the tests were failing because we had a call outside
of any of the tests, just to autoload the constant. Removed
that call and stubbed things so the tests don't run without
json.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1a5c5b3fdbcf705d1fcd16f8f26e2b0f85b9e160
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 9 21:03:06 2009 -0700
Fixing #2508 - removing mention of ActiveRecord 2.3
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0cb9072c0e3b37332f4eeaeff061950d6f73d021
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 7 17:39:44 2009 -0700
Fixing #2541 - file cache is more resilient to failure
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 23948d0b7efb482f891a333d4af56dc5ac59c00f
Author: Todd Zullinger <tmz at pobox.com>
Date: Thu Aug 6 22:54:42 2009 -0400
vim: Mark puppetFunction values as contained
This prevents 'file' from being highlighted as a function when it is
used as a resource.
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit 79a4339e1f614647d8b3e074752d8bf0e583aef2
Author: Thomas Bellman <bellman at nsc.liu.se>
Date: Tue Aug 4 14:47:12 2009 +0200
Add shellquote() function.
This adds a new function shellquote() which can be used for quoting
arguments in shell commands used in the exec type.
This only supports Unixoid operating systems. Other systems would
likely require some other quoting.
Signed-off-by: Thomas Bellman <bellman at nsc.liu.se>
commit 79d705faec6b7de2bd644e77e5e4c88e8974f207
Author: Nigel Kersten <nigelk at google.com>
Date: Tue Aug 4 16:38:06 2009 -0700
Fixes #2499. Allows execs to specify an array for the returns parameter
commit b611c34de2ff9fe35633ca2154bc64c6c793af7d
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Aug 5 09:48:40 2009 +1000
Updated fix for #2481
commit f3850729c691fc04482663a115b1b61938db4697
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Aug 5 09:34:51 2009 +1000
Revert "Fxied #2481 - Added status and restart overrides for Red Hat service provider."
This reverts commit 967eb9f52938d8849b99686bf2c0b9da9a183399.
commit cc379b6d72c8d968fc9fa2f6b07db4e88869b159
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Aug 5 08:21:14 2009 +1000
Fixed #2498 - logcheck update
commit 85a36334b487f2f3fce3c4bc5c8496eaede58b46
Author: root <root at absinthe.lovedthanlost.net>
Date: Tue Aug 4 15:30:50 2009 +1000
Removed extraneous debugging
commit bf94de9939b31dbdbbce787696d331eb8e5f1e83
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Aug 4 11:40:59 2009 +1000
Updated two more tests
commit 5b87dba681cc0aa3144dca59216223bb16d10a4a
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 3 16:14:26 2009 -0700
Logs now assume resource params have metadata
We were previously not assuming they had it,
because I figured there were just a couple that didn't.
On closer inspection, none of them did.
The previous commit fixed that, so this commit
fixes the assumption.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1410bed5a40fe945f68b805474b7c022403c3d47
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 3 16:07:30 2009 -0700
Adding metadata delegation from param to resource
This is for file, line, version, and tags, with the
parameter name added to the tags.
This is mostly so logs generated by the parameters
work better.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3ab3a5c7ab9f01b78e0e6d27fce6377de0cfaeec
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 3 15:50:44 2009 -0700
Removing unnecessary debug output
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 488e368efcb0ad6d896743edb76088242c58fb05
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 2 17:50:54 2009 -0700
Adding integration tests for #2371 (backup refactor)
Also removed old conflicting file tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f1406bfbedc593033f0c46241ec34fdc3bfdfbd2
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 2 17:51:53 2009 -0700
Adding many tests for #2371, and slightly refactoring
This mostly focuses on adding all of the detailed tests
for this new code, but it also cleans the code up
just a little bit.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8f60f0c50ee3dfb6453644f5dcded58e6e80e8bb
Author: Steven Jenkins <steven at endpoint.com>
Date: Fri Jul 24 12:31:36 2009 -0400
Fixes for Redmine 2371.
This changes the condition checking of handlebucket, as well as
moves it (and remove_backup) into a separate module. It
additionally refactors common code out of handlebucket into
separate private methods.
Some new RSpec tests which use mock and stubs are added as well,
including removing the old test/ral/type/filebucket.rb tests
since they are already covered by RSpec tests.
commit cd224c6c9f5dedd27bb59822e240b5bae6202ab0
Author: Nigel Kersten <nigelk at google.com>
Date: Fri Jul 31 17:36:50 2009 -0700
Fixes #2464, #2457. Deprecate reportserver for report_server. Add report_port setting. Add tests.
commit 401a9ec546adab01afa1a62477010797bf6fb221
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 3 14:34:20 2009 -0700
Fixing #2484 - "format missing" messages are better
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f6cc59803b32dd1d62cbc5e8ae16ac675ffb296d
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 3 11:53:58 2009 -0700
Fixes #2483 - Log only copies metadata from RAL objects
We were previously trying to figure out what data
was available based on what methods existed, but
that caught a different method profile from
modules.
This fixes it so we only look for this data from
Puppet::Type or Puppet::Parameter instances.
I had to add the ability to skip data that's
not available, since File's 'ensure' parameter
doesn't have 'file' data, I assume because of
the metaprogramming we do around the 'file' value
for 'ensure'. It's a workaround for now, and there's
a test in there to verify it, anyway.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7c4c00f9e0a8120f6ee273c81cf1aff4379b83c2
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Aug 4 07:24:46 2009 +1000
Fixed #2486 - Missing require 'monitor' in parser_support.rb
commit ea34ee6ce64436b41ddb5a9bf71ef311fdf8b92b
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Aug 3 23:12:13 2009 +1000
Added R.I.Pienaar's extlookup.rb to the ext directory
commit 36d3f588b7807a9dab26c27c3118c3ced62d75c2
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Aug 3 21:36:03 2009 +1000
Added example conf/puppet-queue.conf
commit 967eb9f52938d8849b99686bf2c0b9da9a183399
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Aug 3 11:34:56 2009 +1000
Fxied #2481 - Added status and restart overrides for Red Hat service provider.
commit c702f76b271515e9c42dcb923d379fbfac4c83cd
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Sun Aug 2 08:26:04 2009 +0000
rack: SSL Env vars can be in Request.env or ENV
Fix #2386, by checking either Request.env or ENV for the SSL environment
variables. This is necessary as Passenger 2.2.3 changed the location of
these vars, even though the Rack spec says nothing about ENV or these
variables.
commit ca17b3c4dec9a095b7e1bf24a55edbaaa6561a00
Author: Christian Hofstaedtler <ch+git at zeha.at>
Date: Fri Jul 17 13:31:56 2009 +0200
rack: don't directly use the forbidden HTTP_CONTENT_TYPE env var (fixes rack specification conformance)
commit a002e58fe91a679ef75b32f09ffbdebd0ad61b81
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 2 08:51:43 2009 -0700
Removing old filebucket test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d8de446995358b9ee06f943a6de90138c078756d
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 2 08:49:07 2009 -0700
Cleaning up tests for #2469
This is a small refactor of the filebucket type, and a
larger refactor of the tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 266aafa6efa9dff5fb0b49ffdafc9372edcafdfe
Author: Till Maas <opensource at till.name>
Date: Sun Aug 2 11:20:30 2009 +0200
default server in remote filebuckets
With the path parameter set to false, the server defaults
to Puppet[:server]. This allows to use a remote filebucket without
syncing the servername there with the one used on the config file.
To use the default server, this manifest can be used:
filebucket { main: path => false }
A related bug report is:
http://projects.reductivelabs.com/issues/2456
commit 1f8ef6086cc1bb27035cc2534fac781a0349bfb5
Author: Markus Roberts <Markus at reality.com>
Date: Sun Aug 2 11:13:07 2009 -0700
Fixes #2444 - Various JSON test failures
commit 11c0fb77230ea5ba28bfe86a1c2a1469095b6c70
Author: Markus Roberts <Markus at reality.com>
Date: Wed Jul 29 20:55:24 2009 -0700
Fixed #2294 - Classes sometimes cannot be found
This patch should fix the race condition causing ticket 2294; it extends the loading logic so that:
* initial load attempts are processed (as before),
* recursive load attempts return immediately (as before),
* but subsequent concurrent load attempts from different threads
wait on a semaphore (condition variable) and then retry (e.g.
use the now-valid results of the first thread).
This is a slight modification of the solution I'd originally proposed, to prevent a deadlock
that could have arisen if three or more threads simultaneously attempted to load the same item.
Though it solves the bug as reported, it has room for improvement:
* Failures aren't cached, so repeated attempts will be made to
import invalid items each time they are encountered
* It doesn't address any of the underlying referential ambiguity
(module vs. filename)
* The threading logic should probably be refactored into a separate
class (as a start I encapsulated it in an ad hoc singleton class,
so at least it isn't cluttering up the load method)
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 7e5b56212eef22be381a480dcaf38b33620674dd
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 12:45:55 2009 -0700
Adding #2477 - puppet can apply provided catalogs
This provides the other half of #2440 - you can
compile catalogs into json with puppetmasterd,
and now you can take those json catalogs and apply
them.
This allows you to use whatever mechanism you want
to ship the catalogs around.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 97274ad976e3584ae850ad91cc886fae1dcdbbc6
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 2 07:27:16 2009 +0000
Fixing problems my Feature refactor caused
The problems were that I wasn't propagating return
values sufficiently, such that false values didn't
travel enough, and the 'name' attribute was necessary
in the private method but wasn't actually passed in.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6fb8bf625fcfa12b085101838813ab7bc4635dae
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:58:47 2009 -0700
Fixing ruby warning in definition test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b3545fc528104c9b2431d8ffddd480c30207b38e
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Aug 2 17:03:13 2009 +1000
Fixed global deprecation error in useradd Unit tests
commit dc244723bb23fe49b51cbb74bc372303d29fd180
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 16:39:27 2009 -0700
Adding a test for the Exec type
I thought I'd found a bug, but I couldn't reproduce
it. This test was supposed to demonstrate the bug,
but is at least good enough to leave in.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 58d95872ce5afddc158ac4b229363c5f63859c5d
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 16:29:26 2009 -0700
Speeding a test up through stubbing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d4d8372bf8174dfebcd6ae549710c9750b70bb30
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:32:57 2009 -0700
Fixing a small test by stubbing instead of mocking
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f7e1c36c6c0c03e1f969da7856828c92fdee2b61
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:28:55 2009 -0700
Fixing a test broken by the regex features
Unsetting scope vars was broken, but it was
only ever used in testing (and apparently rarely
at that), so it wasn't caught.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 54a225dd26d867d5672df48a5bc0ed858821bf40
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:24:54 2009 -0700
Fixing tests broken by caching autoload results
These tests tried to load something, verified
the loads didn't work, and then created
the thing to load. This is a bit silly,
so I just removed those sections of the tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1ce31b4f5c5a38aa6914a5367ea6dd8db53174ab
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:19:02 2009 -0700
Migrating Handler base tests from test/ to spec/
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cc3f56a68b04ba26c0234e1434abe7f58e6c7218
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 23:11:37 2009 -0700
Migrating Feature tests to spec
This was to fix a failing test/unit test.
Test coverage is now a bit better, more maintainable,
and I refactored the code just slightly to make it a bit
cleaner.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 21d1d257a804e472607989ef63fb7d7ce1ddee77
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 22:47:32 2009 -0700
Fixing cron test to match new behaviour
7 was added as a valid weekday in #2293, and this
test just corrects that.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 849fa67b6ebc69df9a5b8c95eb68281ccf45d376
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 1 22:45:46 2009 -0700
Migrating tests to spec and removing an obsolete test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6f458cca5379229da066787045b74acafb184c07
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 00:33:55 2009 -0700
Logging the configuration version we're applying
This is just an additional info log in the transaction,
and is only done if the version is non-nil.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ac58e274c409b69073e304a8355bbe4ccb37350a
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 00:27:44 2009 -0700
Configuration version information is now in logs
The log instances have file, line, and config version
information, although it's not currently printed.
It's available in the reports, and you can strip it
out with your own processors.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6ed01037ad8b6d8d5ff7158ef6e09c785ed8b9fe
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 23:52:44 2009 -0700
Adding support for an external catalog version
This allows you to specify a command used to determine
the catalog version. Also added an integration test
to verify the version cascades.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 39320b8794549fa7806f2e9e57346242b0b7e847
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 23:49:07 2009 -0700
Cleaning up duplication in another test file
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 25fae5f3e991cccc6dcebb6ea5b0967d99200218
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 23:34:05 2009 -0700
Removing duplication in the test structure
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 36c0662f13b0f00fe0b75ba45f892a1c7c3218bf
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Aug 2 02:15:34 2009 +1000
Simplified Rakefile and moved tasks to tasks/rake directorya
commit b45ccf8d38a10d3f5226cbabe494240901e4e383
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 19:37:11 2009 +0200
Implement node matching with regexes
This patch enhance AST::HostName to support regexes, and modifies
the parser to allow regex to be used as node name.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>]
commit 58a73b5c68485dc5d41a46936c31e5fad5f037b5
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 19:42:24 2009 +0200
Make sure node are referenced by their names
This patch uses the unused AST::HostName as the only way to reference
a node in the AST nodes array.
The AST::HostName respect the hash properties of the underlying
string, to keep the O(1) hash properties.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3ebf148bf3d82d25e690aec6ec49975e0837e604
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 19:56:34 2009 +0200
Enhance selector and case statements to match with regexp
The case and selector statements define ephemeral vars, like 'if'.
Usage:
case statement:
$var = "foobar"
case $var {
"foo": {
notify { "got a foo": }
}
/(.*)bar$/: {
notify{ "hey we got a $1": }
}
}
and for selector:
$val = $test ? {
/^match.*$/ => "matched",
default => "default"
}
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit ef68967f2b72e609a9d69e53771a61fd9f522149
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 19:13:54 2009 +0200
Fix #2033 - Allow regexp in if expression
This changeset introduces regexp in if expression with the use of the
=~ (match) and !~ (not match) operator.
Usage:
if $uname =~ /Linux|Debian/ {
...
}
Moreover this patch creates ephemeral variables ($0 to $9) in the current
scope which contains the regex captures:
if $uname =~ /(Linux|Debian)/ {
notice("this is a $1 system")
}
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 17e62b1ec806815abea909291df1e591a825c375
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 19:11:03 2009 +0200
Add AST::Regex, an AST leaf node representing a regex
Add a regex rule (unused for the moment) to the parser.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 4f9545f2f6cb377eff126c9d52b421ab405aa677
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jul 26 13:44:35 2009 +0200
Add regexes and regex match operators to the parser
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 0ccd2590b2bf0494388c4656759b47612776bc53
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jul 26 13:44:06 2009 +0200
Add regex, match and not match token to the lexer
The lexer recognizes regex delimited by / as in:
/^$/
The match operator is defined by =~
The not match operator is defined by !~
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 201ae59eacaff289a8a5bb45f7d301c1a490a119
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Jun 12 23:24:36 2009 +0200
Allow variable $0 to $9 to be interpolated, if ephemeral
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit f357a9192647fc5d436d4c934b1912f59996389f
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jul 26 14:03:14 2009 +0200
Implement ephemeral scope variables
Those variables have been created to be short lived and used mainly
to define temporary special variables.
They do not persist after a call to unset_ephemeral_var.
Also Scope#set_ephemeral_from can be used to promote a regexp
MatchData to ephemeral values.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d40ef291191e627a91d6ec73b438853e2d3a73e8
Author: Eric Sorenson <eric at leterel.apple.com>
Date: Thu Jul 30 17:46:07 2009 -0700
Signed-off-by: Eric Sorenson <ahpook at gmail.com>
Apologies if this violates the no-trivial-patches rule. I am getting
used to git and this seemed like a harmless place to start.
Documentation fix for help text, configuration reference URL is 404 now.
Updated to equivalent page on wiki, fixes #2466
Signed-off-by: Eric Sorenson <ahpook at gmail.com>
commit 6d22afb241b290dcfc6a95079a2297afedb8ce96
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 16:07:05 2009 -0700
Modifying the REST client error to make server errors more clear
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 21f477a57c2e1dc1ce4b47ea6ee37f8eef46e40c
Author: Nigel Kersten <nigelk at google.com>
Date: Thu Jul 30 10:15:46 2009 -0700
Fixes #2472. Load Facter facts when ralsh is invoked, plus test.
commit 2e41edbd235ddf8278073fd645821f48523a0af3
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jul 31 22:49:57 2009 +1000
Update CHANGELOG.git
commit ebb5a1f6fff6bdd143a6d64ffe9f9f8fa70d649e
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jul 31 19:00:40 2009 +1000
Fixed ci_spec task for RubyGems 1.3.5
commit b6b903eedd383e66593315fdc8163614ad22db79
Author: Nigel Kersten <nigelk at google.com>
Date: Thu Jul 30 09:59:32 2009 -0700
Fixes #2461. Provide new and old code paths for macosx_productversion_major with deprecation warning
commit 26b0c70dcd5f6ef8685280dd039dcac96b1307df
Author: Markus Roberts <Markus at reality.com>
Date: Mon Jul 27 15:13:12 2009 -0700
Fixing typo in two tests which caused them to always pass
commit 76fc2b177a026e49d8370de2092f77108769110a
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 19:10:29 2009 -0700
Fixing #2440 - catalogs can now be compiled on demand
This uses the locally cached yaml facts and prints the
catalog in json. It's meant to be used one-time, but
you have to use puppetmasterd since we assume it's the
executable correctly configured for compilation.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 832b6ff1e18cf403213cbeb42646b5740669e6a5
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 18:48:18 2009 -0700
Exiting from app failures instead of raising
This protects the user from seeing stack traces in normal situations.
It makes sense here because this is explicitly for user interactions.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4ea3f17eee236bcbc4481b08eeb5ece1e51cc929
Author: Markus Roberts <Markus at reality.com>
Date: Mon Jul 27 17:29:20 2009 -0700
Minimal patch to fix #2290 (/tmp permissions)
This patch rectifies the specified problem by resetting the
permissions to 1777 after the offending tests have run. I
am providing it for testing but suspect there may be a deeper
bug hiding behind this one--specifically, it isn't clear to
me that an analogous problem could not occur in production use
(which this patch to the spec would not fix).
This patch also fixes the specific test isolation failure which was
causing ticket #2290; if spec/unit/util/storage.rb was run by
"rake spec" before spec/integration/network/server/webrick.rb
without any intervening tests which did a Puppet.settings.clear,
the the webrick test would change the permissions on /tmp.
Signed-off-by: Markus Roberts <Markus at reality.com>
commit 08ff9e84de18e9b1db69c73ea3e49b90fe5fd7c0
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jul 29 23:08:44 2009 +0200
Fix #2467 - rack: suggest putting puppet/lib at beginning of RUBYLIB search path
If you happen to already have puppet code somewhere in your ruby path, you
might get unexpected behaviour when trying to run puppetmaster with passenger.
Suggesting that the path to puppet/lib gets prepended instead of appended to
RUBYLIB could save time to some.
Signed-off-by: Marc Fournier <marc.fournier at camptocamp.com>
commit fb60f90d13f1d1dc1ccc884030230764be642d09
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Jul 29 21:58:02 2009 +0200
Fix #2465 - Default auth information is confusing with no auth.conf
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 0ca9b5322117879cf930c88a0473558d9e437ece
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Jul 29 21:21:25 2009 +0200
Fix #2459 - puppetdoc added namespace classes as RDoc modules instead of classes
Puppetdoc while parsing a class name creates intermediate RDoc classes
to form a hierarchy. Due to a coding error, those intermediate classes
were created as RDoc modules.
Later, when puppetdoc was parsing the definition of one of this class,
it wasn't finding it in RDoc list of classes (since it was recorded
as a module).
Puppetdoc was then creating documentation for two objects of the same
name.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 18b5d614462e2af8faca92fa1881f4968487d3e7
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Wed Jul 29 20:18:24 2009 +0200
Fix #2429 - vim: class/define/node should only be followed by whitespace
Thanks to Charles Duffy for noticing this and providing this patch.
Signed-off-by: Marc Fournier <marc.fournier at camptocamp.com>
commit da828a4234754e9122034706ca65f6b6f7d5c2ab
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jul 25 12:55:20 2009 +0200
Fix #2448 - fix the broken runit provider and tests
The runit provider was broken when the daemontools provider
was enhanced.This patch aims to fix this.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 389843629c5ec2950f44b0fdaacb1d7470bc4aec
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jul 29 07:46:49 2009 +1000
Fixed #2405 - Mount parameter "dump" doesn't accept all valid values on FreeBSD
commit 9825bec3ad612eb3ec980cbae3a80f611b4a70a0
Author: Nigel Kersten <nigelk at google.com>
Date: Fri Jul 24 17:23:00 2009 -0700
Fixes #2362. Do not validate users/groups when supplied with numeric uid/gids
commit 450a19c405810358684a47b87ef9eca26589b95f
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 20:50:01 2009 +0200
Fix #2454 - Definition named after a module don't show in puppetdoc
RDoc#find_local_symbol can return a module. So if you have a defition
of the same name as the module in which it is defined we weren't
producing documentation for it.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 8551ece0d55dafceab633ee6eec46fb1c54c1446
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Jul 28 20:47:48 2009 +0200
Fix #2453 - puppetdoc mixes long class names that look alike
The issue is that RDoc (the engine producing the documentation) is
buggy:
With a class named: A::C
and a class named: D::A::E
Then RDoc was attaching E under the root ::A and not D::A.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit e3ee594fdfa0e7a6d9de26c4307e217de866f462
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jul 18 13:08:57 2009 +0200
Fix #2422 & #2433 - make sure puppetdoc transform AST::Leaf boolean correctly
AST nodes don't have a valid to_s that is producing a correct
representation of said node.
This patch adds some of the AST node to_s to produce correct
values that can be used verbatim by puppetdoc to render
the documentation.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b3b76dffdd9cd8ed5c3d0230624bf05015bec5b8
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 16:51:22 2009 -0700
Fixing #2296 - overlapping recursions work again
This fixes the behaviour when you have file recursions
that overlap - we again correctly use the most
specific information.
It's still a bit expensive when you do this, but
at least it behaves correctly, and it should be
a rare circumstance.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9120712f97c12dad0c743271b4f64cf545319b69
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 21 17:47:28 2009 -0700
Fixing mocks to remove warnings
Signed-off-by: Luke Kanies <luke at madstop.com>
commit eeec8e99eaeb6bb97173f2bc04148bff3be58036
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 21 17:38:57 2009 -0700
Fixing #2423 - no more strange dependency cycles
We were getting strange dependency cycles because our class structure
mirrored our scope structure. We can't change the scope structure
without switching from a dynamically scoped language to a lexically scoped
language, which is too big of a change to make right now. Instead,
I'm changing the resource graph so that all classes default to just
having an edge to the 'main' graph.
This will be a behaviour change for many, in that you were getting
automatic dependencies from this old behaviour, but it will bring
consistency.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7d40f9e039964e2c3f9e94b5ef2ccbded45a59a5
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 09:42:09 2009 -0700
Fixing #2443: Adding debugging guidance to dep cycle errors
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b4facb0bacaa6e3bc1eb3123c69e037e0ba8ec69
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 15:35:34 2009 -0700
Fixing a test broken by changing the default os x package type
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b418921fb846e7d083c39a9556810ff067878e86
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 15:32:48 2009 -0700
Fixing selinux tests broken in the fix for #1963
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 719e76b8ce5293cb30c70e62cf3182c6149e2620
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 24 15:26:38 2009 -0700
Fixing #2445 - fixing the mount test mock
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f13f08dfbf659cba6317aac2d77096a8688fc3bd
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jul 24 20:17:32 2009 +1000
Minor fix to URL for LDAP nodes documentation
commit 7c859a7dd72eeddc6364708077862ca8ed40eee7
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 22:42:20 2009 -0700
Fixing #2399 - removing client-side rrd graphs
This feature has been broken since who knows when,
yet no one's noticed. Thus, it's a good
candidate for removal.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f6d61455be01a1e81c2f48a720e83fbb646e9ab9
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 23 16:32:50 2009 -0700
Fixing #2421 - file renaming errors now propagate
Signed-off-by: Luke Kanies <luke at madstop.com>
commit db82523a0ec12fcd63b4b52173268b1e6c41df36
Author: Nigel Kersten <nigelk at google.com>
Date: Thu Jul 23 09:01:24 2009 -0700
Fixes #2438, get major OS X version from Facter and replace Puppet::Error invocations with fail builtin
commit 22145e759cf52d89c685b961d539ce73735258b0
Author: Nigel Kersten <nigelk at google.com>
Date: Thu Jul 23 08:18:13 2009 -0700
Update install.rb to cope with all OS X versions, not just 10.5
commit 935c46351f6f6730569c50fd0c59e8157486b827
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 15 16:03:44 2009 -0700
Fixing #2403 - provider specificity is richer and better
We have extended the concept of provider specificity so it
now includes both specified defaults and class depth, so:
* We are much more likely to choose the correct provider;
e.g., 'init' will be chosen over 'base'
* We're much less likely to print this warning, because it's
only printed when provider specificities are equal which
is much rarer
lib/puppet/provider.rb | 4 ++--
lib/puppet/type.rb | 4 ++--
spec/unit/type.rb | 17 +++++++++++++++++
test/ral/manager/type.rb | 22 ----------------------
4 files changed, 21 insertions(+), 26 deletions(-)
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d95b687045920c7d7fed5da1fe03b0feac86327a
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jul 23 23:09:34 2009 +0200
Fix #2439 - let puppetdoc use loaded_code
Since there isn't any unit test for puppetdoc rdoc code (my fault),
nobody noticed it was using direct access to the parser AST array.
This changeset fixes the way puppetdoc uses the parser results.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit ef5c4aeb1f58bd37e8b4ea0fa17fbdbc2fbf7677
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jul 23 14:45:29 2009 +1000
Fixed #2436 - Changed ralsh to use Puppet::Type.new and avoid deprecation notice
commit 0c18013cb6bf9faff21bd049410e2baf1ef8aa90
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jul 23 09:15:02 2009 +1000
Fixes #2430 - Stock apache2.conf for passenger incorrect
commit c383ceb282d018b6d8ec348628353a2e3363da3b
Author: Nigel Kersten <nigelk at google.com>
Date: Tue Jul 21 09:29:27 2009 -0700
Make pkgdmg default Darwin provider, make confines consistent on Darwin package providers.
commit 98599c4a8d11cad4ecc11ee813a8c33a6aa9e5bb
Author: Nigel Kersten <nigelk at google.com>
Date: Mon Jul 20 07:59:32 2009 -0700
Convert to using sbindir for OS X packages, clean out previous executables in bindir
commit c65974376700f54548a9412e04889ad54be84ff9
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Jul 20 20:56:23 2009 +0200
Fix #2425 - make sure client can contact CA server with REST
The various REST SSL terminii were never setup to use the
ca_server/ca_port if one is setup.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 17205bb4e5d246f7a47b995826927a38b83fb3d0
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Jul 20 23:09:09 2009 +0200
Fix #2424 - take 2, make sure default mounts allow every clients
If there isn't any default mounts for plugins/modules, puppet
auto creates them. The issue is that they don't have any
authorization attached, so they default to deny all.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit f2c55cc6b4dd6a4db307ea1c031120398fe5fc7e
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jul 9 20:59:41 2009 +0200
Fix #2378 and #2391 tests
Fix #2378 - Add some integration tests for catalog filtering
Fix #2391 - Fix up some of the tests
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 8bbd8b4bb295fee7ad99f6137c9851528f1729cc
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jul 18 15:34:44 2009 +0200
Fix #2424 - File server can't find module in environment
Actually, the issue is:
* when the web server gets the request, it creates an indirection
request, filling attributes like ip or node from the HTTP request.
To do this, all the interesting attributes are given in a hash
(called options, see P::I::Request#new).
Once the request is properly initialized the options hash doesn't
contain the ip or node information (see set_attributes)
* the request is then transmitted to the file_serving layer,
which happily wants to use the node attribute to find environments or
perform authorization.
Unfortunately it fetches the node value from the request options hash,
not the request itself.
Since this node information is empty, puppet fails to find the
proper mount point, and fails the download.
This change makes sure we pass all the way down the node and fix
the authorization check.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit effaf80ae662076e3578c3eb7a18b863ef104bb4
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jul 18 15:24:12 2009 +0200
Fix small typo in the fix for #2394
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit a06094ea0f3a38446859de55100ac7fdb0488a9d
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jul 4 12:49:11 2009 +0200
Feature #2378 - Implement "thin_storeconfigs"
Thin storeconfigs is a limited version of storeconfigs that is
more performant and still allows the exported/collected resources
system wich is the primary use of storeconfigs.
It works by storing to the database only the exported resources, tags
and host facts.
Since usually those exported resources are less than the number
of total resources for a node, it is expected to be faster than
regular storeconfigs (especially for the first run).
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b2a008e30ea57f0c94d605de855c45c0fdf0e5ce
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jul 9 20:59:41 2009 +0200
Fix #2391 - Exported resources never make to the storeconfigs db
The issue is that when we convert Puppet::Parser::Resource catalog
to a Puppet::Resource catalog before storing it to the database,
we don't allow virtual resource to be converted.
Unfortunately exported resources are virtual by design, and as
such aren't converted, and we lose them, so it isn't possible
to store them in the database.
Unfortunately, the client will get the exported resources too.
The fix is dual-fold:
* we make sure exported resource are skipped when the transaction is
applied as a last safeguard
* we filter-out the catalog through the catalog compiler terminus before
the catalog is returned to the client
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 8f8240763b0a8ab74b5b78eeb2372a2aa7848049
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jul 16 20:53:36 2009 +0200
Fix #2261 - Make sure query string parameters are properly escaped
The problem is that URI.escape by default doesn't escape '+' (and
some other characters). But some web framework (at least webrick)
unescape the query string behind Puppet's back changing all '+'
to spaces corrupting facts containing '+' characters (like base64
encoded values).
The current fix makes sure we use CGI.escape for all query string
parameters. Indirection keys/path are still using URI escaping because
this part of the URI format shouldn't be handled like query string
parameters (otherwise '/' url separators are encoded which changes
the uri path).
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit c86d44ed826b99752fd0ee85b2a77eaadd8a57ae
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jul 16 21:28:09 2009 +1000
Fixed #579 - puppet should try to clear solaris 10 services in maintenance state
commit 910a5e2f39d2fefab28768f2a2d3d02de7abd54d
Author: Ricky Zhou <ricky at fedoraproject.org>
Date: Sat Jul 11 01:57:52 2009 -0400
Fix #1963 - Failing to read /proc/mounts for selinux kills file downloads
This works around a linux kernel bug that causes a select() on
/proc/mounts to hang.
commit ba824e94fd0c7652b9b7bb7878f76a935dc7927d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 15 14:44:31 2009 -0700
Fixing #2245 - provider lists are not lost on type reload
We've moved the @providers class instance variable from
the individual Puppet::Type subclasses into a single
class instance variable in the Puppet::Type base class,
and are using an accessor to retrieve the per-class
providers hash.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit eb40966777beaff2ceca8b91e10e3cb0132ec218
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 13:25:07 2009 -0500
Ruby no longer clobbers puppet autoloading
We basically just make sure that we tell Ruby
about files we've loaded, so you can 'require' these
files and doing so will essentially no-op, rather
than clobbering the already-loaded code.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a42e8788b1fde5273ba1e34f6d90c451394849b8
Author: Nigel Kersten <nigelk at google.com>
Date: Mon Jul 13 16:18:51 2009 -0700
deprecate NetInfo providers and examples, remove all NetInfo references and tests.
commit 22f56327e74a1201cf25d82e980b2500057d698e
Author: Sam Livingston-Gray <geeksam at gmail.com>
Date: Mon Jul 13 15:22:54 2009 -0700
Fixed #2410 - default acl logs as info instead of warn.
Signed-off-by: Sam Livingston-Gray <geeksam at gmail.com>
commit 65b01375cedd878818f433a2c09fc8128f912d36
Author: Sam Livingston-Gray <geeksam at gmail.com>
Date: Mon Jul 13 15:18:57 2009 -0700
Adding test for current auth config warning.
This is a step in fixing bug #2410.
commit 74f5ad457a95580e7cef20fa850afd98eabaa6ed
Author: Sam Livingston-Gray <geeksam at gmail.com>
Date: Mon Jul 13 15:56:59 2009 -0700
Fixed #2394 - warn once on module mount deprecation.
Signed-off-by: Sam Livingston-Gray <geeksam at gmail.com>
commit f46a52a3344bdc8c3caf8a80c7af3ea5dec5e66b
Author: Sam Livingston-Gray <geeksam at gmail.com>
Date: Mon Jul 13 15:54:16 2009 -0700
Add test for current module mount deprec warning.
commit 858d3334004bbcd642443a5de061b9733a8e765c
Author: Nigel Kersten <nigelk at google.com>
Date: Mon Jul 6 14:55:52 2009 -0700
Fixes #2258,#2257,#2256. Maintain correct type for integers/booleans, allow correct values, and fix rule array handling
commit 44f127f738f6427bdf2adbe1d06d57b7b62e715e
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jul 2 14:01:39 2009 +1000
Added Markdown mode to puppetdoc to output Markdown.
Requires the pandoc binary to function (http://johnmacfarlane.net/pandoc/).
commit 8a8ce9d40fd97b26906301b0587395c9fb9fddf6
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jul 10 12:19:26 2009 +1000
Excluded directories from rcov coverage report
commit d152c5e358cad1241ce6cdcc302c1b2f3175f480
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jun 28 13:55:50 2009 +0200
Allow boolean value for boolean cli parameter
This is to fix puppetdoc boolean parameters.
Puppetdoc defers sending parameters to Puppet::Util::Setting, and
in this case, boolean parameters are stored as a boolean value.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 911b490f2288f81b36d484b40dd3d875320cf624
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jun 28 14:20:35 2009 +0200
Fix #2364 - Associates the correct comment to the right statement
Due to the problem that we associate documentation in the lexer and
not in the parser (which would be to complex and unmaintenable to
do), and since the parser reads new tokens before reducing
the current statement (thus creating the AST node), we could
sometimes associate comments seen after a statement associated
to this one.
Ex:
1. $foo = 1
2. # doc of next class
3. class test {
When we parse the first line, the parser can reduce this to the
correct VarDef only after it lexed the CLASS token.
But lexing this token means we already pushed on the comment stack
the "doc of next class" comment.
That means at the time we create the AST VarDef node, the parser thinks
it should associate this documentation to it, which is incorrect.
As soon as the parser uses token line number, we can enhance the lexer
to allow comments to be associated to current AST node only if
the statement line number is greater or equal than the last comment
line number.
This way it is impossible to associate a comment appearing later in the
source than a previous statement.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit faefd92c78f69580204c40179f3f0b766b0208fb
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jun 28 14:12:59 2009 +0200
Make sure the parser sees the correct line number
Careful inspection of the parser code show that when we
associate a source line number for an AST node, we use the
current line number of the currently lexed token.
In many case, this is correct, but there are some cases where
this is incorrect.
Unfortunately due to how LALR parser works the ast node creation
of a statement can appear _after_ we lexed another token after
the current statement:
1. $foo = 1
2.
3. class test
When the parser asks for the class token, it can reduce the
assignement statement into the AST VarDef node, because no other
grammar rule match. Unfortunately we already lexed the class token
so we affect to the VarDef node the line number 3 instead of 1.
This is not a real issue for error reporting, but becomes a real
concern when we associate documentation comments to AST node for
puppetdoc.
The solution is to enhance the tokens lexed and returned to the parser
to carry their declaration line number.
Thus a token value becomes a hash: { :value => tokenvalue, :line }
Next, each time we create an AST node, we use the line number of
the correct token (ie the foo line number in the previous example).
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 869ec273a085c1fa28da14bfd627ffc24af87a07
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jun 27 12:21:30 2009 +0200
Fix #2366 - puppetdoc was parsing classes in the wrong order
It could happend that we were generating doc for subclasses
before classes, in which case we were forgotting some
parent class instance and recreating them.
We ended up generating doc for some classes multiple times, from
which some were missing documentation.
The fix is to sort the parsed classes alphabetically, which auto-
matically puts enclosing class before enclosed classes.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 4c659b768f9ab9f0468245af789b3c817f5c4be4
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jul 10 10:53:20 2009 +1000
Added rcov coverage to Spec tests
You will need to install the relevance-rcov gem:
gem install relevance-rcov --source http://gems.github.com
commit 1fd98b15a4f93c77182b080c68960d6d1c0bcd59
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jul 8 08:44:19 2009 +1000
Fixes #2367 - Mongrel::HTTPRequest returns a StringIO object
When the PUT body is large enough that Mongrel::HTTPRequest#body returns a StringIO object instead of a String. StringIO#to_s then returns "<StringIO#8236987299>" instead of the string contents.
When that string is passed to YAML it returns false which is then passed to save_object without any real time checking.
This is a combination of patches from Jordan Curzon and Ricky Zhou.
commit 8b09b8316e5f385522fcc4353b3cea725076fb25
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jul 5 19:45:40 2009 +0200
Fix #2082 - puppetca shouldn't list revoked certificates
This patch does two things:
* it enhance puppetca to list revoked certificates (prefixed by -)
* it fixes the ca crl verification which was broken
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit ea66cf6b9a5de1dd784dfed8995babf90225f8a0
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jun 28 14:42:04 2009 +0200
Fix #2348 - Allow authstore (and REST auth) to match allow/deny against opaque strings
This patch removes the limitation of allow/deny which were
only matching ip addresses or hostname (or pattern of).
It makes sure any kind of string can be matched (by strict
equality) while still keeping the old behaviour.
Opaque strings can only contains: alphanumeric characters, -
_ and @.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 1e83aadc749aea9d52281d4f4041f6144a7229c7
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jul 5 19:38:01 2009 +0200
Fix #2392 - use Content-Type for REST communication
There were two problems:
* server->client communications is using Content-Type with the
direct format name instead of the format mime-type.
* client->server communications is not using Content-Type to
send the format of the serialized object. Instead it is using the
first member of the Accept header. The Accept header is usually
reserved for the other side, ie what the client will accept
when the server will respond.
This patch makes sure s->c communication contains correct Content-Type
headers.
This patch also adds a Content-Type header containing the mime-type of
the object sent by the client when saving.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit aaca17a26092f3fece9a835eddf3ad6b9cf82300
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Jul 5 18:50:24 2009 +1000
Fixed #2293 - Added cron syntax X-Y/Z and '7' for sunday
commit cddc365e9bac786c7a64240073b69bc54b6d2f2e
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jun 4 00:33:25 2009 -0500
Switching to LoadedCode from ASTSet
I also took the opportunity to clean up and simplify
the interface to the parts of the parser that interact
with this. Mostly it was method renames.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fc1f8cdbee606da0d2a1a162942295d28cdcbf64
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jun 4 00:32:12 2009 -0500
Adding a special class to handle loaded classes/defines/nodes
This class is extracted from the Parser class,
and the main driver for it is to enable us to put mutexes
around some of the hashes to see if they're the source
of a race condition.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 325b8e4f6f21341d0c8d04297b019db47af2abc6
Author: Christian Hofstaedtler <ch+git at zeha.at>
Date: Thu Jul 2 09:45:15 2009 +0200
Fix #2383, an incompatibility with early ruby 1.8 versions
Earlier ruby 1.8 versions do not have start_with? for Strings.
Found by John Barbuto.
commit 46112daf979c71fb004d51289096ae37561d23bb
Author: Jordan Curzon <curzonj at gmail.com>
Date: Thu Jul 2 12:47:42 2009 -0700
Fixing #2238 In some cases blank? is not available on String.
Signed-off-by: Jordan Curzon <curzonj at gmail.com>
commit cdd166244ab55c9f3129bdbffd16bd55bd8ed10e
Author: Jordan Curzon <curzonj at gmail.com>
Date: Wed Jul 1 21:39:22 2009 -0700
Fixing #2238 - Deal with nil hash keys from mongrel params
Mongrel::HttpRequest.query_parse outputs a params hash with nil
keys given certain query strings. Network::HTTP::Handler.decode_params
needs to check the incoming values.
Signed-off-by: Jordan Curzon <curzonj at gmail.com>
commit 769c8aa71e5b4855662314f13b1197853cdc843a
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Jun 28 15:12:32 2009 +1000
Final fix to CI test rakes
commit a6816fff5a0421d614da50eeaf12aa7178a82b09
Author: Nigel Kersten <nigelk at google.com>
Date: Fri Jun 26 13:28:44 2009 -0700
Set ENV['PATH'] to an empty string if non-existent
Signed-off-by: Nigel Kersten <nigelk at google.com>
commit 64a47203e69746e7e3724e3433702856e68c068d
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jun 27 08:58:59 2009 +1000
Fix to CI rake tasks
commit 5680cd5029c8b3a2cf5a2a3b10df6acf7a9fc870
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 13:11:26 2009 -0700
Fixing #2197 - daemontools tests now pass
This actually involved a bit of rewriting
of the code, but the code's simpler now, too.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 603b9cf1a435f6662db39be66f91527a8e20c112
Author: Stig Sandbeck Mathisen <ssm at fnord.no>
Date: Sun Jun 14 21:47:46 2009 +0200
Change the diff default output to "unified"
commit 9bc9b5c0c062ff60af4272fd6d176b8a8a1d6c91
Author: Martin Englund <martin.englund at sun.com>
Date: Wed Jun 24 21:53:33 2009 -0700
Added missing colon to suntab
commit 0f2d70dc91a10d38d088ad5d8a351187b143e144
Author: Martin Englund <martin.englund at sun.com>
Date: Wed Jun 24 21:27:34 2009 -0700
Fixed #2087 and refactored the code that gets the smf service state
commit 3f070c118b1ae2f3c76172d320ff04e92618a9b3
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 11:03:46 2009 -0500
Using the logging utilities to clean up module warnings
This just makes it easier to add context to warnings
and other logs from the module.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit feb7f89078f038e20895ff2c8042326e6b85b957
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 10:57:54 2009 -0500
Fixing #1064 - Deprecating module 'plugins' directories
You should now use 'lib' instead of 'plugins'.
The old directory still works, but you get a warning
for every module that uses it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ccf4e69b684e6620c457475c4da6a70975d52dd5
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 10:40:44 2009 -0500
Removing deprecated :pluginpath setting
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4036de9591bc1ab19df3a0c3bae4567240a4ec85
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 16 10:26:38 2009 -0500
Fixing #2094 - filebucket failures are clearer now
We just add a bit of information to the exception.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ed876e0264bbb1ba86bc302d517d8f48f388da3e
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jun 14 19:27:30 2009 -0500
Refactoring part of the file/filebucket integration
The goal of this commit is to fix ordering issues
that could result when the filebuckets are added
to the catalog after the resources that use them.
This condition showed up somewhat arbitrarily.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bd81c25b4072c3426af67e0366b18436c8236dc4
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jun 14 15:40:33 2009 -0500
Adding tests for file/backup behaviour
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c45ebfad1b5525a8297bef97c04aed9e485eff76
Author: David Lutterkort <lutter at redhat.com>
Date: Fri Jun 12 16:13:07 2009 -0700
Fixed pi binary so --meta option works and updated documentation
Signed-off-by: James Turnbull <james at lovedthanlost.net>
commit d2080a5524f993ee746e33364582244cf0e17561
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jun 12 17:41:02 2009 -0500
Fixing #2323 - Modules use environments correctly
Previously, modules were not using their environments
when looking up their paths, which meant that they
often found files in the wrong environment.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit aab20201f44271df49d57fbf7c0925f09246b8f0
Merge: 1c4ef61a13c89bc946b9167832f889bfd29c0681 b9e632f4e1b8cec9720ed0bb80caf2bab74209d6
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jun 13 01:57:26 2009 +1000
Merge branch 'tickets/master/2102'
commit b9e632f4e1b8cec9720ed0bb80caf2bab74209d6
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jun 12 23:19:55 2009 +1000
Fixed #2102 - Rails feature update fixed for Debian and Ubuntu
commit 1c4ef61a13c89bc946b9167832f889bfd29c0681
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jun 12 23:33:21 2009 +1000
Fixed #2052 - Added -e option to puppet --help output
commit d3323331e96cbc79563febc249e106a3ae8e7647
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Jun 12 13:40:15 2009 +0200
Fix #2333 - Make sure lexer skip whitespace on non-token
Comments and multi-line comments produces no token per-se during
lexing, so the lexer loops to find another token.
The issue was that we were not skipping whitespace after finding
such non-token.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 5fbf63ce789b015da9abb95d7e9fbbf4a44ba7d1
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jun 12 22:39:33 2009 +1000
Updated split function and add split function unit tests (courtesy of Thomas Bellman)
commit a585bddadf49b1c1d41052f6fdd62db832bca49c
Author: David Lutterkort <lutter at redhat.com>
Date: Thu Jun 11 16:46:27 2009 -0700
* provider/augeas: strip whitespace and ignore blank lines
Signed-off-by: James Turnbull <james at lovedthanlost.net>
commit a94d2de421fbc107f08e1eb78f90dd2dc8861ab0
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jun 12 12:21:16 2009 +1000
Fixed pi tests
commit 5f7455ea2f618ca7db4b45ee25666e0109f2abf6
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jun 10 18:10:40 2009 +1000
Fixed #2222 - Cleanup pi binary options and --help output
commit 134ae3e78f8562b2735737a36d994989a4614e4a
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jun 11 18:44:56 2009 -0500
Fixing #2329 - puppetqd tests now pass
Signed-off-by: Luke Kanies <luke at madstop.com>
commit de55e19074502f6a0286a4b90edcdf51985dd69f
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jun 11 18:36:33 2009 -0500
Cleaning up scope tests a bit
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e4ae870f6103aacbba48a06e366168aaaa67402b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jun 11 18:35:14 2009 -0500
Fixing #2336 - qualified variables only throw warnings
We were previously throwing exceptions.
This also ports all of the tests for variable lookup
over to rspec.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 607b01e82ea294068fdd554e59bc8e5fe3f9761a
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jun 6 12:58:26 2009 +0200
Fix #2246 - take2: make sure we run the rails tag query only when needed
Adding the tags to the rails collect query can reduce performance
because there are 2 more tables to join with.
So we make sure to include tags in the query only when it is
necessary.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 06b919ddb7d635abfe7855336e0e5af67675b44e
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jun 6 12:55:48 2009 +0200
Fix collector specs which were not working
The various collector specs covering the rails query code were not
in fact covering anything.
This patch fixes the specs to integration tests that actually verify
the rails query building code works fine.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 2945f8d315d265cfb527443cca27d191b7f3d8be
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jun 6 12:52:25 2009 +0200
Make sure overriding a tag also produces a tag
This is so that overriding the "tag" metaparameter ends-up in the
resource tags on the server.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit e142ca656cb5a44005edc9c9d0c767664768362e
Author: Bryan Kearney <bkearney at redhat.com>
Date: Wed Jun 10 07:31:05 2009 -0400
Removed a unit test which tested munging which is no longer done in the type
commit d8ee6cfaedf8846f65ec0fe32c5badcf569b20c7
Author: Bryan Kearney <bkearney at redhat.com>
Date: Wed Jun 10 07:02:38 2009 -0400
Clearn up a parsing error reported by the tests
commit 446557fbdf2051d59554f2d2cf6aa18c1f6eec83
Author: Marc Fournier <marc.fournier at camptocamp.com>
Date: Mon Jun 8 22:54:03 2009 +0200
vim: several improvements + cleanup
* added highlighting for different type of keywords:
* if/else
* undef
* puppet function names
* parameters passed to "ensure"
* unquoted digits
* fixed regexps to match resources containing "::", "-" and "_"
* handled escaped variables (variable which don't belong to puppet)
* removed unused definitions and added comments
commit 91526785f5c71d0750c48c0876c8148894bb9be6
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jun 10 15:43:38 2009 +1000
Fixed #2229 - Red Hat init script error
commit b5a8c4db028c69793c1c9172adca4d9930c8cd1d
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun May 31 15:38:14 2009 +0200
Fix #1907 (or sort) - 'require' puppet function
This function acts exactly as the 'include' function, but also
adds an ordering relation between the included class and the class
where the require function is.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 74730df475f21848027a4d2dda9ab849d3038c49
Author: Bryan Kearney <bkearney at redhat.com>
Date: Tue Jun 9 07:42:19 2009 -0400
#2332: Remove trailing slashes from path commands in the plugin
commit 1a894554990d145652e375359a1a5d26e7f22636
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jun 3 17:39:04 2009 -0500
Changing the preferred serialization format to json
This won't affect most people, but it's a good
default to have for those who can support it.
Signed-off-by: Luke Kanies <luke at madstop.com>
Minor changes to previous commit
commit 0de70b7035ebc7f00ede73098684ee5db4b2de14
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 2 23:08:52 2009 -0500
Switching Queueing to using JSON instead of YAML
This provides about a 75x speedup, so it's totally
worth it. The downside is that queueing requires json,
but only on the server side.
commit 7b33b6da4bdcd2263e2c63b443e9bea6fbe8d161
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 2 17:34:43 2009 -0500
Adding JSON support to Catalogs
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c0bd0aa1a5aaed94dfab25f390199a722d0d5c0d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 2 17:12:38 2009 -0500
Providing JSON support to the Resource class
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c16fd1bff64fd426d36e07648a7f8550563ae6e1
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jun 2 17:11:03 2009 -0500
Adding a JSON utility module for providing Ruby compat
This provides the class-method behaviour that Ruby's JSON
support expects but that we don't provide.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f059c518411f2f12bbe9108094b12f9bfc13e080
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 6 15:22:43 2009 -0700
Adding JSON support to Puppet::Relationship
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7f322b315a7890f1b3cee035d023f09814cc6075
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 6 14:32:25 2009 -0700
Adding a JSON format
Also making some log messages more informative.
commit 7666597edc335055275569f5626a897453402d5b
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 25 21:07:20 2009 +0100
Allowing formats to specify the individual method names to use
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d40068f7e70d1dc09334cac34d1bc48579b5a717
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 25 20:55:22 2009 +0100
Allowing formats to specify the methods they require
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 024ccf5b9a30977e9eee4ecf1d91eaf64f44a509
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 25 19:55:05 2009 +0100
Adding a "json" feature
We have to guarantee that the Rails code is loaded before the JSON code,
because Rails includes its own incompatible JSON support.
commit c8b382df2b6664333eaa339237cfbefd3eb12b96
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Jun 3 21:11:16 2009 +0200
Fix some tests who were missing some actions
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit f9516d49a02facb43e2856766b6439673450fdd1
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Jun 3 21:10:36 2009 +0200
Make sure virtual and rails query use tags when tag are searched
Up to now, when trying to match with tags:
File<<| tag == 'value' |>>
in fact we were querying parameters. Hopefully all the user tags
are stored in parameters so it was working.
But it wasn't possible to search on auto-tags (like class name).
This patch makes sure searching by tag is done on tags both on the
rails side and the resource side.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b5855ec1a5af2bec6c4ac35f8e6a885999b09bf9
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Jun 3 20:09:56 2009 +0200
Make sure resources are tagged with the user tag on the server
It appears that resources were not tagged with user tag on the
server, which prevents those tags to be persisted as tag in
the storeconfigs.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d69fffb63ca9efe3cca67167430b23d3b8d38fa4
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat May 30 20:15:08 2009 +0200
Fix #2246 - Array tagged resources can't be collected or exported
I don't know why we imposed the restriction that we shouldn't match
with parameter containing arrays in exported mode.
That doesn't seem right, as the produced rails query works fine with
arrays.
Note: the user tags are not stored in the rails database except under
the special resource parameter tag. This also doesn't seem right.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 6ce0d1e633780a71ec3597a90120d67d77a5d89f
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jun 6 09:42:45 2009 +1000
Partial fix for #2329
commit 4f2c066a97e59a89df64af4b25beac6f3f0553c2
Author: Ian Taylor <ian at lorf.org>
Date: Fri Jun 5 12:39:04 2009 -0400
Removed extra whitespace from end of lines
commit 97e6975d69f239e24993315a25a3117b1daa48c3
Author: Ian Taylor <ian at lorf.org>
Date: Fri Jun 5 12:38:52 2009 -0400
Changed indentation to be more consistent with style guide (4 spaces per level)
commit 41ce18cc8ea239d1633fc6cd9e9f599957a82e74
Author: Ian Taylor <ian at lorf.org>
Date: Fri Jun 5 12:38:35 2009 -0400
Changed tabs to spaces without interfering with indentation or alignment
commit f3b40923605420f774dac298fb1708de180c0a81
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat May 30 23:25:08 2009 +0200
Fix #2308 - Mongrel should use X-Forwarded-For
Mongrel puppet code uses REMOTE_ADDR to set the ip address which will
be use to authenticate the client access.
Since mongrel is always used in a proxy mode with Puppet, REMOTE_ADDR
is always the address of the proxy (usually 127.0.0.1), which defeats
the purpose.
With this changeset, the mongrel code now uses the X-Forwarded-For
HTTP header value if it is passed over the REMOTE_ADDR.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 7b0413e59ed0d4391a5ff54fb3cd08f0d005c26d
Author: Stéphan Gorget <gorget at ocre.cea.fr>
Date: Thu Jun 4 11:17:55 2009 +0200
Fixes Bug #2324 - Puppetd fails to start without rails
Signed-off-by: Stéphan Gorget <gorget at ocre.cea.fr>
commit 48d5e8c61cdd0e5e777bbac3adb71d06c109f0da
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jun 4 20:48:13 2009 +0200
Enhance versioncmp documentation
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit ef56ba5822d41672fb70e24650d60bfbeb73715d
Author: David Lutterkort <lutter at redhat.com>
Date: Mon Jun 1 13:57:39 2009 -0700
* provider/augeas: minor spec test cleanup
- rename some tests to make their purpose clearer
- add a test for nested predicates
- remove trailing whitespace
commit d322329ab671656b072cceb5aef8e3634e0fb2b1
Author: David Lutterkort <lutter at redhat.com>
Date: Mon Jun 1 13:47:19 2009 -0700
* provider/augeas: allow escaped whitespace and brackets in paths
commit 9735c5055cbb267e740838cd50b2205b87fffe57
Author: David Lutterkort <lutter at redhat.com>
Date: Mon Jun 1 13:04:04 2009 -0700
* provider/augeas: match comparison uses '==' and '!=' again
Change the syntax for match in an onlyif back to using '==' for equality
comparison instead of 'eq' (this was the behavior before 9a2642) and make
operator for inequality '!='.
commit dbfa61b5dcfa42f9fe12ad0d173f9195732d1bc3
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:47:23 2009 -0700
* provider/augeas (process_match): no match results in empty array
commit 386923ea95f161683fbdc2fe182193f3f3fe5485
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:46:11 2009 -0700
* provider/augeas: remove useless checks for nil
commit 171669ad3d3d1f0b7f72cd5cb2c36ad97e7d315c
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:44:14 2009 -0700
* provider/augeas: simplify evaluation in process_get/match
commit 51cc752a2e6d2e6ec5b826ae9f447ed516020086
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:36:14 2009 -0700
* provider/augeas (open_augeas): use Augeas flag names, not ints
commit 4951cdf4c66bfbad6495ffcab0b53d7601e73a44
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:23:11 2009 -0700
* provider/augeas: ensure Augeas connection is always closed
Turn code like
open_augeas
...
close_augeas
into
begin
open_augeas
...
ensure
close_augeas
end
Would have liked to pass the '...' as a block into a 'with_augeas' method,
but that makes the spec tests fail in ways I don't understand.
commit 0d5a24dd0ba4c7d1cc4827cb2d52411447202eae
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 23:01:51 2009 -0700
* provider/augeas: minor code cleanup
- remove '()' for empty method calls
- remove 'self.' for calling methods on self
- use the fact that nil is false
- remove redundant parens around some expressions
commit cea7bb555caf305add4864c15b5c88e72db10eb5
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 22:54:27 2009 -0700
* provider/augeas (parse_commands): use split to split string into lines
commit 95bd82610b2fb57d45db2535758cda5bbb297152
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 22:46:16 2009 -0700
* provider/augeas: remove trailing whitespace (no functional change)
commit 7c5125bb6dec630d2509905e3c202e0dfe59d959
Author: David Lutterkort <lutter at redhat.com>
Date: Sat May 30 22:43:55 2009 -0700
Brought in lutters parse_commands patch and integrated it into the type.
This includes reworking the get and match commands as well. This change
introduces a few small changes. These are:
1) There can be no ' or " characters around path elements.
2) The context is now only prepended to relative paths. So, if a
path is specified as /foo/bar the context will not be appended. It
will only be appended if it is foo/bar
3) The syntax for array matching in the onlyif is now eq or noteq.
It was == before.
4) The get and set commnands used to concatenate all items at the end
of a string so "set path to some value" would be interpreted as
"set" "path" "to some value". This is no longer supported. The caller
must put ' or " around the "to some value" for it to work"
Cherry-pick of 9a2642 from 0.24.x
Conflicts:
lib/puppet/provider/augeas/augeas.rb
commit 6ce81546ccfab2aefbec7fced5c38226bdd83297
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jun 3 07:37:28 2009 +1000
Removed --no-chain-reply-to in rake mail_patches task
commit 4ef7bbae5130605ddfbdab80e0c73d2088004b11
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 18:16:03 2009 -0500
Removing --no-thread from the mail_patches rake target
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 508934b11cdad82ed1022bffcdb88e66f4d5e4d8
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 18:12:54 2009 -0500
Fixing a bunch of warnings
This commit should have no functional effect.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fb0ed7a50bdd576bc7d0317aab32d36828e964d2
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 18:03:40 2009 -0500
Fixing tests broken by a recent fix to Cacher
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 650029e3730431dcc21863d92fd50c74665cea38
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 17:50:55 2009 -0500
Always providing a value for 'exported' on Rails resources
We often didn't set a value, unless it was true, which
meant that if it had previously been true but was now
false, we didn't fix it.
We also were not always saving modified resources, which
in some cases resulted in work not getting saved.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f1dba91bbde7919cb0a0fd412faacb1f7dd2c84d
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 11:11:28 2009 -0500
Fixing #2230 - exported resources work again
This somehow got lost in the conversion from
Parser resources to Puppet resources. We now
copy over the 'exported' value.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5522eb85a041d9ec77cf8c2b04f3351f48716246
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 21:17:47 2009 -0500
Disabling the catalog cache, so puppetqd is compatible with storeconfigs
Signed-off-by: Luke Kanies <luke at madstop.com>
commit abbb282211096780eea4efa461b2d7f958dc29ae
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 19 18:23:42 2009 -0500
Fixing the rails feature to be compatible with 2.1+
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 907b39b9708cbca10446336c424754e13d55e683
Author: Luke Kanies <luke at madstop.com>
Date: Thu May 28 10:10:40 2009 -0500
Using Message acknowledgement in queueing
This allows a more fine-grained load-balancing
of the queue, which makes it easy to spin up
multiple puppetqd instances and process the
queues faster.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 42247f0f5d08bce4d3fd2b020b770a12cc2f91db
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 1 21:31:49 2009 -0500
Fixing #2315 - ca --generate works again
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d7be0333ae1fc03bb5b639e7ab8f5431b56d1071
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed May 27 21:13:59 2009 +0200
Fix #2220 - Make sure stat is refreshed while managing Files
Since the introduction of the attribute cacher, Files couldn't refresh
their 'stat' attribute while applying the properties.
This could led to misunderstanding (like not setting mode) because
the stat didn't reflect the physical state of the entity, especially
when creating directories, where puppet was taking decision thinking
the directory didn't exist although it was just created.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit e4d59665b75c6a2cf0bc858bcf131d9c9c83dffc
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Jun 1 07:40:27 2009 +1000
Added puppet branding to format patch command
commit 00d5139639afe9b206f2f68df95cebfeb28f28b1
Author: Todd Zullinger <tmz at pobox.com>
Date: Fri May 29 19:33:42 2009 -0400
vim: Remove another mention of 'site' from syntax
Noticed-by: Marc Fournier <marc.fournier at camptocamp.com>
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit 9067abd5fcb3202fc7ac120d925e3e9f39d5933e
Author: Todd Zullinger <tmz at pobox.com>
Date: Fri May 29 19:48:34 2009 -0400
vim: Highlight parameters with 'plusignment' operator
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit 736b0e4ac86a1380927f267583eb5b86ae8104f8
Author: Todd Zullinger <tmz at pobox.com>
Date: Fri May 29 11:03:07 2009 -0400
vim: Highlight strings in single quotes
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit ce01c9569ca7a7b6c2eeb260d5fc8c215e11ac40
Author: Todd Zullinger <tmz at pobox.com>
Date: Fri May 29 11:01:17 2009 -0400
vim: Clean up syntax spacing
Signed-off-by: Todd Zullinger <tmz at pobox.com>
commit 3af2dbf32e4d74d5027b936ed652d488ecd7881f
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat May 30 10:39:10 2009 +1000
JRuby OpenSSL implementation is more strict than real ruby one and
requires certificate serial number to be strictly positive.
commit 62534a1622c710eb52b681d96aca8687c597190c
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:47:36 2009 -0500
Logging when a cached catalog is used.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ff5c44f2420864357d1c37635c311913c14d7a8b
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:45:42 2009 -0500
Changing Puppet::Cacher::Expirer#expired? method name
This method name clashed with Puppet::Indirector::Envelope#expired?,
and its name wasn't actually very appropriate.
The new method name is 'dependent_data_expired?'.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e3d4c8e3873f287412d29701ff774e61a247c6d4
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:35:21 2009 -0500
Fixing #2240 - external node failures now log output
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bc1445b5cefb5742ca906632cc99a82a769ead97
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:55:28 2009 -0500
Fixing #2237 - client_yaml dir is always created by puppetd
This is just a simple call to Puppet.use in the puppetd
setup method.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e0c19f99f44d94715984d5533daed25e35ac6f3b
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 9 13:40:59 2009 -0700
Fixing #2228 - --logdest works again in puppetd and puppetmasterd
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ab34cf610ee529fcbbf777aae7b382090af1a8b2
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 9 13:27:46 2009 -0700
Fixing puppetmasterd tests when missing rack
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9d5d0a0d17d1043754c759b27b58697749b1b87e
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:18:44 2009 -0500
Fixing the Agent so puppetrun actually works server-side
We weren't correctly propagating options through
to the Configurer instance.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b0ef08bfdfe3a1cdb81aa7622de0807786b24e3f
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 10:11:25 2009 -0500
Fixing #2248 - --no-client correctly leaves off client
All of the settings were there, we just weren't doing anything
about them.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b83b159b69e1952c20f23629fc1255069ad5abb0
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 27 09:57:57 2009 -0500
Fixing #2243 - puppetrun works again
The problem was that some defaults were nil but had
to be 'false', because xmlrpc can't serialize 'nil'
as an rpc argument.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3d2189f3b6173171b37eaf814fdda2756c5a348a
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu May 28 00:47:50 2009 +1000
Fixed #2304 - Added naggen script to directly generate nagios configuration files from a StoreConfigs Rails database
commit 700ad5b8ed3b12c633b262e43f8d684a9fab2833
Author: Todd Zullinger <tmz at pobox.com>
Date: Mon May 25 10:57:56 2009 -0400
Sync conf/redhat/puppet.spec with Fedora/EPEL
The install.rb script is now used for installation. The spec file is
also updated for the 0.25.0beta1 release.
commit 3ec3f915306dac13370f64795c399df97fc2d992
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed May 27 22:49:16 2009 +1000
Fixed #2280 - Detailed exit codes fix
commit f98d49f2d20ed52cd33504c5d0ef97d0edf9107f
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 24 15:26:44 2009 -0500
Fixing #2253 - pluginsync failures propagate correctly
This keeps the destination directory from getting
purged if the remote source is invalid.
This mostly just removes an optimization that worked
fine when we queried the server for every directory,
but doesn't work now that we do one big query.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d860a2fb71858706ff318cfcdc0ff387840eef80
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 24 15:15:33 2009 -0500
Fixing a transaction test that had some broken plumbing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a72875799ecfa78ed91ff31047971441f0f169c3
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 24 14:20:49 2009 -0500
Refactoring resource generation slightly
I found some cases where duplicate resources
weren't correctly skipped, but I couldn't get
the test to really demonstrate them.
The code at least is demonstrated to work,
anyway.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6e824d8ca58c5d6f27a4cfcf44fad579a24133d4
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 24 14:13:02 2009 -0500
Adding a Spec lib directory and moving tmpfile to it
We had a common pattern for creating a temporary
file during integration tests, and this just
makes that common pattern explicit by
moving it to a module in the newly-created
lib directory in the spec directory.
We definitely don't want to go overboard in
using libraries in our tests, but sometimes
it gets a bit excessive to completely avoid them.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1d69dbfd0351d3f4d23c15904061d98f8bf42ca6
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 22 15:07:54 2009 -0500
Extracting a method from eval_resource in Transaction
Just cleaning up the code a bit before a modification.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7650fb299768c23241784671e3abeb272ee87fab
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 22 14:45:35 2009 -0500
Not trying to load files that get removed in pluginsyncing
Previously any changed file got loaded; now we only try to
load files that are still present.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3995e7026dd40778cff1025a8e7e28eec833545f
Author: Francois Deppierraz <francois at ctrlaltdel.ch>
Date: Mon May 25 09:44:59 2009 +0200
Fix #2300 - Update ssh_authorized_key documentation
commit cb4a4d3344169a75224caa6488e3aa59f85218de
Author: James Turnbull <james at ubuntu904.lovedthanlost.net>
Date: Tue May 26 13:41:29 2009 +1000
Changed version to allow Rake to work. Minor
edit to Rakefile
commit 99f666f31c79c6c163881f3f664e59707a176753
Author: Peter Meier <peter.meier at immerda.ch>
Date: Thu May 21 12:42:28 2009 +0200
enable maillist on centos, redhat, fedora
Fedora and RedHat (so CentOS as well) put the mailman data and binaries
in different locations than other systems (looks like the provider
have been mainly for debian so far). For the former os we set
explicit paths for the different used binaries, so this provider works
now as well on those.
commit e13befa963323dfcd4b6d8e14b0f6980946b7e1b
Author: Luke Kanies <luke at madstop.com>
Date: Thu May 21 10:00:45 2009 -0500
Fixing #2288 - fixing the tests broken by my attr_ttl code
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a406d585ce861757d6c14e0696a3847b46e4319d
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Mon May 11 21:55:51 2009 +0000
Fix for #2234: test fails with old Rack version
commit c189b46e3f179ca60dfeb8e65080d19fe653e926
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 18 00:28:50 2009 -0500
Fixing #2273 - file purging works more intuitively
It now correctly purges files whether we're recursing
locally or remotely.
*Please* test various scenarios you can think of with
this. I've tested:
* Local recursion with no remote source
* Remote recursion with a source
* Recursion with an extra locally managed file
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 138f19fc6e7bb1d8ebf305decaa045c53787297c
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 16 00:08:35 2009 -0500
Caching whether named autoloaded files are missing
This is the big win, because it causes us to just
skip the whole loading infrastructure, including
skipping looking through the modulepath.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 415553e9485d7ba3ed867033ac9c3315107d3c92
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 17:20:55 2009 -0500
Adding caching of file metadata to the autoloader
The cache isn't actually used yet - this just adds
all of the plumbing.
It was found that stat'ing files that didn't exist
could take up to 85% of a run, so this is progress
toward getting rid of those stats.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d489a2b9e2806beefd41627adf7e20d23b0924d6
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 17:10:16 2009 -0500
Adding modulepath caching to the Autoloader
There's more caching to add, but this simplifies
the interface to the list of paths and then caches
that list so we aren't constantly searching the
filesystem.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5f1c228767432591a7e4b77666e9b1c7d70a095c
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 16:54:06 2009 -0500
Adding caching to the Environment class
Caching the module path (because we check which
directories exist, and this method can get called
often), and the complete list of modules.
The cache ttl uses the filetimeout, which defaults to
15 seconds.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 047ab782aed5555a6812131acdba3925b1274a55
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 15:52:52 2009 -0500
Adding TTL support to attribute caching
Previously you had to have an Expirer, but now
you can declare a TTL for a cached attribute
and it will be expired automatically when the
cached value is older than the ttl.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6a413d21a71da2b330f9b147532f3256fc29be3c
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed May 20 18:27:02 2009 +1000
Fixed #2666 - Broken docstring formatting
commit 469604f33645e136725e34b57ce270b4397d3536
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 19 22:24:28 2009 -0500
Deprecating factsync - pluginsync should be used instead
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d39c4850904cc9b27110d753ddd94849bdec7644
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed May 20 15:42:01 2009 +1000
Added spec and unit tests to the Rakefile files list and fixed CI rake tasks
commit e1a7f845cc543bd4c7fb852974d563e50db128dd
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed May 20 02:22:30 2009 +1000
Added install.rb to Rakefile package task
commit e180a918a98c9b16b0b8fc1486f45c4c5de91dea
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon May 18 17:23:07 2009 +1000
Fixed #2271 - Fix to puppetd documentation
commit 4bf2980577c2e1233b7102540237aae01c70bde5
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 12 22:12:45 2009 -0500
Protecting Stomp client against internal failures
Apparently the stomp client is really unhelpful with
failures; this attempts to provide at least a bit
more information.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f4cb8f36dfb2ae05d64ef609d03795537b0720fa
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 23:22:44 2009 -0500
Adding some usability bits to puppetqd
There's better logging, and it's a bit more
exception-friendly.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a18298a0a9a0d465348164c21fc3dd433aeaa7fc
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 23:20:34 2009 -0500
Refactoring the stomp client and tests a bit
The main goal of this refactor is to tell the client to
be resilient to failures (configured at initialization time),
and to send all messages as persistent messages (configured
for each message).
In the process, the client now parses the queue source URI
and handles each argument separately. The tests are more
thorough, also.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2771918b9eef9ed26e59688c17c64e86de1b9983
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 23:16:22 2009 -0500
Relying on threads rather than sleeping for puppetqd
We previously manually slept, but this uses
the queue client to handle keeping the process running,
by just joining all running threads.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 07ff4be92a1d46fe0f6ec3de3c33b5a3b99be755
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 23:08:40 2009 -0500
Fixing #2250 - Missing templates throw a helpful error
This changes the behaviour of template searching a bit -
we previously usually returned a file name, whether the template
existed or not. Now we only return a path if it
exists.
Refactoring a few of the the tests for TemplateWrapper, also.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7ce42daf5a0c2e3946732f7acb1c0ce680dc432e
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 17 23:38:39 2009 -0500
Fixing #2273 - CA location is set correctly in puppetca
It's set to 'only' instead of 'local'.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e1779c7711458f718babca5db27427eeb14ae724
Author: Christian Hofstaedtler <ch+git at zeha.at>
Date: Fri May 15 14:30:14 2009 +0200
RackXMLRPC: buffer request contents in memory, as a real string.
Fixes #2268 "Rack::RewindableInput is not a valid input stream."
commit fb957ccb6636ce86bd98c141d5818c54bc0d4659
Author: Luke Kanies <luke at madstop.com>
Date: Thu May 14 11:36:20 2009 -0500
Modules now can find their own paths
Previously, when you created a module you had to specify
the path. Now Module instances can use the module path
to look up their paths, and there are methods for determining
whether the module is present (if the path is present).
Also cleaned up the methods for figuring out what's in
the module (plugins, etc.).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c6084093e67b1e415e49c192b3ac6f6b9aebc4ba
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 17 12:47:41 2009 -0500
Moving file-searching code out of Puppet::Module
The Module class had a bunch of code for finding
manifests and templates even when not in a module,
and it complicated the class unnecessarily. This
moves that code to a new, hackish-but-sufficient
module for just that purpose.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 83ba0e5efe4514201c1a627ceffdaef992431734
Author: Luke Kanies <luke at madstop.com>
Date: Thu May 14 12:11:14 2009 -0500
Fixing #2234 - fixing all of the tests broken by my bindaddress fix
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4f3a67f21568394dd89a969bd373cbbd59784f7e
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 6 12:00:23 2009 -0700
Fixing #2221 - pluginsignore should work again
We weren't splitting on whitespace, which is necessary
since the settings don't support arrays but files
expect them.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2d580c257e6d8aa0821fd443e8b817027407212c
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri May 1 13:26:00 2009 +0200
Fix snippets tests failing because of activated storeconfigs
All the snippets tests were failing because some parser and scope
tests activated storeconfigs without reseting the state.
Activating storeconfigs is not undoable at the moment by just
setting storeconfig=false as some terminus are changed.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 8c718c9f678809ad7bc6a0cc5b5356847a625ca5
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri May 1 13:12:40 2009 +0200
Fix failing test: file.close! and file.path ordering fix
On ruby 1.8.7 file.close! nils the internal file path.
So the following pattern:
file = temp
file.close!
file = file.path
doesn't work.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 17f2c7d1255d79a79060ca93f9d73642a804ed10
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Apr 30 22:30:35 2009 +0200
Confine stomp tests to Stomp enabled systems
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 6a80b764ef2ac3bad5d7ecdf29aafd9e17887fe1
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Apr 29 23:13:19 2009 +0200
Fix some master failing tests
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 172422fc0422e2646c4cc3afb7955876651cbf3e
Author: Francois Deppierraz <francois.deppierraz at camptocamp.com>
Date: Fri May 8 19:52:04 2009 +0200
Fix bug #2124 - ssh_authorized_key always changes target if target is not defined
commit f945b66aee03c0c06248f3809773f444a25ff00f
Author: Luke Kanies <luke at madstop.com>
Date: Thu May 14 11:46:04 2009 -0500
Fixing #2265 - rack is loaded with features rather than manually
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5aef9151e6514ea6c7bd9aefcd29018e37906281
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat May 9 09:25:55 2009 +1000
Added .git to pluginsignore default list of ignores
commit 6db5e8d9d7ed4cbd47652a33123118fd8640c8f2
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu May 7 18:16:40 2009 +1000
Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library
commit 5cc491060f35a29faff20911f54c57e9e065b6a3
Author: Francois Deppierraz <francois at ctrlaltdel.ch>
Date: Thu Apr 30 02:33:50 2009 +0200
Fix #1409 once again, including test
"user doesn't exit" error appeared once again after the changes which were
applied in order to fix #2004.
Validation must only check attributes presence, not their value.
commit a6af5bf8aa45af05186088b02e68acff41f404a6
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun May 3 19:25:08 2009 +1000
Added split function
commit 2dd55fcc542b935146f4eb385356fee0d7d3ea2a
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 2 17:33:59 2009 +0200
Fixing #2200 - puppetqd expects Daemon to be a class
I *swear* I wrote tests for the daemon, but I
can't find them in any of my branches so I rewrote
them.
In the course of writing them, I also fixed the
usage of Daemon.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c016062706d541a6255303db0624c8d96d31cfd6
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 2 20:08:43 2009 +0200
Removing unneeded test stubs
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1a2e1bcdd31e00a925e1e55693e9dbe241289950
Author: Luke Kanies <luke at madstop.com>
Date: Sat May 2 20:05:19 2009 +0200
Fixing #2195 - the Server class handles bindaddress
The Server class has all of the logic now,
instead of doing weird things in the defaults.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit df3a8f67193c8c6089a84ea6023c84c52b3d3205
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun May 3 19:05:03 2009 +1000
Minor fixes to function RST documentation
commit 305fa80785f89e8015810531e09854bd23d1c85e
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Fri May 1 20:31:02 2009 +0000
Remove the old 0.24.x rack support, which is now useless cruft
commit d85d73c570a60891607d2ce5b42dba4617f4ca6c
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Tue Apr 28 13:30:48 2009 +0000
puppetmasterd can now run as a standard Rack application (config.ru-style)
commit d6be4e1206e9285dee9fc4d8cde9608c029d4001
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Tue Apr 28 12:29:20 2009 +0000
Add XMLRPC compatibility for Rack
commit 6e01e7ab403d090f29f13c938ca5b19930c4b408
Author: Christian Hofstaedtler <hofstaedtler at inqnet.at>
Date: Tue Apr 28 12:23:58 2009 +0000
Puppet as a Rack application
This lays the ground: a wrapper for the REST handler, and an application
confirming to the Rack standard. Also includes a base class for Rack
handlers, as RackREST will not stay the only one, and there needs to be
a central place where client authentication data can be checked.
commit cc09c1af21e218917cc02c0ad9d8c44300803f49
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Mar 13 23:33:17 2009 +0100
Use FileCollection to store the pathname part of files
Using the FileCollection to store the path parts allows to represent
a common path prefix by an integer.
This way the memory used to manage deep hierarchies is reduced.
The reduction factor depends on the number of managed files per
directories: the more files in a directory, the more they will share
the same common prefix, and the better we'll gain.
Early tests on a 5 level deep hierarchy containing 100 files
per level show about a 50% less memory consumption.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d51d87e1f04b643f4efb5c6453a2c1fc9a1ca8e5
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Mar 13 23:30:03 2009 +0100
Add an unmunge capability to type parameters and properties
Unmunge is the reverse of munge.
While munge allows the type to return a different parameter value
or properties should than the one it was created with, unmunge
does the reverse.
It can be used for instance to store a value in a different
representation but still be able to return genuine value to the
outside world.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit a1c0ae0fe3c4bef6f21240c4d0a8da985cc7c8af
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri May 1 16:59:51 2009 +0200
Fix #2218 - Ruby YAML bug prevents reloading catalog in puppetd
Because of ruby bug:
http://rubyforge.org/tracker/?group_id=426&atid=1698&func=detail&aid=8886
and
http://redmine.ruby-lang.org/issues/show/1331
YAML dump of hashes using ruby objects as keys is incorrect leading
to an error when deserializing the YAML in puppetd.
The error is easy to correct by a post-process fix-up of
the generated YAML, which transforms:
&id004 !ruby/object:Puppet::Relationship ?
to the correct:
? &id004 !ruby/object:Puppet::Relationship
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit bf054e1b2c0117135de5f54421c112523e83a88c
Author: Stéphan Gorget <gorget at ocre.cea.fr>
Date: Wed Apr 29 11:23:58 2009 +0200
Fixes #2209 - Spec is failing due to a missing require
commit 1c4620544520d2b5e2967be8dd525bd584ad3886
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Apr 29 19:32:38 2009 +0200
Fix #2207 - type was doing its own tag management leading to subtile bugs
This patch moves Type to use Puppet::Util::Tagging as the other
part of Puppet. This brings uniformity and consistency in the
way the tags are used and/or compared to each other.
Type was storing tags in Symbol format, which produced #2207.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 929130bafc5f88512b256cfdb772299b3a54cfdb
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Apr 28 22:40:17 2009 +1000
Moved puppetqd binary
commit 36d04187fae6b091336ce52d3e428176b39207ae
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Apr 27 23:33:28 2009 +1000
Fixed #2188 - Added set require to simple_graph.rb
commit 51af2398ea96cd5abfb932ec12fceb5325b6605f
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Apr 26 20:45:25 2009 +1000
Fixed puppetqd require and tweaked stomp library error message
commit dc0a9978df57b0ca730f9d90a132772474d34a5a
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Apr 26 20:16:28 2009 +1000
Fixes #2196 - Add sharedscripts directive to logrotate
commit 4d3b54e8c96df5da0d8618c1965f7fc7fa5cee8e
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Apr 26 01:59:21 2009 +1000
Added puppetqd binary to Rakefile
commit 1fee506187af09bca997f77f414fdc306ffe8f3e
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Apr 25 14:39:49 2009 +1000
Updated version to 0.25.0beta1
commit 0fbff616af30f74d07515ffb84c89f6a55af1f57
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Apr 25 14:39:14 2009 +1000
Updates to CI tasks
commit aa6dcef408284b39dc0001683c61c149a0578156
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 18:18:41 2009 -0500
Fixing #2183 - checksum buffer size is now 4096b
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c0b119aac7fdc1306270bbe6d1279a4b8e61a99c
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 18:08:27 2009 -0500
Fixing #2187 - Puppet::Resource is expected by Rails support
We previously used and expected Puppet::Parser::Resource
instances, but 0.25 converts them all to Puppet::Resource
instances before they're passed out of the compiler,
so the Rails integration had to be changed to expect that.
There's still some muddling, because the rails resources
only generate parser resources, but that works for now
because that's what we expect when collecting resources.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5ec4f66ba1e5dc8788636862d90d6521e0217e86
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 18:08:03 2009 -0500
Adding an 'Exported' attribute to Puppet::Resource
This is required for Rails support.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit adff2c5a2703cabb7ab1438ac5b54571c2b2dfb0
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 18:05:19 2009 -0500
Removing a non-functional and horrible test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 606a6891a5662a37f481cbada7cfd59c81cf9469
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 18:03:34 2009 -0500
Making sure the cert name is searched first
The cert name should be searched first in default
circumstances, even if it disagrees with the hostname.
Brice's change to the way catalogs are searched for didn't
quite work when the hostname and certname didn't agree *and*
the certname was fully qualified.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f489c30411e8fdee4e43a4f580d135acdaeae946
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 17:46:20 2009 -0500
Removing an "inspect" method that often failed in testing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 93c3892e729de48da78fed309c7107ce3e191254
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 17:42:27 2009 -0500
Removing deprecated concurrency setting usage in rails
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6f8900d2931acfb96b810904572aecc675d28168
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 16:24:18 2009 -0500
Always making sure graph edges appear first
If we don't do this, there's a chance we'll get hit
by the ruby yaml bug again.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3f7cd18604e972e78bc9182e09cc4defa46b7d8d
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 16:14:00 2009 -0500
Reverting part of the switch to sets in SimpleGraph
Unfortunately, again because of a Ruby bug
(http://rubyforge.org/tracker/?group_id=426&atid=1698&func=detail&aid=8886)
Ruby can't print yaml that it can read, if custom
classes are used as keys in hashes, which Sets use internally.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bf46db7452ae72d3a40ecc5cf14ae62692c47e84
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 24 19:48:22 2009 +0000
Fixing rails feature test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5f6b5c0efe5210583a1040f902af2ff0709f3ca9
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 23 18:56:57 2009 -0500
Failing to enable storeconfigs if ActiveRecord isn't available
This is the last step to fixing #2189.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8ed7ae3a23dd84dfc7ef835c2bb36f7ee4cfe9e5
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 23 18:56:30 2009 -0500
Fixing the Rails feature test to require 2.3.x
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a0c1edec69c7eea70fe1ca9f4e0e1dc6fc3d688b
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 19:45:59 2009 -0500
Modifying the Settings#handlearg prototype
I'd made the argument no longer optional
because I thought the method was rarely used,
but it's used in puppetd a good bit.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 284cbeb6a6b4b8d633890139b8e5c5319f67bde3
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Apr 24 19:02:08 2009 +1000
Fixes #2172 - service provider for gentoo fails with ambiguous suffixes
commit 68ba1f135a587d2dbfbf7a371540a83908c9d590
Author: Bryan Allen <bda at icgroup.com>
Date: Thu Apr 9 17:20:53 2009 -0400
SMF import support working and documentation update
commit f1f0a57e4cafc5a9a4378f367022f7cc591033d7
Author: Bryan Allen <bda at icgroup.com>
Date: Thu Apr 9 05:45:44 2009 -0400
Fixes #2145 and #2146
Adds manifest param for service type, defines a command or manifest to set up a service
Add service setup (import) support
commit ec478da93a03d0a9c5cd7b782d86deea6d3b4a8b
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Apr 22 19:30:09 2009 +0200
Fix configurer to retrieve catalog with client certname
Rationale:
Before this change, the catalog was retrived with this uri:
/catalog/hostname
On the server side, the corresponding node was found by using the
request node, then finding if this node also match hostname
(which it does of course).
But it is not possible to have an ACL matching the hostname part
of the uri, because it:
* it would be compared to the node name (certname), which obviously
is not the same
* it is not possible to create a dynamic allow/deny rule on a non-fqdn
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit e623f8a32a7363d98843fdb361c717b6198d32de
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Apr 19 17:44:55 2009 +0200
Unify auth/unauthenticated request authorization system
Before this change, unauthenticated REST requests where inconditionnaly
allowed, as long as they were to the certificate terminus.
This could be a security hole, so now the REST requests, authenticated
or unauthenticated are all submitted to the REST authorization
layer.
The default authorizations now contains directives to allow unauthenticated
requests to the various certificate terminus to allow new hosts.
The conf/auth.conf file has been modified to match such defaults.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 037a4acfb6c9b498424e278caac88687e3f4cfa1
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Apr 21 23:48:44 2009 +0200
Allow REST auth system to restrict an ACL to authenticated or unauthenticated request
Introduces a new auth.conf directive (auth or authenticated) which
takes an argument (on,yes/off,no/all,any).
This can be used to restrict an ACL to only some state of
authentication of a REST request, or any.
If no auth directive is given, the ACL will only trigger for
authenticated requests.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3ad79609183c5a4448595f85411179ac448d2ef9
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Apr 19 16:37:46 2009 +0200
Fill REST request node with reverse lookup of IP address
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit c0c824548e03e603f5a51c61262ae6a58e7549fb
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 30 23:10:19 2009 +0200
Refactor rest authorization to raise exceptions deeper
The idea is to raise an AuthorizationException at the same place
we check the authorization instead of in an upper level to be
able to spot where the authorization took place in the exception
backtrace.
Moreover, this changes also makes Rights::allowed? to return
the matching acl so that the upper layer can have a chance to
report which ACL resulted in the match.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit aac996ed17e0ec72c5098b1225eb159aae4901fc
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 30 20:24:53 2009 +0200
Add environment support in the REST authorization layer
With the help of the new auth.conf directive 'environment',
any ACL can now be restricted to a specific environment.
Omission of the directive means that the ACL will apply
to all the defined environment.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 72e28aeccc36092e7edf9dc25e44acdb08fa5e79
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 23 23:36:48 2009 +0100
Fix some indirector failing tests
The authorization system should stubbed to let all the rest tests
to succeed :-)
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit dc1cd6fb6b143b6525953e619a716f04e678727c
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Apr 21 23:53:48 2009 +0200
Fix #1875 - Add a REST authorization system
This patch introduces a new configuration file (and configuration
setting to set it).
Each REST request is checked against this configuration file, and is
either allowed or denied.
The configuration file has the following format:
path /uripath
method <methods>
allow <ip> or <name>
deny <ip> or <name>
or
path ~ <regex>
method <methods>
allow <ip> or <name>
deny <ip> or <name>
where regex is a ruby regex.
This last syntax allows deny/allow interpolation from
the regex captures:
path ~ /files[^/]+/files/([^/]+)/([^/])/
method find
allow $2.$1
If you arrange your files/ directory to have files in
'domain.com/host/', then only the referenced host will
be able to access their files, other hosts will be denied.
For instance:
files/reductivelabs.com/dns/...
files/reductivelabs.com/www/...
then only files in dns can be accessible by dns.reductivelabs.com
and so on...
If the auth.conf file doesn't exist puppet uses sane defaults that allows
clients to check-in and ask for their configurations...
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 85233768f080b4cbc4e20eb0c354b6d859a2fb23
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Mar 31 20:29:37 2009 +0200
Enhance authconfig format to support uri paths and regex
This patch introduces a new set of directive to the authconfig
parser/file format:
path /uripath or patch ~ <regex>
This directive declares a new kind of ACL based on the uri path.
method save, find
This directive which is to be used under path directive restricts a
path ACL to only some REST verbs.
The ACL path system matches on path prefix possible, or
on regex matches (first match wins).
If no path are matching, then the authorization is not allowed.
The same if no ACL matches for the given REST verb.
The old namespace right matching still works as usual.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 22b82abcd27834e43426f2758fba5728c146be61
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Apr 11 18:58:56 2009 +0200
Add dynamic authorization to authstore
The idea is to have allow/deny authorization directives
that are dynamic: their evaluation is deferred until
we perform the authorization checking in allowed?.
This is done to allow replacing backreferences in allow/deny
directives by parameters of the match that selected this right.
For instance, it is possible to:
allow $1.$2
And using Right::interpolate() with the result of a regex match
using 2 captures, will evaluate $1.$2 to those captures.
For instance, if we captured [host, reductivelabs.com], then the
allow directive is replaced by:
allow host.reductivelabs.com
It is then safe to call allowed?, after which we can reset the
interpolation.
This interpolation is thread-safe.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
authconfig regex support
commit 15abe1709aa52bb45fe228139f4c0352dc8905df
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Apr 21 23:53:17 2009 +0200
Add RSpec unit tests for network rights
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 86c79777bd190bab425be036ec01378793d059b5
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Apr 21 23:52:46 2009 +0200
Add RSpec unit tests for authconfig
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit f04a938084e0a68884af95378a3a9f81227c578f
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 19:18:31 2009 -0500
Adding support for specifying a preferred serialization format
This isn't that great, but at least it provides
basic tuning of the format.
Also removing the catalog_format default, since it's
no longer used.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6a51f6fb2184f25bf45a1328e0ba889aa066ffd3
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 19:03:31 2009 -0500
Fixing the FormatHandler test to use symbols for format names
Formats guarantee that symbols are used, so it makes sense
for the tests to do so.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b249f87a8c9a7e358e8d82d658247cd4be01a3d7
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 18:47:23 2009 -0500
Fixing #2149 - Facts are passed as part of the catalog request
This removes the requirement of shared fact caching
on the servers, since the server responding to the catalog
request will receive the facts as part of the request.
The facts are serialized as a parameter to the request,
rather than each being set as a separate request parameter.
This hard-codes yaml as the serialization format for the
facts, because I couldn't get marshal to work and it's just not
as big a deal for such a small amount of data.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1cde0ae606b0ea48d4dd8f7a0c0a4f84f7ed8af6
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 18:40:53 2009 -0500
Adding better logging when cached indirection resources are used
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 828b1ea605786183c69a8be3bca2272b50761790
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 17:49:05 2009 -0500
Fixing #2182 - SimpleGraph#walk is now iterative
It was previously recursive, and was causing
significant performance problems for large, wide
graphs.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9f32172e7d93f926b2ab291e68bdd0cc955ff3d2
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 17:39:35 2009 -0500
Fixing #2181 - Using Sets instead of Arrays in SimpleGraph
This can cause a huge speedup for large numbers of edges.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7a98459706318c2fbbfd11749333a61767ec9aae
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 01:20:36 2009 -0500
Removing code that was backported and is now not needed
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d06bd3ede2a5ba0017e90e2937092a986d5b356c
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 01:13:49 2009 -0500
Finishing class renames
I missed some of the Catalog mentions, and its
constant changed.
I've also added tests so this will get caught
next time.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b694b3c0696cc9bd0f109bf0a7c790f592bc6180
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 01:00:52 2009 -0500
Fixing tests that apparently only worked sometimes
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 93246c0c70796a606fc8c05b51e1feb09c94e377
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 00:56:32 2009 -0500
Removing the old rails tests.
They don't work with the modified code, and we
rely almost entirely on manual integration testing
for this stuff anyway.
We definitely need to add tests where we can, but
these tests are totally useless.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5cb0f76f3ccb0b179de5f2735749ff91ae7346cc
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 17:53:49 2009 -0500
Fixing some rails tests that sometimes failed
At least, I think they're fixed; it's hard to test.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bdbf9db5f0c0d30e554f274591b24692b866ca29
Author: steve mcintosh <stevemac at endpoint.com>
Date: Thu Apr 9 16:10:23 2009 -0400
Added class_name tags to has_many relationships
commit 2e62507a81dc5c497be302b77fe368c6387a2f40
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 12:59:47 2009 -0500
Adding time debugging for catalog storage to active_record
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a705809b1e5a27062d683c138135046cc7e70ae1
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 12:59:10 2009 -0500
Adding defaults necessary for queueing
These are all of the defaults needed to configure queueing.
commit 8a67a5c4e059398193b94a06df3f1ac6cc6f095b
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 12:58:35 2009 -0500
Adding daemonization to puppetqd
This will need to be modified on the merge into 0.25,
because the daemon module becomes a class, but that should
be easy enough.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fcd1390dd95054fdb529481c4603860b9d53be68
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 12:14:08 2009 -0500
Adding Queueing README
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9b90f34cdc2c7c462e2e20028b115209e9748969
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 14 11:18:02 2009 -0500
Using a setting for configuring queueing
Removing class methods and such, and switching to
relying solely on a setting for the queue configuration.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 444ae9f8341348b0b8163788ada35892bc98f562
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 13 16:51:56 2009 -0500
Adding puppetqd executable.
This uses the backported Application class, with a couple
of backported monkey-patches so the class works as expected
but in 0.24.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 22ae661263b9b42c3ad4d4d6dee3d3b1d1d2e25b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 10 15:23:31 2009 -0500
Adding "rubygems" and "stomp" features
Signed-off-by: Luke Kanies <luke at madstop.com>
commit efe68165b382d6860e83b0bb1d1108f36fa3d2fd
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 7 18:41:51 2009 -0500
Removing unnecessary parser variables when yaml-dumping
Also working around a YAML bug in Ruby.
And fixing tests that were broken in a previous commit
in this rebase but not caught earlier.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a3b1e8ce9c8ad97ed3bcf65c0554ae34690716fa
Author: Ethan Rowe <ethan at endpoint.com>
Date: Mon Apr 13 07:46:53 2009 -0400
Add queue indirection as an option for catalog storage.
This eventually will allow catalog storage ("storeconfigs") to be taken out of the critical request-handling path of puppetmasterd, such that:
* Puppet::Node::Catalog can be serialized to a message queue via the indirector's "save" method
* a separate process can use Puppet::Node::Catalog::Queue.subscribe to pick up these catalog objects as they come in and can save them to the database through the :active_record terminus
commit bccfcc9d3a316e79f7e07e7f0d837b82940c071a
Author: Ethan Rowe <ethan at endpoint.com>
Date: Mon Apr 13 07:41:12 2009 -0400
Introduce abstract queue terminus within the indirection system.
The queue abstract terminus allows the standard indirector behaviors to interact with a message queue broker, such that the indirector's "save" method writes the relevant model object out to a queue on the message broker. While the indirector's "find" method does not map to a message queue, the queue terminus class offers a "subscribe" method that allows for easy implementation of an event loop, receiving indirected objects saved to a queue as they come in.
commit 7947f100a9d9d60d1038e220aa41d44cf59d5af0
Author: Ethan Rowe <ethan at endpoint.com>
Date: Mon Apr 13 07:33:11 2009 -0400
Introduce queue client "plugin" namespace and interface, with a Stomp client implementation.
Puppet::Util::Queue provides queue client mix-in behaviors that enable easy queue client management for consumer classes. Some relevant behaviors include:
* standard Puppet instance loader behavior for loading queue client modules on-demand based on the client module specified by symbolic name
* singleton registry of known queue client types (based on symbol-to-class mappings from the instance loading behavior)
* simple interface for working with an actual queue client instance
Puppet::Util::Queue::Stomp wraps the Stomp::Client class to provide an initial queue client option supporting the Stomp messaging protocol. This defines the interface for all Puppet queue client plugins going forward.
commit 80dc83715190335ec0aac142e383d60ca28ea3b3
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 11 21:06:14 2009 -0500
renaming a method
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f7ccaaaf5ee9e4ecc4f99a7c70cac5489ce2b3bf
Author: Ethan Rowe <ethan at endpoint.com>
Date: Fri Apr 10 16:01:25 2009 -0400
Adjusted parameter name and puppet tag classes to use new cache accumulator behavior for storeconfigs.
Removed per-class implementatiosn of accumulate_by_name from affected classes.
commit 75f1923049d5e1edfd3b9e9790a96b487cdef305
Author: Ethan Rowe <ethan at endpoint.com>
Date: Mon Apr 6 11:34:12 2009 -0400
Initial implementation of a "cache accumulator" behavior.
Mix Puppet::Util::CacheAccumulator into an ActiveRecord-like class, and then for any
attribute in that class on which you are likely to call find_or_create_by_*, specify:
accumulates :foo
and instead of :find_or_create_by_foo use :accumulate_by_foo.
The class will cache known results keyed by values of :foo.
Do an initial bulk-lookup: class.accumulate_by_foo('foo1', 'foo2', 'foo3', 'foo4')
commit bab45c4a3006867c500b30df9b91b7b46c17dff9
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 9 21:18:28 2009 -0500
Saving rails resources as I create them, which saves about 10%
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7a91e1f5c03ed02eed4c45fddd740b899650bf36
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 9 17:43:17 2009 -0500
Changing rails value serialization to deal with booleans
The database was automatically converting booleans
to strings, and value comparison was not working correctly
as a result.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c30ede56f576aa6032221ed45510f50b0303ef7a
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 9 17:31:39 2009 -0500
Adding equality to ResourceReference
This is used by the Parser subclass when testing
equality with db-backed references.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 589f40f8e8769d3bd8de8692222eac8a2f6f30cb
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 18:47:26 2009 -0500
Adding some more fine-grained benchmarks to Rails support
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 042689e06bcee2882a2937b2caeab4529ae5c048
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 18:26:36 2009 -0500
Adding a Rails-specific benchmarking module
This just slightly simplifies adding lots of time-debug
stuff in Rails.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 89d91392b9fb98cc14a194729bb35cb1d87a72e2
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 18:05:34 2009 -0500
Adding simplistic param_name/puppet_tag caching
This has a drastic affect on performance - cuts
about 25% off of the store time.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ea4e3b286bd66e925c3ae5853a3a43fc5b30175f
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 17:45:24 2009 -0500
Adding more time debugging to Rails code, and refactoring a bit
There is an accumulation in the resource tags (hackish enough
but soon to be replaced), and I've fixed a small bug in
the tags merging that was causing lots of extra work (like 3x).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6314745c054ba9482f145b4ec798431ac2f300a3
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 8 16:56:41 2009 -0500
Refactoring the Rails integration
This moves all code from the Parser class into
the ActiveRecord classes, and gets rid of
'ar_hash_merge'.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit be30a618272d9828f90f5e726a23021be3b23221
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 6 18:56:27 2009 -0500
Adding a common Settings method for setting values
We were previously missing some hooks for settings set
via the command-line, because different code paths were
being used.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 863c50b1273a7fa48d74fb74948938214b45967c
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 6 19:12:04 2009 -0500
Switching to Indirected ActiveRecord
This is mostly a configuration change, with some
code getting removed.
Also adding an extra require in Format;
Puppet::Provider requires Puppet::Provider::Confiner,
so the constant lookup is weird.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a137146562fecc909afe7fc81f0033fccbb36393
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 6 19:10:59 2009 -0500
Adding ActiveRecord terminus classes for Catalog
This provides the last piece of ActiveRecord integration.
It's pretty much just pass-through and *only* works
if you're storing Parser resources to the db.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b9c95ebf81eeb78297003de2d0ed4ca048412393
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 6 16:38:14 2009 -0500
Adding ActiveRecord terminus classes for Node and Facts.
This is most of the way to replacing standard StoreConfigs
integration with the Indirector. We still need to convert
the Catalog and then change all of the integraiton points
(which is mostly the 'store' call in the Compiler).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8d0e9976b199a637d82d70701db6c682a89b9d6a
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 17:12:42 2009 -0500
Fixing #2180 - Catalogs yaml dump the resource table first
This fixes a ruby bug (http://rubyforge.org/tracker/?group_id=426&atid=1698&func=detail&aid=8886)
that otherwise results in yaml producing text it can't read
back in.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4e0de3881b55a728ee54e1cab5d3b9a6ab52a5a9
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 18 21:23:10 2009 -0500
Partially fixing #1765 - node searching supports strict hostname checking
With the new 'strict_hostname_checking' option enabled,
the compiler will only search for the literal certificate
name in its list of nodes.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c1f562dc6e6b58a2de504019b7ad8381da57e2cb
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 18 21:17:48 2009 -0500
Removing unused Node code
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e6b420088978adb3b3dd930db033df6dce59f124
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 1 07:22:31 2009 -0500
Fixing #1885 - Relationships metaparams do not cascade
Because we now pass catalogs around, rather than a tree
of resources, we no longer lose the metaparam information
in definitions and classes. Thus, we no longer need
to pass them down to contained resources.
Ideally we'd remove cascading of all metaparams (which is
ticket #1903) but 'schedule' and 'noop' are inherently
recursive but not in a way that the graph support can currently
easily solve, so that's going to have to wait for a later
release.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 50e0f3d0161bc4160e36a93d15fba53302b8727b
Author: Nigel Kersten <nigelk at google.com>
Date: Thu Apr 9 16:15:28 2009 -0700
Fix #2142 - Convert pkgdmg provider to use plists instead of string scanning for future proofing
update pkgdmg patch with feedback from dev-list
initial checking of pkgdmg package provider tests
clean up fail conditions to raise Puppet::Error instead
Finalized tests for pkgdmg provider
remove duplicate facter/util/plist require
commit c1be88742d143128ed8240316b6269b585c5084e
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 21 02:33:49 2009 -0500
Fixing #2171 - All certificate files are written with default perms
We were already writing all specific files with
appropriate permissions; this change makes all of
the files that are part of a group (which largely
means files saved by puppetmasterd and puppetca)
are also written using the correct permissions.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e2201d6e52b85ddbeaf107a41eb627994eb6973c
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Apr 19 18:52:05 2009 +0200
Fix #2173 - fix running RSpec test by hand
Since the introduction of fixing RSpec to 1.2.2, we don't
support anymore running RSpec directly ala:
ruby spec/unit/type.rb
or
spec/unit/type.rb
This patch fixes this.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 424c87b953f469cf4818236b74b5c2a0f9712f7d
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Apr 19 18:52:29 2009 +0200
Fix #2174 - Fix RSpec rake targets
The target generation was wrong, as it created some
strange target for isolated test files.
It now creates two types of targets:
* directory targets, like:
rake integration/network/server
or
rake unit/network
Those run all tests in a specific directory
* spec targets like:
rake unit:indirector:catalog:yaml
or
rake unit:parser:ast:definition
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 7ab7d9f9ff378041ab7a2baf159860439bd1c812
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 17 01:08:53 2009 -0500
Fixing #2112 - Transactions handle conflicting generated resources
This commit rips out all of the 'implicit resource' crap,
replacing it with a simple system that just skips
resources that the catalog says are in conflict.
Removes a bunch of code, and fixes the bug to boot.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 84e6c1bd95f32810e92eb760fe3f3f9efdb84f04
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 23:54:21 2009 -0500
Adding another stacktrace for debugging
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 47933347797b61e8a8ba71980396862fddd950f0
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 23:28:17 2009 -0500
Fixing puppet -e; it got broken in the move to Application
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7398fa171fdd6dcaeb2d8fd1c07a23bbd78891d0
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 16 14:54:40 2009 -0500
Partially fixing #2029 - failed caches doesn't throw an exception
If the main terminus fails you get an exception, but
not if a cache terminus fails.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 88ff9c6500e76fdda02e60262dd1571577c0b92b
Author: Luke Kanies <luke at madstop.com>
Date: Sun Apr 12 23:10:58 2009 -0500
Fixing #2111 - SimpleGraph only creates valid adjacencies
The way this class was testing edges was
causing them to appear adjacencies to appear magically,
because it was only testing that a hash had a key, not that
the value had any edges.
This fixes the infinite recursion mentioned in #2111.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 36594fecd8e30f732f09bc940adbb4c686e314ba
Author: Luke Kanies <luke at madstop.com>
Date: Sun Apr 12 22:55:39 2009 -0500
Switching to new() in the Puppet::Type.instances() class method
Signed-off-by: Luke Kanies <luke at madstop.com>
commit edcbab5d046326cfbc69fdffafdaba033a125da8
Author: Luke Kanies <luke at madstop.com>
Date: Sun Apr 12 22:55:04 2009 -0500
Removing duplicate method definition from SimpleGraph
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 39bd8af772d3b99fc83314d229a7d51bf3970a5f
Merge: d8eaca88038fa0ef15fda0c4a11a7f08daebc8ef 916dd60dc8392c1ee612028008a52926676e894b
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 11 22:33:51 2009 -0500
Merge branch '0.24.x'
commit d8eaca88038fa0ef15fda0c4a11a7f08daebc8ef
Author: Ohad Levy <ohad.levy at infineon.com>
Date: Thu Apr 9 20:58:47 2009 +0800
mini daemon to trigger puppetrun on clients without puppet listen mode
commit 7bb8c35f6c70cf32feba9a3ce224155b9d446289
Merge: d2c417ef48dbb2074c1c58ec2c86ba2d52ecc895 0863a7928ff6c15dcd8ace7119a3fa64bbcec6b3
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 7 15:11:56 2009 -0500
Merge branch '0.24.x'
commit d2c417ef48dbb2074c1c58ec2c86ba2d52ecc895
Author: Paul Nasrat <pnasrat at googlemail.com>
Date: Thu Mar 26 11:58:10 2009 +0000
Fix #2113 - Make temp directory
Tests were failing this patch makes the temporary directory in line with other
integration tests.
commit 916dd60dc8392c1ee612028008a52926676e894b
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Apr 6 12:36:16 2009 +1000
Fixed rspec gem at version 1.2.2
commit 57b37e5182d01b640dc794b0a82128f8aeddfd7d
Author: Ethan Rowe <ethan at endpoint.com>
Date: Sat Apr 4 17:40:08 2009 -0400
Add @options to test run call, for compatibility with more recent rspec versions.
commit 3aedfd8bbcefcdb92af57e4661a360be9aee2716
Merge: 173b5f0a162d8dd7f72e1cab257069bc65382960 a677e26eb1452c08d7724047a18e50f4a654d2cd
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Apr 6 11:45:23 2009 +1000
Merge branch 'master' of git://reductivelabs.com/puppet
commit 173b5f0a162d8dd7f72e1cab257069bc65382960
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 31 18:37:40 2009 -0500
Adding #2122 - you can specify the node to test with puppet-test
This commat adds a --node option to puppet-test,
so that you can use locally cached node and fact data
for testing local and remote compiles.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0863a7928ff6c15dcd8ace7119a3fa64bbcec6b3
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 31 18:37:40 2009 -0500
Adding #2122 - you can specify the node to test with puppet-test
This commat adds a --node option to puppet-test,
so that you can use locally cached node and fact data
for testing local and remote compiles.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a677e26eb1452c08d7724047a18e50f4a654d2cd
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 2 19:41:17 2009 -0500
Fixing all tests that were apparently broken in the 0.24.x merge.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e016307f00fe67dc53f8581f08c1dfb5ab7dfb3b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 2 19:34:38 2009 -0500
Fixing Rakefile; apparently there was a rake or gem incompatibility
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6e79cc00965a50c44f215fd1e553281cfd2b87c9
Merge: 62dad7a5f87f8d6285650ab1b727819db27cf2a7 c62c19370bfba881819c1a3d9da2f8e6fb52e5d9
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 2 18:56:53 2009 -0500
Merge branch '0.24.x'
Conflicts:
bin/ralsh
lib/puppet/executables/client/certhandler.rb
lib/puppet/parser/functions/versioncmp.rb
lib/puppet/parser/resource/reference.rb
lib/puppet/provider/augeas/augeas.rb
lib/puppet/provider/nameservice/directoryservice.rb
lib/puppet/provider/ssh_authorized_key/parsed.rb
lib/puppet/type.rb
lib/puppet/type/file/checksum.rb
spec/integration/defaults.rb
spec/integration/transaction/report.rb
spec/unit/executables/client/certhandler.rb
spec/unit/indirector/ssl_rsa/file.rb
spec/unit/node/catalog.rb
spec/unit/provider/augeas/augeas.rb
spec/unit/rails.rb
spec/unit/type/ssh_authorized_key.rb
spec/unit/type/tidy.rb
test/executables/filebucket.rb
test/executables/puppetbin.rb
commit a43137c7526f4693e9266040d55ddb397f58500c
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Mar 30 19:55:59 2009 +1100
More RST fixes
commit 843cc6e50586fa6667ba95d1d1c46bb1eefff23c
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Mar 27 12:06:54 2009 +1100
Fixed RST for functions
commit 6160aafe86e48d545583a2e9e093754ac32a5ced
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jan 22 10:39:49 2009 +1100
In order for ReST formatting to work properly, newlines and
indentation of doc strings must be retained.
Signed-off-by: Thomas Bellman <bellman at nsc.liu.se>
commit 62dad7a5f87f8d6285650ab1b727819db27cf2a7
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Wed Mar 25 22:44:58 2009 +0100
Fix #2107 - flatten resource references arrays properly
Resource parameters of the form
[Res[a], Res[a,b]] ends being evaluated as
[Res[a], [ Res[a], Res[b] ]
This last form was not flattened when transfomed into RAL
type, which in turn prevented the sub array to be converted
in regular resource references.
Thus the type was choking when encountering those native
parser references instead of usual resource reference.
The fix consists in flattening array of references before
transformation to trans objects for RAL.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit cbee426854c09fae4d9675edb787d4563e9b9ac8
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 23 23:17:11 2009 +0100
Fix #2101 - Return to recurse=0 == no recursion behavior
Ticket #1469 introduced an incorrect change of behaviour where
recurse = 0 was considered as an infinite recursion, unlike
before.
This patch restores this behavior, and makes some test pass.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3b4816b842f1dc3febe95df2b9ae25cfabc5a2df
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 23 23:16:56 2009 +0100
Fix #2101 - fix failing test
This code hasn't been modified since the introduction of the
fileset recurselimit parameter. Tests depending on this code
were failing.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit f089e115fd126e2fae664322b7a27cb31f0efd3d
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Mar 23 23:16:41 2009 +0100
Fix #2101 - fix recurselimit == 0 bad behaviour
After the fix for #1469, recurselimit = 0 was considered as
an infinite recursion which is the reverse of what it was before.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 14762c3f3624a2b59685099548e7e106bd7b0b9d
Merge: 1b4eae73665e03b9ce7ee77b5f4799502619e426 3f61df8716d1ed66fb24bf7bcf64fcc2ebc711b9
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Mar 27 00:04:30 2009 +1100
Merge branch 'tickets/master/2110'
commit 1b4eae73665e03b9ce7ee77b5f4799502619e426
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Mar 26 23:33:30 2009 +1100
Added rake ci:all task
commit d1259372ea955c488efa37724fc74a55da28eefc
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Mar 26 23:33:30 2009 +1100
Added rake ci:all task
commit 3f61df8716d1ed66fb24bf7bcf64fcc2ebc711b9
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Mar 26 10:00:13 2009 +1100
Fixed #2110 - versioncmp broken
commit c62c19370bfba881819c1a3d9da2f8e6fb52e5d9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Mar 23 03:41:25 2009 +0000
Updated to version 0.24.8
commit aa00bdedefcf4dce9c55968e33123a73b78fb6d6
Author: Luke Kanies <luke at madstop.com>
Date: Sun Mar 22 22:00:41 2009 -0500
Fixing #1631 - adding /sbin and /usr/sbin to PATH
This is a trivial fix but seems to crop up more often
than it should.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 39deaf373c46c20d14a04391ad4b7c70ad43e266
Author: Francois Deppierraz <francois at slayer.ctrlaltdel.ch>
Date: Sat Mar 21 23:32:02 2009 +0100
Fixed #2004 - ssh_authorized_key fails if no target is defined
This commit depends on 7f291afdacf59f762c3b78481f5420ec8919e46d
(fixing #1629) which was cherry-picked from master.
Signed-off-by: Francois Deppierraz <francois at ctrlaltdel.ch>
commit dcf2bf2be7275afc68054f3c9d51b548111b6574
Author: Francois Deppierraz <francois at slayer.ctrlaltdel.ch>
Date: Sun Mar 22 00:09:11 2009 +0100
Changelog entries for #1629 and #2004
Signed-off-by: Francois Deppierraz <francois at ctrlaltdel.ch>
commit bbcda1d5bcab492dc68d331e6f78fb0473e9f046
Author: Francois Deppierraz <francois.deppierraz at camptocamp.com>
Date: Fri Nov 28 15:12:30 2008 +0100
Fix Bug #1629
A refactoring of ssh_authorized_key parsed provider was needed and tests
were improved. flush method has been split for clarity.
commit 69a0f7dc8d3ba1c64e5acdf99628f10b41ab8e30
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Dec 19 17:35:08 2008 +0100
Fix #1807 - make Puppet::Util::Package.versioncmp a module function
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 081021af4dda0d19e7de7debb580196219bb7c36
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Dec 19 17:38:50 2008 +0100
Fix #1829 - Add puppet function versioncmp to compare versions
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 2b33f80d167424abcd153e01aa1a93ae38155120
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Mar 20 20:37:05 2009 +1100
Fixed install.rb typo
commit 5ab63cdf2efa9a8557d3837c32d8336dd23a4b85
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Mar 20 20:34:13 2009 +1100
Updated lib install permissions to 0644
commit 830e1b1f3c73e63b698f04298e8f5ff827a85dad
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Mar 21 02:39:35 2009 +1100
CHANGELOG updates
commit 3e0a9cda8c6f3866c85fd20dd56a6bafcc0e0db7
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Mar 21 02:27:00 2009 +1100
Moved of puppetd, puppetca, puppetmasterd, puppetrun binary from bin to sbin
commit 6ddebf4d6f5f1537987cdc15a32f439149d73ce6
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Mar 21 02:22:31 2009 +1100
Fixed #2086 - Fixes to make building tarballs easier
commit 33d3624c91b236e237fe194d9df3d9fa324111c3
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Tue Feb 24 18:48:52 2009 +0100
Fix #1469 - Add an option to recurse only on remote side
When using recurse and a source, if the client side has many files
it can take a lot of CPU/memory to checksum the whole client
hierarchy. The idea is that it is not necessary to recurse on the
client side if all we want is to manage the files that are sourced
from the server.
This changeset adds the "remote" recurse value which prevents recursing
on the client side when a source is present. Since it also is necessary
to limit the remote side recursion a new File{} parameter has been
added called "recurselimit".
Moreover, the Filetset API is changing to allow the new recurselimit
parameter, and passing the recursion depth limit in the recurse parameter
as an integer is now deprecated and not supported anymore.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 77ade43dec5e6fc5afac7abe4b331a3bc7887e42
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 20 00:25:16 2009 -0500
Forbidding REST clients to set the node or IP
This is done for security reasons - if a client is
unauthenticated, we don't want them to be able to
just configure their own authentication information.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0179e945a7d402c90a333c8207243882af362e06
Author: Luke Kanies <luke at madstop.com>
Date: Thu Mar 19 23:58:19 2009 -0500
Fixing #1557 - Environments are now in REST URIs
This commit includes multiple, related changes, all
in one commit because the whole thing was necessary to
reach a functional tree again:
* The URI starts with the environment, so:
/production/certificate/foo
/development/file_content/path/to/your/file
* All REST handling is done by a single instance mounted
at / for webrick and Mongrel, rather than having individual
instances mounted at, say, /certificate.
* All REST URI translation is done by an API module. Currently
only the 'v1' module exists with no support for additional modules,
but it's well-separated and will be easy to expand as we need it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a497263d97229489dcc4341cc98ca3c75f116374
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 18 01:00:56 2009 -0500
Adding explicit optional attribute to indirection requests
Previously, any option that had a setter was treated
as an attribute, but now we're specifying the list of
attributes settable via options.
We also have a to_hash method that will take all of the
options and all of those attributes and join them
back into a hash. This method is used by the REST Handler
module, since it uses the indirection request internally.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3e954997f7688f0193010de776879d23545a8ca5
Author: Luke Kanies <luke at madstop.com>
Date: Sun Mar 15 17:52:35 2009 -0500
Removing an unused source file
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 97975e14acfc8c62488a2e6495ca00d426bc9290
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 18:38:55 2009 -0500
Adding a model accessor to the Request class
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b6116fe28d9c771dbe2dcded539bcf30eea552a3
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 18:23:04 2009 -0500
Requests now use default environment when none is specified
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 15740fe090365a81202fd44244e88b976f1d14d7
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 17:39:51 2009 -0500
Moving the REST API functions into a module
This module is now used by the client and
server side, rather than having a Handler module
that's 90% server functionality but also used by
the client.
While we don't automatically get api choice from this,
it at least provides a pattern for how we'll handle API
development over time.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ef4fa681be07881bab3e1e920585cc4fbbf6f4d1
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 17:24:09 2009 -0500
Using the Handler for the REST api on both sides of the connection
Things are actually in a broken state here because we've
got a conflict between how the two sides do their work
and some extraction needs to get done. This commit
is just a stopping-point so I can do the necessary
refactoring.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8b13390819f9aec9f344a72b3c0b3b6609f6209d
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 01:38:47 2009 -0500
Adding REST::Handler methods for converting between indirection and uris
This is the first main phase to having a common module for
handling the REST api - this Handler module will be included
by all of the web server REST modules and the Indirector
Request class, so there's a common place that understands
how the URI consists.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit edf00dba76b65108b443af8d0636073cb3d9d975
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 13 01:22:12 2009 -0500
Adding environment support to the REST URI
Also adding it to the Indirection Request.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a064ed1a6035c44f123e092b2429895fb45bdbd2
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 25 17:36:03 2009 -0800
Moving the query_string method to Request
It required a request instance and didn't use
the REST class it was in, so it makes more sense in
the Request class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ff9c3ca4059a63523b07d89f1b967f6bf1c4bba4
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 25 17:29:42 2009 -0800
Adding tests for the REST query string usage
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 87ec08e5d5efe1576e338861bc514b7b5c2a6d6a
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 20 00:49:46 2009 -0500
Fixing #2108 - pi should work again
Signed-off-by: Luke Kanies <luke at madstop.com>
commit af4455e31df403c55a5db06ee8d0d4e0e58c4154
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Nov 29 17:41:45 2008 +0100
Fix #1088 - part2 - Add rspec tests
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b15028f55ba608a701efae1ee392d50374b2be54
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Oct 11 17:26:50 2008 +0200
Fix #1088 - Collections overrides
This changeset defines a new syntax to override collection
of resources (virtual or not). This feature is not constrained
to the override in inherited context as usual resource
override.
The collection of resource supports a query like regular collection
of virtual or exported resources.
Usage example:
file {
"/tmp/testing": content => "whatever"
}
File<| |> {
mode => 0600
}
It also introduces a different behaviour for collection of catalog
resources. Before this patch, only virtual resources were collected,
now all resources (virtual or no) are collected and can be overriden.
That means it is now possible to do:
File <| |> { mode => 0600 }
And all the Files resources will have mode 0600.
It is then possible to have this puppet pattern:
file { "/tmp/a": content => "a" }
file { "/tmp/b": content => "b" }
File <| title != "/tmp/a" |> {
require => File["/tmp/b"]
}
which means that every File requires a file.
Moreover it is now possible to define resource overriding
without respecting the override on inheritance rule:
class a {
file {
"/tmp/testing": content => "whatever"
}
}
class b {
include a
File<| |> {
mode => 0600
}
}
include b
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b24b9f5de02f4dfc6a7e89d5432aec32ea39cae1
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Mar 14 11:25:03 2009 +1100
Fixed #2071 - Updated LDAP schema
commit 88aa1bc2cfef4517fca9e467c86f70ae356be883
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 11 23:52:53 2009 -0500
Fixing tests broken in previous commits
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f8dea989e3f5bd7d3d823a6c3dc3cf76cd5cba4e
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 10 04:07:12 2009 -0500
Fixing #1949 - relationships now use attributes instead of a label
This was important because the use of the label to store attributes
was a holdover from the GRATR library, and if we didn't cease its
use before we switched to RESTful catalogs, then we'd be stuck with
the @label instance variable forever, essentially.
Now we can add and remove variables however we please.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d0fc2f5738a78c51128f6377c03fe42cf50371a0
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 10 00:48:13 2009 -0500
Correctly handling numerical REST arguments
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 90afd48c39bc7bbb8e7afa81a49d2f814a787565
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 10 00:32:36 2009 -0500
Not passing file sources on to child files
This was sometimes causing files to get converted to
directories.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 858480b04d84e56aa483c80642dd0512af4fd025
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 10 00:27:46 2009 -0500
Correctly handling non-string checksums
Content is now returning the checksum rather than
the actual content, and the method of creating
the full checksum wasn't correctly handling
timestamps, which aren't strings and can't be the
right side of a String + call.
I've opened #2064 as a better long-term fix.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 27aa21012d249bd39070115e6f640c0196bbdd81
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 10 00:22:32 2009 -0500
Removing unnecessary calls to expire()
These calls were resulting in 1-2 extra round
trips per file. For simple comparison,
200 empty files took 73s before this change
and 20s after.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5329b8a7a8869ca1a73188c48d411ed4c35ff291
Author: Luke Kanies <luke at madstop.com>
Date: Thu Mar 5 22:12:31 2009 -0600
Passing checksums around instead of file contents
This switches the file's 'content' parameter to always
use checksums, rather than always using content but switching
to checksums whenever necessary.
This greatly simplifies all the logging requirements (so
that content doesn't show up in logs), but also simplifies
insync comparisons, and much more.
In the process, I found that the code was pulling down file content
more often than was necessary, and fixing that cut 40% off of the time
of a very small transaction.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 71e4919f6b60b36b9ba0b02d3619c0fb5e4df445
Author: Luke Kanies <luke at madstop.com>
Date: Thu Mar 5 17:13:17 2009 -0600
Moving default fileserving mount creation to the Configuration class
It was previously in the parser, but the parser is only created
if the fileserver.conf exists, so the default mounts weren't
made if the file didn't exist.
This is a bit less encapsulation, but not much.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 09bee9137d7a6415609a8abfdf727ee0361139e0
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 27 17:52:01 2009 -0600
Fixing #2028 - Better failures when a cert is found with no key
The problem was that the server had a certificate
for the client. Initially the client just didn't have a
key, because it assumed that if it had a certificate then
it had a key. Upon fixing it to create the key, the key then
did not match the found certificate.
This commit fixes both of those: The key is always found
before the certificate, and when the certificate is found
it's verified against the private key and an exception
is thrown if they don't match.
It's always a failure, so this just makes the failure
more informative.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cf1cb1474f13ae2fc4ec27142fd34d494826c929
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 27 17:17:04 2009 -0600
Moving the clientyamldir setting into the puppetd section
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5f73eb553fd083b558fb9553b0c07b6019d0ccee
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Feb 26 11:43:39 2009 +1100
Fixed #1849 - Ruby 1.9 portability: `when' doesn't like colons, replace with semicolons
commit e40aea3c655e698d26c29370227b52c489e6db2b
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Feb 26 01:37:17 2009 +1100
Fixed metaparameter reference to return str
commit ed5562aae444b81deabf9217be98886535620c76
Merge: 7e207a1d2d0dafff96e34a51ce7798f8e62bac19 5df9badbae0a652094216b52c815c0cc72f3ea42
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Feb 24 20:36:21 2009 +1100
Merge branch 'tickets/master/2016'
commit 5df9badbae0a652094216b52c815c0cc72f3ea42
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Feb 24 09:14:23 2009 +1100
Fixed #2016 - Split metaparameters from types in reference documentation
commit 7e207a1d2d0dafff96e34a51ce7798f8e62bac19
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Feb 24 09:08:56 2009 +1100
Fixed #2017 - incorrect require
commit 417b5a5f4b4a01259b42f3b787c471b7f973e0b3
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 20 11:26:01 2009 -0600
Fixing #1904 - aliases are no longer inherited by child files
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 602409e18c5b3229f6d239ac28472dd4709a117b
Merge: c0d5037d11643fd551fdc9f20a9e0ba196c5345a d758f45a14057f0b9517a1905d575d6b28b90bc2
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 20 09:51:12 2009 -0600
Merge branch '0.24.x'
Conflicts:
lib/puppet/type/file/content.rb
spec/unit/type/file/content.rb
commit c0d5037d11643fd551fdc9f20a9e0ba196c5345a
Author: Luke Kanies <luke at madstop.com>
Date: Thu Feb 19 16:51:50 2009 -0600
Removing or fixing old tests
Most of these were just obsolete tests that have
been sitting around and broke with recent internal
changes.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 262937ff6e505bbf86d15500279ff23398f9e1c8
Author: Luke Kanies <luke at madstop.com>
Date: Thu Feb 19 16:09:58 2009 -0600
Correctly handling URI escaping throughout the REST process
This means, at the least, that we can now serve files
via REST when they have spaces and other weird characters
in their names.
This involves a small change to many files.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b800bde30bd5a08f5e222725588062e2bca37a79
Author: Luke Kanies <luke at madstop.com>
Date: Thu Feb 19 12:57:29 2009 -0600
Refactoring how the Settings file is parsed
The goal of this refactor was to use a cached attribute
for the LoadedFile instance we use to monitor whether
the file needs reparsing. We were getting tests that
affected later tests because they were holding on to
LoadedFile stubs, somehow.
The other main change here is that the Settings#parse
method now knows how to look up its own file path.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d7864bedafcca07806f6da3e3f472dc80d3206b7
Author: Luke Kanies <luke at madstop.com>
Date: Thu Feb 19 12:53:07 2009 -0600
Relying on 'should_parse_config' in the 'puppet' application
There was some redundancy here, as the app was marked
as needing to parse the config, but then the setup
hook manually parsed it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bd8d09747fd6c0dce89c17da41eb67ad92823cf7
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 17:00:27 2009 -0600
Providing better indirection authorization errors
The errors now include the indirection and key,
or the full URI used.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d3bc1e8279b6e1d372ab3624982788cde026461d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 16:33:47 2009 -0600
Adding pluginsyncing support to the Indirector
This switches away from the use of terminii for
each type of fileserving - it goes back to the traditional
fileserving method, and is much cleaner and simpler
as a result.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 00726bac02211be3c269c23a564bdcc8fdd28c2b
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 15:27:32 2009 -0600
Moving Request and Fileset integration into Fileset.
It was previously in a helper module, TerminusHelper.
I hope to actually remove that module entirely.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 058266feebb3be90f6af29d0ff70b22ceeb9b3e7
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 12:16:39 2009 -0600
Switching the ModuleFiles Indirection terminus to the new Module/Env api
Again, much cleaner and simpler.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 19b85346a60a05fd146fe39742cb873490eb6b4c
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 12:00:29 2009 -0600
Migrating the old FileServer to the new Module/Environment code
The interface is *much* cleaner, and I'd removed one of the methods
used in this code.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1be7c763b51c0cb6b271429f83ca4afb733bbf63
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 19:00:03 2009 -0600
Using the Environments to handle a lot of Module searching
Since Environments now know how to look for modules,
a lot of the Module code was able to be pushed into them.
Also moving some of the tests to instance-level tests,
rather than just testing the class-level interfaces.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2b4469d1c881065587a28924c702cefbf46d098d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 18:24:28 2009 -0600
Environments now use their own modulepath method.
They were previously still using just the variable itself.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 94de52657c0cfff9bed312cffe78f9b59b9081d2
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 18:07:27 2009 -0600
The 'Environment' class can now calculate its modulepath.
This includes adding PUPPETLIB from the shell environment.
I'm moving responsibility for this from the Module class,
because nearly every method in Puppet::Module accepted
'environment' as its argument, which is a good sign that
it's on the wrong class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2573ef1c4c2d472f9cf41ab3a1b67b7408d704b4
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 17:55:57 2009 -0600
Added support for finding modules from an environment
This uses the environment to search for the modules, rather
than relying on the Puppet::Module class to know how to
handle environments.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9c18d5aa4214f565b81b6cac07736fe072954bb1
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 17:50:46 2009 -0600
Adding support for finding all modules in a given path.
This 'each_module' method will be used by environments
to find all or a given module, and will likely eventually
be used internally, too.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4b5ec82d32babdf3ccc935748eb80bca30b379ff
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 17:24:25 2009 -0600
reformatting the environment tests
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 458642b8660c8f0507b1f66b67bade5c60efe64a
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 17:16:20 2009 -0600
Supporting multiple paths for searching for files.
This is, once again, used for plugins, which needs
to search across multiple modules' plugin directories.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit eec1caddf0dc431229ceb1741b357a9fefce5c38
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 17:15:17 2009 -0600
Adding support for merging multiple filesets.
This is required for plugins, which recurse across multiple
directories.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bdf3a80e29313008367d83f5a1ec6e4121e4ec74
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 16:20:34 2009 -0600
Adding new methods to Puppet::Module.
There are now boolean methods to test whether a given kind
of file is present in a given module. E.g, you can do:
Puppet::Module.new("mod", "/my/path").plugins?
There are also accessor-style methods that return the
full path for a given kind of file.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a7be174d249ca581d9ae849ba3823abc2c006b08
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 17 16:14:36 2009 -0600
Refactoring Puppet::Module a bit.
No behaviour change here, just some internal changes to
make way for methods I want to add.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7ceb437c8f8f545484ebc1236c714f685d5eb7c0
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 18:03:57 2009 -0600
Only using the checksum cache when we're using a host_config catalog
Only host-configs actually load and store the state file,
so any attempt to use that state will just result
in lots of "initializing" and "creating" messages.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5fd182dc1ce1e5e8dd0eba83d7514e9950aca8a0
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 17:50:19 2009 -0600
Fixing fileserving to support strings or symbols
When used internally we would use symbols, but
the REST transfers need to support strings.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7bc41cefa0115067a2e9aab3dbd1924667c46dfe
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 17:35:34 2009 -0600
Adding clarity to query string handling in REST calls
We previously only handled simple strings as values,
but we know handle true and false as booleans, we URI-escape
all strings, and we can yaml-encode and then escape arrays of
strings.
This could get abused a bit, in that we're just yaml-dumping anything
that's an array, but it should be pretty safe. Mmmm, should.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 992231a58daf8f0b489022f0af8ddcfb615bb0e1
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 17:32:13 2009 -0600
Some small fixes to provide better debugging and load a library
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0304a78c0fe3802e4fb7466c3eac111d45f8eed7
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 12:57:27 2009 -0600
Providing better information when an exception is encountered during network communication
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4a7cba3f2ed634c49bdfb2c3aba7153668c6afd0
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 22:37:09 2009 -0600
Stubbing tests that were affecting other tests
These stubs are all for global configuration state.
It's a known problem that these have to be stubbed,
but we haven't been able to find a design yet that
fixes this.
At least these tests are no longer breaking other tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3105b5bb33639fb8a39234adfa84f354e7189785
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 22:03:36 2009 -0600
Fixing a warning in a test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c854c593777f31de155f6c4dbd1292dff2f936d5
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 18 21:38:52 2009 -0600
Fixing a syntactically invalid application test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0f43fd6c894dd2be7f08209f28caf34be768f238
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 14:40:25 2009 +0100
Move --version handling to Puppet::Application
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 156fb81ca914f6d697dc2cb81788a1d9ab5a23e4
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 17:16:20 2009 +0100
Move puppetd to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 0c71c5cde211808ef6fd744ccbcc82b6cfc38bb5
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 17:16:09 2009 +0100
Move puppetdoc to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit e317fa9717e648435dbbc62497d73f803b7b2760
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 17:15:52 2009 +0100
Move ralsh to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 81f5438f663820748d3bd580d7436619ed57b6f0
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Feb 1 17:10:59 2009 +0100
Move puppetrun to Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3390d8db8b1d31b52a71b9502deb0e0784cf8ade
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 17:15:39 2009 +0100
Move pi to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 8265d6eaf7dd7d4fb2af30363bfbcc698dea1436
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jan 18 20:12:53 2009 +0100
Move puppetmasterd to Puppet::Application
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit af219bf45fe58287f1b46bcfd98dfbe548958b33
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 17:15:08 2009 +0100
Move puppet to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d51398c3eb3c09a9912fff8b4b7656a9ddb6b873
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 16:17:20 2009 +0100
Move filebucket to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 9b9e5e895bef9e59f7d592d6eb687ab1f683c117
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Feb 14 16:16:57 2009 +0100
Move puppetca to the Application Controller paradigm
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 97e716a97de81bb31b665c70489ee1657ddc5424
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Dec 21 20:38:48 2008 +0100
Introducing the Application Controller
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 495ad6654643ee7cfc500a174d36fe67eb8970b1
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 09:26:21 2009 -0600
Fixing broken filetype tests resulting from the loss of Type[]
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 21a714aa75ff896fa67160a5ceaa26b6c0df98f5
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 22:18:36 2009 -0600
Fixing some tests that somehow broke in the merge to master
I expect these failed in master but not 0.24.x because I'm
better about stubbing calls to Facter in master.
I stubbed these enough that they should continue to
work.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 327ee17d607937dec007482d1c81bae63c01bf52
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 21:57:14 2009 -0600
Removing a test that was too dependant on order.
It wasn't a terribly useful test anyway, since
no one depends on that individual configuration.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8adb599f14040f1ed00a2d5bf7cfa3c22715cba4
Merge: e87de9d8f3be325fb0495dd5c64e08625333924f c0f494334b374d6f0b0eb3d5741aaff70052d564
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 21:53:51 2009 -0600
Merge branch '0.24.x'
commit e87de9d8f3be325fb0495dd5c64e08625333924f
Merge: 487b9b1a3e8b9207a9910bc5eaeeb75cb3e4abe5 24d48e6c07ef634971fcb8ed5b27258db161a018
Author: Luke Kanies <luke at madstop.com>
Date: Sat Feb 14 18:10:37 2009 -0600
Merge branch '0.24.x'
Conflicts:
test/ral/manager/type.rb
commit 487b9b1a3e8b9207a9910bc5eaeeb75cb3e4abe5
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 22:11:42 2009 -0600
Failure to find node facts is now a failure.
It was previously just a warning, but the node
is essentially non-functional without the facts,
so it makes more sense for it to be a warning.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 610c838146c03921455a15a7a93148748ff909a6
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 21:36:39 2009 -0600
Fixing #1527 - Failing Facter does not hurt Puppet
At this point, the server's behaviour is a bit undefined
if it tries to compile the catalog with no facts
locally. The next commits will fix that.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a2eca6c8a1c69244426b077c5775a1cdbdae2d57
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 21:12:16 2009 -0600
Removing some unused code
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cb0a083a4c7447d6da2f6a1ce6725cedeb831db1
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 21:09:07 2009 -0600
Using Puppet::Type.new instead of create
create() got deprecated and I apparently missed
changing this.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 84bd5285db5a80b01dd0359387516210ccb5b625
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 21:06:34 2009 -0600
Actualling syncing facts and plugins
Also fixing the argument order while downloading
either of them. I had my Downloader.new
calls using the wrong argument order.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d5abdfba8a88afda8085992a4abbe1d90bbd0084
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Feb 5 23:15:59 2009 +0100
Fix #1933 - Inconsistent resource evaluation order in subsequent evaluation runs
While evaluating the AST, catalog vertices are not always ordered
the same way on different run, leading to some tags (which should
have been applied in evaluation order) to not be associated with
some underlying resources.
This changeset change all accesses to resources inside the compiler
to always use an ordered (in evaluation order) list of added
resources.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3fbec120768d84d208b14f574dfe916e25cfdbef
Merge: a2270b4a4f093c6c4f171dcf0c0e05fe101dd979 2561c8e252dcf66890513458750bb1329a03beec
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 13 18:24:34 2009 -0600
Merge branch '0.24.x'
Conflicts:
lib/puppet/indirector/facts/facter.rb
lib/puppet/provider/augeas/augeas.rb
lib/puppet/util/filetype.rb
spec/unit/indirector/facts/facter.rb
spec/unit/provider/augeas/augeas.rb
test/util/filetype.rb
commit a2270b4a4f093c6c4f171dcf0c0e05fe101dd979
Merge: 9bac833dcfdd8d6a00188faee0487e787b7a0101 6b0c1b9170c69829bdf5956d1dec0949dcc08b35
Author: Luke Kanies <luke at madstop.com>
Date: Wed Feb 11 13:51:48 2009 -0600
Merge branch '0.24.x'
Conflicts:
CHANGELOG
spec/unit/type/file/selinux.rb
commit 9bac833dcfdd8d6a00188faee0487e787b7a0101
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Feb 10 15:19:57 2009 +1100
Adding README.rst file
commit 916abc2e68a9b0a095c5783854a4b0a4819ddf2c
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 6 19:11:54 2009 -0600
Changing how the Configurer interacts with the cache
This changes the hooks provided via the Indirector Request
for determining how the cache is used. These hooks are only
used by the Configurer class. They're messy, but I can't
come up with a better design, and they're at least sufficient.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 53357884111d3499746b292f99948d5eb3c83415
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 6 17:52:34 2009 -0600
Fixing tests broken during the #1405 fix.
Most of these were small changes, like moved methods.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 08a5d492dd3545366a2850d568d87aad0ba884e6
Author: Luke Kanies <luke at madstop.com>
Date: Fri Feb 6 17:27:44 2009 -0600
Adding an Agent::Runner class.
This will eventually be used by puppetrun, but
for now is just called by the old-school Runner handler.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c7d178d04f324c010de1552083a954bb4b02217d
Author: Luke Kanies <luke at madstop.com>
Date: Thu Feb 5 14:50:06 2009 -0600
The Agent now uses its lockfile to determine running state
This makes it so we can easily create and use lots
of agent instances, rather than having a single
global instance with shared state.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c0fcb2137e66af8ba60a959faa221034c6832b69
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 2 17:19:07 2009 -0600
Creating and using a new Puppet::Daemon class
This replaces the short-lived EventManager class, all of
the service- and timer-related code in puppet.rb, and moves
code from agent.rb, server.rb, and other places into one
class responsible for starting, stopping, pids, and more.
The Daemon module is no longer in existence, so it's been
removed from the classes that were using it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 700e823f7c33eb3c5b4d9e467742fd24f63bbeef
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 2 17:16:07 2009 -0600
Not using 'master' client for testing
That class is gone, so until the Client class
is no longer necessary, using a different class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4b7023e97662f944844cb58cd9807c988e4c28e9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 2 17:14:12 2009 -0600
Fixing (and testing) the return of Indirection#save
This broke in a previous commit, and was apparently not
tested well because of how the mocks were set up. The
integration test caught it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8dc0005473ad2b0785919e0bd79ac7d60342625d
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jan 31 10:29:48 2009 -0700
Adding a 'close_all' method to the Log class.
This moves the code out of Daemon.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 37d1a7cf2c637e2bde16623007014125066fcec5
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jan 31 10:04:47 2009 -0700
Removing restart-handling from Configurer
This will be handled by the Agent or the Daemon class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bf3c72e8a1ed59daf5027c508f2d6dd95424f5bc
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jan 31 10:00:48 2009 -0700
Adding temporary class EventManager
Most of the way through implementation of this class, I realized
that most of its functionality will never actually be used.
Thus, I'm refactoring it and the Puppet::Daemon module into a
single Puppet::Daemon class with merged functionality, and then
moving all of the daemon-like functionality out of both the
Agent and Server classes.
We'll then have a Daemon class that knows how to start and stop
services, create and remove pidfiles, and whatever else
daemons need to know how to do.
This commit is to just so I have the current code snapshot.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fc14b81f99adc9c9308a26d322adaa59a7b7716d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 17:11:19 2009 -0600
Splitting the Agent class into Agent and Configurer
Once I went to add runinterval support to the Agent class,
I realized it's really two classes: One that handles starting,
stopping, running, et al (still called Agent), and one that
handles downloading the catalog, running it, etc. (now
called Configurer).
This commit includes some additional code, but 95% of it is just moving code around.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e8be6dcad2150769b51bf81e95c57491921e68c1
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 14:58:52 2009 -0600
Removing the Hash default proc from SimpleGraph.
Again, necessary so that the class can be dumped
in Marshal or YAML.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6bb804fb840b3d08f759fb7b7b08633bc3f94a64
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 14:26:09 2009 -0600
Removing the Catalog's @aliases hash default value
This was prohibiting the catalog from being dumped.
No tests, because I didn't change behaviour and the existing
tests provided sufficient coverage.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 502e062c27a46e70fdfe833ed32ef1e63b285e31
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 14:09:50 2009 -0600
Removing an erroneous configuration call in puppetmasterd
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 337057ad666e3ef3a5b2d8f7baccbc9370add5b4
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 18:54:44 2009 -0600
Removing obsolete code and tests for the agent.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d53ad3181d3f5953b00512d7793945d238d1879f
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 18:49:26 2009 -0600
Converting the catalog as needed
Converting to a Resource catalog for transmission,
then converting to a RAL catalog on the client.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f38277fb7d044394665db369892c01162b866863
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 17:55:16 2009 -0600
Adding REST support for facts and catalogs.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c48525bbf138288d9ae920c598a634c8a5f2cb46
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 17:28:49 2009 -0600
Adding better error-handling to format rendering
We now always get the format name and the method that
failed.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b93a642d4afb1dd694f877565810eaa3de5bc9b0
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 16:58:54 2009 -0600
Resetting SSL cache terminii to nil when only using the ca
This is important because puppetmasterd changes its configurations
a couple of times, and we need to disable any previously-created
caches.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 212b3e3dff7cb8846e0d09d39faf226b60c62e6b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 16:56:14 2009 -0600
Allowing the Indirection cache to be reset to nil
Otherwise we couldn't disable a cache once configured.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5a835315c203e6951562c098a99c4276ed60a17e
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 16:41:32 2009 -0600
Moving the Agent locking code to a module.
Also cleaning up the lock usage by yielding to a block
when a lock is attained.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b672790ff04022c043c9dc10d47ac82787ce5632
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 16:10:58 2009 -0600
Cleaning up SSL instances that can't be saved
If the SSL Host couldn't save a CSR or key, it would still
keep them in memory; this meant that, for instance, a CSR
that couldn't be saved to the server was never resent.
This commit removes in-memory instances that couldn't be saved,
thus forcing regeneration.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f78a5653ae1c0fe3931c4102ce32f640c80db158
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 15:52:20 2009 -0600
Only caching saved resources when the main save works
This way you don't have data cached that couldn't be
saved to the main repository.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 54344591fde1a280f38032731e0ccb19521f6611
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jan 23 14:14:44 2009 -0600
Moving classfile-writing to the Catalog
This work was done by the Agent class before,
but it's really related to the catalog, so that's
where it is now.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e65d7f11dd95ab5432adefeabc3179e9eb5dd050
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jan 22 16:51:02 2009 -0600
Refactoring how the Facter integration works
I moved all of the extra Fact modifications into the Facts
class, and then moved the calls of those new methods
into the Facter terminus.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6b4e5f49a8d1d062aefae31a923cff9e3f0d31ba
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jan 22 16:29:33 2009 -0600
Reformatting tests for facts
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 54faf7825bbffc5a4ca252389305dd23ae8d2d84
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jan 22 16:05:43 2009 -0600
Moving fact and plugin handling into modules
This doesn't change functionality, it just simplifies
the agent class.
I've also started the work to get the catalog handling
done using REST/the Indirector.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 9d76b70c07c86f0041a0e6a1537227de1b619017
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 18:19:22 2009 -0600
Removing the Agent code that added client-side facts
It's now moved to the Facter indirector terminus.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a5c2d7acde8a3af94a9674c32f6ee4ef94288d17
Author: Luke Kanies <luke at madstop.com>
Date: Fri Dec 19 12:34:29 2008 -0600
Adding Puppet client facts to Facter facts.
This work was previously done in the Master client
class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b99c6b554d935c3dddf5c2e6968333865ff46505
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 18:10:45 2009 -0600
Clarifying how node names are used during catalog compilation
We now use any passed in node (used by bin/puppet), then any
authenticated node info (e.g., the cert name), then any
passed in information (usually the host name).
The third option will never be used in Puppet's architecture,
but simplifies using the API for other users.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8b44d6fd7c73071afc4a78abcbd50b9f5d487ce5
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 17:57:48 2009 -0600
Reformatting Indirector catalog compiler tests
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e770e7add31dfb41c7e7abddc07a62d5207dbec0
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 17:37:38 2009 -0600
Removing ConfigStore code that was never actually used.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 37692e5851dd3f7b15bde1caf785fb7801c97a25
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 17:25:50 2009 -0600
Renmaing Puppet::Network::Client::Master to Puppet::Agent
Made minor changes, including removing the parent class.
The functionality hasn't changed yet -- that comes in later patches --
but all but a couple of the older tests pass.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 15d8768c5050a0c409b88fcabe38e05f30ee9a78
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 16:41:41 2009 -0600
Revert "Adding the first bits of an Agent class."
This reverts commit bbd99cc87a775732f2fed3686962647a5c30c5b8.
commit 63fb51406135c87f90bc693c55a935439070a572
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 16:38:44 2009 -0600
Revert "This is work that I've decided not to keep"
This reverts commit f57a5e88229578747dde2c90af3a696ad0172e72.
commit 8f5cbc349daa868020b009851ee97ea3f29fcfbf
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 19 16:29:17 2009 -0600
This is work that I've decided not to keep
so I'm just applying it here so it continues to show
up in the history in case I ever want to look at it again.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 25b28c58c22bae718794dc679f10c61665af0b15
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 15 23:05:45 2008 -0500
Adding a new Agent::Downloader class for downloading files.
This will handling downloading facts and plugins.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1afb8216f166dc375dec5778890985a6635aa54f
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 15 21:34:33 2008 -0500
Adding the first bits of an Agent class.
This class replaces the existing, all-knowing Client::Master class,
and it will hopefully be more reasonable in scope.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2afff60abe430dc1e2660fa82807e131e1dc71aa
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 15 19:01:12 2008 -0500
Adding support for skipping cached indirection instances.
This will allow the soon-to-be-created Agent class to
skip cached catalogs when desired.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 361db45875768727d3c5f310c76850f350e6441f
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jan 25 20:54:01 2009 +0100
Change the way the tags and params are handled in rails
The rationale behind this patch is that it takes a lots of time
to let rails unserialize the ParamValue and ResourceTag object
on each compilation, just to throw them away the second after.
The idea is to fetch directly (and batched host per host) the
parameters and tags from the database and then returns them as
hash.
This allows the no-modification case to takes at least 2 times
less than before.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 62cdeaaee7f7a878b6ca2db85fe34187d2c6c1ba
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sun Jan 25 20:50:28 2009 +0100
Add methods to return hash instead of objects to params and tags
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 3acea41bb879c314d16413339beb8c9cf5705c1e
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Thu Jan 29 20:17:33 2009 +0100
Rails serialization module to help serialize/unserialize some Puppet Objects
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 10bf15103874b75775bdfe573029caf8a38468d0
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 12:39:09 2009 -0600
Fixing #1913 - 'undef' resource values do not get copied to the db
There are unfortunately no tests for this patch; the Rails
code is disappointingly low on tests as it is, and it would
have been essentially an herculian effort add all of the necessary
tests just to make sure this worked.
I've verified it works in practice, which should be sufficient for now.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 500ea2020f95f8e96663f4a56d43be62819ef929
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 28 12:26:03 2009 -0600
Fixing #1914 - 'undef' relationship metaparameters do not stack
This allows you to specify that a metaparameter is undef
inside a definition and keep any parameters from being
inherited from the parent.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 140786570176f5fcd8774f83fbf0bf4087a2cc32
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Feb 1 11:05:48 2009 +1100
Revert "Fixed #1916 - Added environment option to puppetd"
This reverts commit 8d0086b3cb877765857b7ff0dee454b14417430a.
commit 8d0086b3cb877765857b7ff0dee454b14417430a
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 31 12:33:57 2009 +1100
Fixed #1916 - Added environment option to puppetd
commit a065aeb567896be04ebac978a380e6becf4518eb
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 31 12:27:39 2009 +1100
Fixed #1910 - Updated logcheck regex
commit fa9dc73811f26ed70c412cb264413fbedf0fef55
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 27 19:28:56 2009 +1100
Typo fix
commit 7c8094c70490e134dcac2fd772de36e5312e8388
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jan 23 09:46:18 2009 +1100
Fixed #1879 - Added to tidy documentation
commit f40a6b1dc5feca966899a112c892f2b4de596bd3
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jan 22 13:47:13 2009 +1100
Fixed #1881 - Added md5lite explanation
commit 6af317948e52e7c933d774ab5aab4ae092aa17ff
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jan 22 13:30:08 2009 +1100
Fixed #1877 - Tidy type reference update for use of 0
commit a5b0a75e3b486212507250ee605b7dcd1743035d
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jan 22 10:58:34 2009 +1100
Fix autotest on win32
commit 234a035b97287d8910ca00a58b70a06775818693
Author: Paul Lathrop <paul at tertiusfamily.net>
Date: Thu Jan 15 09:35:47 2009 -0800
Fix #1560
Adds an rspec test which demonstrates #1560 and a custom 'process'
method for the aliases provider to fix it.
The default processing uses split() to break the line into records on
the separator, which breaks if records can contain the separator. The
custom method I've added uses a 'limited' split() to break the line on
the first separator only.
This commit fixes #1560
Signed-off-by: Paul Lathrop <paul at tertiusfamily.net>
commit fb8f8cd14f2a4958505f27910ad1d2a368bb0967
Author: James Turnbull <james at lovedthanlost.net>
Date: Thu Jan 22 10:39:49 2009 +1100
In order for ReST formatting to work properly, newlines and
indentation of doc strings must be retained.
Signed-off-by: Thomas Bellman <bellman at nsc.liu.se>
commit 69432d6f1dda6a59a015bcd30a729524e3655fd3
Author: Francois Deppierraz <francois.deppierraz at camptocamp.com>
Date: Fri Nov 28 15:12:30 2008 +0100
Fix Bug #1629
A refactoring of ssh_authorized_key parsed provider was needed and tests
were improved. flush method has been split for clarity.
commit 1f6dce51a9cf7c423e94fd02f54322217d415a77
Author: Bryan Kearney <bkearney at redhat.com>
Date: Mon Jan 5 11:11:16 2009 -0500
Fix #1835 : Add whitespace/quote parsing to
commit 8142981571b438d4fe19f4097fe331378a322b33
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Jan 3 14:17:42 2009 +0100
Fix #1847 - Force re-examination of all files to generate correct indices
This bug is in fact a RDoc issue. The work-around is to always force
a full parse scan and not only what has changed.
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 16ff58b7fbb12ab1b927414823c387c7e04fad08
Merge: d2d3de5884a66f529101854a42ac52be83cde446 3b8a77dfd97774c21156efb1553f3a5a0372c7fa
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 30 18:23:40 2008 -0600
Merge commit 'masterzen/tickets/1834'
commit d2d3de5884a66f529101854a42ac52be83cde446
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Dec 19 17:38:50 2008 +0100
Fix #1829 - Add puppet function versioncmp to compare versions
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit bdee116d08e9ed9c5efcf94a92709c061a8b43c2
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Dec 19 15:05:29 2008 +0100
Fix #1828 - Scope.number? wasn't strict enough and could produce wrong results
Some invalid numbers were treated as numbers and conversion to Integer
was failing returning 0 (for instance 0.24.7).
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit d69abfeaade452845924a0d4446dc1ea85637fc7
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Fri Dec 19 17:35:08 2008 +0100
Fix #1807 - make Puppet::Util::Package.versioncmp a module function
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 4c648bb1e7428806550f57160f72892709b0a30f
Merge: 34335b7a2e6950d4bb3dcaaf2bfe88cbc684007e 7403330c4f63c290ba3cc5992706a3f0b1c9caa0
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Dec 27 12:43:52 2008 +1100
Merge branch '0.24.x'
Conflicts:
CHANGELOG
commit 34335b7a2e6950d4bb3dcaaf2bfe88cbc684007e
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Dec 27 11:58:05 2008 +1100
Fixed #1840 - Bug fixes and improvements for Emacs puppet-mode.el
commit 3b8a77dfd97774c21156efb1553f3a5a0372c7fa
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Dec 20 15:30:22 2008 +0100
Fix #1834 part2 - Fix tests when no rails
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit b6e34b7bc8af737927645e405032ab9694456097
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Dec 20 15:29:58 2008 +0100
Fix #1834 part1 - Fix tempfile failing tests
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 566bf7820e56b3be503a05645cad54152309b20f
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 18 18:06:45 2008 -0600
Fixing #1729 - puppetmasterd can now read certs at startup
The main aspect of this solution is to create a site-wide
Puppet::SSL::Host instance to cache ssl key and certificate,
so that by the time we've switched UIDs, we've got the key and
cert in memory. Then webrick just uses that, rather than creating
a new Host instance.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0cf9decfeab5a45f8457af2e51633fd6e0f877fc
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 18 11:08:34 2008 -0600
Canonicalizing Setting section names to symbols.
I thought I was already using symbols everywhere so
it didn't matter, but there are a few places (e.g., the
process name) where they were strings, and that made things
not work so much.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0fc067449a5e6f4941e2dfe232383b94f163b110
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 18 10:57:59 2008 -0600
Fixing all of the test/ tests I broke in previous dev.
Most of these are straightforward changes to the tests,
but a couple required small refactorings (e.g., References
can now be created with Puppet::Type instances, and they
know how to extract the type/title from them).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e4ba3db1963081eacc2aef3d865f777b427ef23c
Author: Luke Kanies <luke at madstop.com>
Date: Wed Dec 17 18:29:58 2008 -0600
Deprecating the Puppet::Type.create.
This method is no longer necessary; you can use the
normal 'new' class method.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b6db54585177f277b1e06bebd4d925d5c272b610
Author: Luke Kanies <luke at madstop.com>
Date: Wed Dec 17 18:10:30 2008 -0600
Deprecating 'Puppet.type'; replacing all instances with Puppet::Type.type
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 89c25ad0661fbc1d57830f4648a3b108f4347278
Author: Luke Kanies <luke at madstop.com>
Date: Wed Dec 17 18:05:58 2008 -0600
Finishing the work to use Puppet::Resource instead of TransObject
This was a complicated project because TransObject had made its
way into too many classes. The usage by Util::Settings
was particularly nefarious. Refactoring and fixing this
exposed some other issues.
The main complication, though, was the extent to which the
Puppet::Type class depended on TransObject.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1c7f8f685d3beec267f7e45e7d1217d7db770082
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 16 17:56:53 2008 -0600
Adding name/namevar abstraction to Puppet::Resource.
This hopefully provides a single place to manage this
complexity, and I'll be using it to simplify Puppet::Type.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e601babb9266258f55580fcf2a91ea5ca4c5d368
Author: Luke Kanies <luke at madstop.com>
Date: Mon Dec 15 11:03:21 2008 -0600
Supporting a nil expirer on cacher objects.
This works for those classes like Puppet::Type that use an expirer that isn't
always present (they use their catalog as an expirer).
The behaviour is now that if there is no expirer, expire() is a no-op and all
data is considered expired all the time, so it's always fresh.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f69ac9fdb916787530fb70f00006fa64952a8d45
Author: Luke Kanies <luke at madstop.com>
Date: Fri Dec 12 18:18:39 2008 -0600
Setting resource defaults immediately.
This makes it easier for later parameters to depend on the values
of earlier parameters.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 352d7be1a2d3ec6a5930aa4c19c5451e63fdab2e
Author: Luke Kanies <luke at madstop.com>
Date: Fri Dec 12 17:55:54 2008 -0600
Refactoring the Settings class to use Puppet::Resource
It also now uses the Catalog instead of the recursive
TransObject stuff.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 91ff7c1f9c591936b0d39349baf0d1602a69923b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 11 17:59:41 2008 -0600
TransObject is nearly deprecated now.
This is all of the plumbing work, the only real thing
left to do is to fix the Settings class so that it
uses Puppet::Resource instances instead of TransObject
and TransBucket.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fae30756e48184dfc8238dcfe80b843f981b6070
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 11 12:31:01 2008 -0600
Simplifying the initialization interface for References
You previously had to call new(nil, "Foo[bar]") if you
just had the resource reference as a string. Now
you can call new("Foo[bar]"), but the old behaviour
works, too.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 14c3c54ee1976e1c76acfe62554bb1786da6427b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 11 12:13:41 2008 -0600
Replacing TransObject usage with Puppet::Resource
This completely reorganizes how RAL resources are
initialized, and in the process I was able to remove a lot
of code (I removed other apparently obsolete code at
the same time).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 60062e4b9ae479ddbf97f4fc3495d04bc00196d5
Author: Luke Kanies <luke at madstop.com>
Date: Thu Dec 11 08:24:43 2008 -0600
Renaming the "Catalog#to_type" method to "Catalog#to_ral"
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6b14000ae54a11da3fa16c1b4685f630abca869b
Author: Luke Kanies <luke at madstop.com>
Date: Wed Dec 10 15:39:27 2008 -0600
Using Puppet::Resource to convert parser resources to RAL resources
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e3b1590f57a18b89c5f97ca0aa8e8d2bd9187b58
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 17:02:29 2008 -0600
Adding resource convertion to the parser resources
Also uses Puppet::Resource's method for creating
transportable resources.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c306a1744793420337421f6fdf3630a9121861bd
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 16:56:39 2008 -0600
Adding equality testing to Puppet::Resource::Reference
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 48a994998d3087f82c0c3175a39d2bb812e8f94f
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 16:00:47 2008 -0600
Correcting whitespace and nested describes in Puppet::Resource::Catalog
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d48fff6658535ca1781443aba9ab21893c13e55c
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 15:33:28 2008 -0600
Renaming Puppet::Node::Catalog to Puppet::Resource::Catalog
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c927ce05bbd96fa9aacc8e52f8eb797403a1e433
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 15:30:11 2008 -0600
Renaming Puppet::ResourceReference to Puppet::Resource::Reference
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e88746b48cfd4ce7cd9acd0baf61d9b660b460e9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Dec 8 18:02:21 2008 -0600
Adding Trans{Object,Bucket} backward compatibility to Puppet::Resource
This is further progress toward #1808.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 832198f56cfabc7a6ab1a97b99f61e278c16bc8b
Author: Luke Kanies <luke at madstop.com>
Date: Mon Dec 8 17:26:39 2008 -0600
Starting on #1808 - Added a base resource class.
This class borrows heavily from the Puppet::Parser::Resource class
and from Puppet::TransObject, partially because it will hopefully eventually
supplant both of them.
The class isn't used at all yet; now we need to go through the codebase
and remove everything related to TransObject.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 820ff2e99fd4ca58b173ce05b1aa09b0efe69f91
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 15:15:06 2008 -0600
Removing the "clear" from the macauthorization tests
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 71b8befa424c6c82a10a5cc7d7ea50331851c7e9
Merge: 89e9ef7521f5d62f1eb65514fe8923d0456e6184 e5c36fd865a5699c867e68a23153ec40da919e33
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 9 15:10:09 2008 -0600
Merge branch '0.24.x'
Conflicts:
CHANGELOG
lib/puppet/type/tidy.rb
spec/unit/type/file/ensure.rb
spec/unit/type/tidy.rb
commit 89e9ef7521f5d62f1eb65514fe8923d0456e6184
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Mon Dec 8 20:04:33 2008 +0100
Fix #1483 - protect report terminus_class when testing for REST
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 435f1e9b52e11bc558405f2102c61db84fea03c2
Author: Brice Figureau <brice-puppet at daysofwonder.com>
Date: Sat Dec 6 16:53:03 2008 +0100
Fix #1483 - use REST to transmit reports over the wire
Signed-off-by: Brice Figureau <brice-puppet at daysofwonder.com>
commit 6b30171435583b1a69c4ffe7b8b1760f5585cd38
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 2 22:28:22 2008 -0600
Fixing all broken tests. Most of them were broken by fileserving changes.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 99a9b5a045af6f1c68619792a45603cbe450652d
Merge: f73e13e7464edab73443857d628602b89361c220 278bfe83015312292360f727d6532a143610db0d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Dec 2 16:26:54 2008 -0600
Merge branch '0.24.x'
Conflicts:
bin/puppetca
lib/puppet/type/group.rb
lib/puppet/type/tidy.rb
lib/puppet/util/settings.rb
Also edited the following files so tests will pass:
lib/puppet/type/component.rb
spec/unit/ssl/certificate_request.rb
spec/unit/type/computer.rb
spec/unit/type/mcx.rb
spec/unit/type/resources.rb
spec/unit/util/settings.rb
spec/unit/util/storage.rb
test/ral/type/zone.rb
commit f73e13e7464edab73443857d628602b89361c220
Author: Luke Kanies <luke at madstop.com>
Date: Sat Nov 15 22:29:36 2008 -0600
Adding more file tests and fixing conflicting tests
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cc1297031db9b8d3657fb354c7115a7b079a339f
Author: Luke Kanies <luke at madstop.com>
Date: Sat Nov 15 02:16:57 2008 -0600
Completely refactoring the tidy type.
This was necessary because of how I changed file recursion.
The type works much more intelligently now -- files to
be removed have a file resource generated for them, and that
resource handles deletion.
Also fixes #1717; neither age nor size is required now.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 720dcbe090a7cdfa9d74be64c382431f09be0e35
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 14 19:29:08 2008 -0600
Cleaning up the tidy type a bit
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 053d7bfa678b152c42bf3fcbccaaa86aa578c39b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 14 19:27:50 2008 -0600
These changes are all about making sure file data is expired when appropriate.
All file tests now pass.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a8d9976d0a11c4dc50b2ef49c63f3f745cb4eccb
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 14 19:15:37 2008 -0600
Catalogs always consider resource data to be expired if not mid-transaction.
This way we'll cache when in a transaction, but otherwise always
hit the disk so the data is fresh. This works because we
really only use resources mid-transaction, but it behaves correctly
if we happen to use a resource outside of a transaction.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8b0843913c4c4ef063c3f1fb1fec674406bc193d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 13:58:55 2008 -0800
Properly cleaning up ssl ca configuration during testing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 73fa3977d7274f1c54c89971c0389f9a9f980c9a
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 13:31:31 2008 -0800
Adding caching support to parameters, and using cached attributes for file source and metadata.
As hoped, this drastically simplifies the code around retaining
this data.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0ecbf79faf8e69efda96f8611837cd1c395f7a7c
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 13:12:21 2008 -0800
Adding cached attribute support to resources.
The Catalog is the expirer, which means that a resource
with no catalog will not cache data.
Also switching files to use a cached attribute for its stat.
And modifying catalogs to expire data at the end of every
transaction.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 29b97943e7efaad3cb3f8e7b82004c067d3fbf82
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 13:01:14 2008 -0800
Allowing a nil expirer for caching classes.
If there's no expirer, then the value is regenerated every
time.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cd09d6b90d3365d06e8e706aab3edbd8f568f1c9
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 12:45:50 2008 -0800
Refactoring the Cacher interface to always require attribute declaration.
Previously you could dynamically use cached values, but the new interface
requires a single static declaration of the attribute:
cached_attr(:myattr) { my_init_code() }
This is cleaner, because it makes it easy to turn the code into an init method
and generally makes the whole thing easier to think about.
Most of this commit is going through the different classes that already using the
Caching engine.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 14af971bc618d665f481142934b2f612d503823c
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 11 10:47:32 2008 -0600
Changing the Cacher.invalidate method to Cacher.expire.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 99a0770a30c7c9a1349fd693cda31bdbf2717864
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 10 16:00:38 2008 -0600
Fixing a critical bug in the Cacher module.
Basically, the first generated value was always
considered expired the next time it was asked for.
The fix was to create an initial timestamp in the Cacher
module, thus providing a floor for validity.
This is definitely a murky bug, and is especially hard to
test.
Also refactoring the internals just a bit.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit fe0b818c411344da894dc8d26787db8602f68c7a
Author: Luke Kanies <luke at madstop.com>
Date: Sat Nov 8 12:52:52 2008 -0600
Fixing tests broken by fileserving and other refactoring.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit eed37f7133a33577d1ebc8441db6090fb4c0b7f8
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 7 16:59:13 2008 -0600
Fixing a test broken by previous refactoring
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 45c6382e99c3e4c4c9bc85fef35a4114b1d1fb46
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 7 16:55:00 2008 -0600
Finishing the refactoring of the resource generation interface.
All of the code works, and there are integration tests all around
to prove it. I think.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 084071936738f25930bc99bb2e62c2a52259e915
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 7 16:10:52 2008 -0600
Refactoring and clarifying the resource generation methods.
It now works with the new Catalog#add_resource method.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cc046460e36eb6273a4f08de2167de25098d20cb
Author: Luke Kanies <luke at madstop.com>
Date: Fri Nov 7 12:48:37 2008 -0600
Refactoring Catalog#add_resource to correctly handle implicit resources.
It now ignores or removes implicit resources that conflict,
and it yields all resources that are valid.
This makes it simple for calling classes to pass in a list
of resources but only perform a chunk of work for valid (i.e.,
non-conflicting) resources.
This refactor is entirely meant as a way of cleaning up the
Transaction#generate interface to the catalog.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a73cad9c8fabb8314e87753a3f73cf96fd4dc560
Author: Luke Kanies <luke at madstop.com>
Date: Thu Nov 6 14:25:37 2008 -0600
Adding SimpleGraph#leaves, which I apparently did not migrate from PGraph
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2a685f9194c5eb98b67f9759a90a8a193983c467
Author: Luke Kanies <luke at madstop.com>
Date: Thu Nov 6 12:40:40 2008 -0600
Removing mention of obsolete edgelist_class from GRATR.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7e20f06136f524187f64269e39cb95a0a81d4100
Author: Luke Kanies <luke at madstop.com>
Date: Thu Nov 6 12:39:40 2008 -0600
Changing the catalog's relationship graph into a normal graph.
It was previously another catalog instance, but I was only
ever actually using the graphing abilities.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2ba03364309c2347ba4e5bf7dd815beef7563b7b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Nov 6 12:14:05 2008 -0600
Removing the PGraph class and subsuming it into SimpleGraph.
This class is a holdover from when I was using GRATR, and it's
obsolete now.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e92c1cc724c489d9328567dfa082221a67184c92
Author: Luke Kanies <luke at madstop.com>
Date: Thu Nov 6 11:55:34 2008 -0600
Moving Catalog#write_graph to SimpleGraph, where it belongs.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0149e2e125fc09bb5a8c1ff206cd46e06c0593cd
Author: Luke Kanies <luke at madstop.com>
Date: Wed Nov 5 23:04:33 2008 -0600
Converting the file 'source' property to a parameter.
This makes a lot of sense because source was always
more of a metaparameter than a property -- it affected
the 'should' values of other properties, but it shouldn't
have done any other work.
It will hopefully make everything else much cleaner.
This is such a large commit mostly because of the need
to fix a lot of tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 35c623e65b44fed098374288e8c1dfc450a1f9f7
Author: Luke Kanies <luke at madstop.com>
Date: Wed Nov 5 21:44:42 2008 -0600
Removing mid-transaction resources from the catalog.
This basically just cleans up dynamic resources.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f4800e8aeb6196aebc43d36f69b2e2a182d1bf5c
Author: Luke Kanies <luke at madstop.com>
Date: Wed Nov 5 17:49:36 2008 -0600
Adding a method to Checksums to extract the sum type
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 44fadd1847e477b713ab2d0de5633ae446a3642e
Author: Luke Kanies <luke at madstop.com>
Date: Wed Nov 5 17:25:23 2008 -0600
Aliasing "must_not" just like we alias "must"
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a9dbb5de66c9a97d13f7e7ade47bb6c3b5fa2e66
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 4 17:22:27 2008 -0600
Deduplicating slashes in the fileserving code
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bb6619a74866605a07869f9467273d6e2e389dab
Author: Luke Kanies <luke at madstop.com>
Date: Tue Nov 4 17:15:45 2008 -0600
Fixing the augeas type tests to work when augeas is missing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e7288733760fe8ad31aba10dd047d31470d10b52
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 15:44:07 2008 -0500
Reducing the number of calls to terminus() to reduce interference with caching
Signed-off-by: Luke Kanies <luke at madstop.com>
commit aa8d09149c167f1b2f1a714b2e55c89a4d9ac246
Author: Luke Kanies <luke at madstop.com>
Date: Wed Oct 29 23:11:52 2008 -0500
Switched all value management in props/params to internal classes.
This is a significant refactor of some very murky code, and it's
all much cleaner and more readable now. All of the 'newvalue' methods
and any value-related code is in a ValueCollection class.
This puts us in a good position to refactor the Property and Parameter
classes more completely.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e5b503380c4be79bf7e8f7836867ed7f491dd25e
Author: Luke Kanies <luke at madstop.com>
Date: Wed Oct 29 12:09:58 2008 -0500
Fixing #1677 - fixing the selinux tests in master.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 77d73e0230e466182c13a600a6c5cf8de67654e7
Author: Luke Kanies <luke at madstop.com>
Date: Tue Oct 28 19:40:32 2008 -0500
Changing the meaning of the unused Puppet::Type#parameter method to return an instance
rather than a value.
This parallels and largely obviates the 'property' method.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 05e1325891b2ab22088dcd34dd54e4afcbf59ddb
Author: Luke Kanies <luke at madstop.com>
Date: Tue Oct 28 18:09:55 2008 -0500
Moving a file purging test to rspec
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6f7ccff8bb764dffd1d41d5391dd79f7bd4a387c
Author: Luke Kanies <luke at madstop.com>
Date: Tue Oct 28 17:50:20 2008 -0500
Fixing #1641 - file recursion now only passes original parameters to child resources.
Previously, parameter values provided by remote sources or default values
were all passed to children, which provided strange state maintenance.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a4d4444ba216cb3627e03bb45e2eb92424740a44
Author: Luke Kanies <luke at madstop.com>
Date: Mon Oct 27 17:21:21 2008 -0500
Removing obsolete methods and tests:
Removing obsolete handleignore method
Removing obsolete FileSource class
Removing a now-obsolete test/unit test
Removing a now-obsolete recursive filebucket test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b4f4866b452cad870e635a8c97e265bd47e3f5ff
Author: Luke Kanies <luke at madstop.com>
Date: Mon Oct 27 12:10:36 2008 -0500
Making it so (once again) files with sources set can still be deleted
(which I think is kinda stupid, but apparently people want it).
Signed-off-by: Luke Kanies <luke at madstop.com>
commit caf15c27b84f2777d68e569cea11ef9534c44ed4
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 16:19:41 2008 -0500
Fixing and migrating more file tests.
This is an unfortunately messy commit; I should have tried harder
to separate the different tasks into different commits, but it's
not worth going back and doing now.
This is the first commit in the long road of fixing the existing file
tests, and in the process refactoring and better testing the code.
The refactoring in this commit is mostly around the 'stat' instance
variable that tests whether the file exists (and provides its metadata
if it does) and the 'insync?' method in the source property.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cccd83853883a84a31f22446e9d3be8501655739
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 16:19:01 2008 -0500
Adding a starting point for spec tests for tidy.
So far it just validates that lstat is used instead of stat.
Signed-off-by: Luke Kanies <luke at madstop.com>
Conflicts:
spec/unit/type/tidy.rb
commit 255c9fbcc00c4f2bb2252b9eadff195a1feb77f4
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 3 22:15:09 2008 -0600
Setting puppetmasterd up to serve all indirected classes.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7fdf2bb23fbc5a3cb2468fb6b980eaf556d29c64
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 3 22:05:20 2008 -0600
Retrieving the CA certificate before the client certificate.
We have to have a CA cert first, because the host will
start using the client cert as soon as it's available,
but it's not functional without a CA cert.
Also removing extra stupid stuff from wait_for_cert --
the connection is now always recycled, which is much simpler.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a00c1f2bb508d711c5fa0dd4bda98b7a747140aa
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 3 21:41:30 2008 -0600
Handling the case where a symbol (e.g., :ca) is used for a certificate name.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cf3a11cb641c6317f61d0f596bc8a137aa4adbca
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 3 21:39:58 2008 -0600
Fixing :bindaddress setting to work with the new server subsystem.
It now automatically switches values depending on server type,
while still allowing overriding.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a78c971829959d9d4b89aa841249fc973b8972b2
Author: Luke Kanies <luke at madstop.com>
Date: Mon Nov 3 21:39:13 2008 -0600
Fixing CertificateRequest#save to accept arguments.
This happens when called over REST.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e70c1a067a801443719bfabb26aa0a2690b02838
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 16:10:45 2008 -0500
Fixing forward-compatibility issues resulting from no global resources
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4596d2d80e76594589a42e3a89ba88b5dbe6f1c9
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 16:05:18 2008 -0500
Fixing a test I broke when fixing a reporting bug
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e76cac7df102389b7ee487be4031caf0e7e2ab04
Merge: 801b8a643d353176675023adaa25f26d0ec67403 f0635179b60f5cf30d1f7070f4c3c998ad5131c0
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 31 16:01:28 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
commit 801b8a643d353176675023adaa25f26d0ec67403
Merge: 9742c26310e6b30095651cb4e224c681603af1ff b2c1149b5f374df77ad3e017749f22f6981a453f
Author: Luke Kanies <luke at madstop.com>
Date: Wed Oct 22 18:30:57 2008 -0500
Merge branch '0.24.x'
Conflicts:
lib/puppet/type/user.rb
commit 9742c26310e6b30095651cb4e224c681603af1ff
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 17 09:14:43 2008 -0500
Fixing resource aliasing to not use global resource aliasing.
I'm not really sure why the 0.24.x-style code got merged in,
since master's changes should be more recent.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8aee40de69e6fe8d67ab58a2e223443b15820584
Merge: 1b517d2fb048603bd1743a662bde74e8ae4b13dc a74ec60d33dee1c592ec858faeccc23d7a7b79f3
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 17 09:01:04 2008 -0500
Merge branch '0.24.x' Removed the 'after' blocks that call Type.clear,
since that method is deprecated.
Conflicts:
CHANGELOG
bin/puppetca
lib/puppet/file_serving/fileset.rb
lib/puppet/network/xmlrpc/client.rb
lib/puppet/type/file/selcontext.rb
spec/unit/file_serving/metadata.rb
spec/unit/type/file.rb
commit 1b517d2fb048603bd1743a662bde74e8ae4b13dc
Author: Luke Kanies <luke at madstop.com>
Date: Wed Oct 15 19:47:02 2008 -0500
Adding comments to Puppet::Util::Cacher
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7a6d9b1ba93966c914f5ca9bde239ef0cdbfd15c
Author: Luke Kanies <luke at madstop.com>
Date: Fri Oct 3 15:37:31 2008 -0500
Removing obselete code from the file type.
Also shows that #674 is fixed.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1b512a9a41663d2d2983e91c7a77442049f0b505
Author: Brett Lentz <wakko666 at gmail.com>
Date: Thu Jul 24 18:13:14 2008 -0700
Merged fsweetser's selinux patch against HEAD
commit bb23861e334e617b544c11bc75a35c40b36185a2
Merge: e31df2f7f5e98c524b68cd724cfaa3e308e7b9a1 ac5db5ec115455e54090542870847820357739a2
Author: Luke Kanies <luke at madstop.com>
Date: Tue Sep 23 23:50:43 2008 -0500
Merge branch 'feature/master/1481'
This merges in the new fileserving code -- we're now using
REST to do fileserving, rather than xmlrpc.
Conflicts:
lib/puppet/parameter.rb
lib/puppet/type/file.rb
spec/unit/type/file.rb
commit e31df2f7f5e98c524b68cd724cfaa3e308e7b9a1
Author: Luke Kanies <luke at madstop.com>
Date: Tue Sep 23 22:32:29 2008 -0500
Removing files that git wasn't smart enough to remote during a merge.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4aeabbbb2163684ff7064198c653cd60d46e5717
Merge: 5b9dd01326a61b9ae89ae978e29a8170f76deb5e 8d5ded09b9c9c944695c015e6e95b10ccebd6fb5
Author: Luke Kanies <luke at madstop.com>
Date: Tue Sep 23 22:31:55 2008 -0500
Merge branch '0.24.x'
Conflicts:
lib/puppet/metatype/container.rb
lib/puppet/metatype/instances.rb
lib/puppet/metatype/metaparams.rb
lib/puppet/metatype/relationships.rb
lib/puppet/metatype/schedules.rb
commit ac5db5ec115455e54090542870847820357739a2
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 29 01:40:47 2008 -0700
Removing the old, obsolete recursion methods.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a9b7f0881aed04fbbca59947cab0ffeedda6d2f8
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 29 01:29:20 2008 -0700
As far as I can tell, recursion is working entirely.
W00t!
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b69c50ccd3a491b6c4a8d456af2fe6f9cac45eae
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 29 01:25:17 2008 -0700
Removing insanely stupid default property behaviour.
Basically, I had the [] method on resources returning
the 'should' value if one was available, but if one wasn't
available, it would retrieve the current value from the resource.
This resulted in all kinds of completely ridiculous behaviours.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 45f465bc98aa87e1066a9d748dbb6bfaaef61476
Author: Luke Kanies <luke at madstop.com>
Date: Fri Aug 29 00:48:40 2008 -0700
Source recursion is nearly working.
It works, but you have to run it multiple times,
and there are still a couple of strangenesses with the
parameter values, such as the mode not getting set on
the first run.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 93fc1139550bd97a11529b812e77ac0fc00c6079
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 28 23:28:22 2008 -0700
Files now use the Indirector to recurse locally.
I don't yet have integration tests for remote recursion
or link recursion, but we're nearly there.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bd1163a339ff66dbb9a50a1cb13f6320cb056cc3
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 28 23:09:52 2008 -0700
Fixing filesets to allow nil ignore values.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5da26067cc76ad318359d9287ab1267d7a6c5b0b
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 28 22:48:01 2008 -0700
Recursion using REST seems to almost work.
I think this is the bulk of the work, I just
need to write some integration tests to hunt down
a couple of small issues.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ee1a85d61bb6ee9b31ae4881adc0c136a99e42ed
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 27 23:27:22 2008 -0700
Mostly finishing refactoring file recursion to use REST.
We have the majority of the work done (and it's a *lot* less
code). We just have six more tests we need to implement the code
for.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 7c68fdb46802dbd3a57f5f7be3333ed6feacad45
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 27 21:53:00 2008 -0700
Fixing FileServing::Base so that it can recurse on a single file.
It was throwing exceptions if you tried to use it on a file
instead of a directory.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit ac419872e273dc31635f042bb1a23c7785dc227a
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 26 23:29:04 2008 -0700
Fixing the terminus helper so it correctly catches options passed from clients via REST.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit be4c0e7fbe5e652ec1d49eab2fdc7a5fbbc486f3
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 26 23:12:03 2008 -0700
The file source is now refactored and uses REST.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 44c6a529d0a84d844b21f96d64de674487238f53
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 26 23:11:39 2008 -0700
Removing mention of an obselete class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 82714246b913087292f04190e03a885c99723f52
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 26 22:06:02 2008 -0700
One third done refactoring file[:source] -- retrieve() is done.
It now uses the FileServing::Metadata indirection and
is about 100x cleaner to boot.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 98ac24a9e155b1d3c2358da3e94610071b0e3cfb
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 25 21:50:13 2008 -0700
Adding a "source" attribute to fileserving instances.
This will be used to cache the source that was used
to retrieve the instance.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6e43c2d1179aed5ae92111afee1d3b868cf5f0a2
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 25 21:31:37 2008 -0700
Aliasing RSpec's :should method to :must.
This allows us to still use the method in the RAL,
where 'should' is already taken.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8b45d13ab28837caf3bb09cc1c90ab61974bf4db
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 25 18:00:42 2008 -0700
Adding automatic attribute collection to the new fileserving code.
Basically, this just includes a consistent method for collecting
info (either content or metadata) and then calls that method
when returning instances via the indirector.
It's such a large commit mostly because of small changes in the normal
code and large changes in the testing to accomodate those small changes.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6ed8dfaf7c0cf091dca0374de310f524b0a033cc
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 25 17:43:35 2008 -0500
Adding the content writer to the content class.
Also choosing a fully qualified fake name when creating
content instances from raw content.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 92e144b3051ebd177c034e692a59162b3902e128
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 25 17:35:28 2008 -0500
Fixing a test in the module_files terminus
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 151a54ff7ac69aa2fa1708188ad75e444158e8a2
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 21:17:15 2008 -0500
Causing format selection to fail intelligently if no suitable format can be picked.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit deda6465f50b582f3b8c77204965db331ba81faa
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 21:00:55 2008 -0500
Removing the last vestiges of the 'puppetmounts' protocol marker.
I created this when I first designed the fileserving
Indirection hooks, and it's unnecessary.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 30dea6839b0360e2fabbeb833e6c2b8658d3f53c
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 20:54:47 2008 -0500
Adding a 'plural?' method to the Indirection::Request class.
I'm in the process of creating a new service for handling
all of the http calls, including generation of the RESTian
URL. This service obviously needs to know whether the url should
be plural or singular, and the request knows the method in use,
so it can easily answer the question.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 40e76fb83ef466425fec736abbf1913a6426bf01
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 20:53:25 2008 -0500
Fixing the rest backends for webrick and mongrel so the get the whole request key.
Also adding the Content work necessary to demonstrate that this is actually
required.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8ea25efd90b4d2281db12076cbaab3f766cac8b4
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 14:42:48 2008 -0500
Refactoring how files in FileServing are named.
Previously, they retained some concept of the URI used to
find them, and this uri was the primary key
for the FileServing instances. This key was unfortunately
completely useless, as evidenced by the fact that it was never
used except to test that it worked.
I've modified the FileServing instances (through modifying
the Base class) to use their local path as their key, and they
no longer care about the URI at all.
This commit is mostly about fixing the code that interacts with
the instances to use this new API.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 550e3d6ad5aadfe99fc1e10efa77cc193d3a9df3
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 14:11:48 2008 -0500
Finishing the rename of FileBase => Base.
Git did something really strange, in that it apparently didn't
add the new base.rb files even though I used 'git mv'.
Also fixing some other failing tests I hadn't previously tracked
down because of the magical tuple of autotest's suckiness and
my laziness.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 90e70227b0bb7cfd104ae34de8f7c2b7250edb09
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 14:10:39 2008 -0500
Adding weights to network formats, and sorting them based on the weight.
This way the new hackish RAW format will only ever be used if it's
specifically chosen.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5a195e0c06daa2bfa008cfd94c660e50b9d0ae56
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 13:32:33 2008 -0500
Renaming FileServing::FileBase to FileServing::Base.
Also fixing a set of tests I broke last night. I'm looking
at replacing autotest with rspactor, because my FSEvents hack
to autotest means it's harder for me to rerun autotest.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3101ea23e556081fe38502218034f02aafe0c5bf
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 13:02:16 2008 -0500
Adding a hackish raw format.
As the comment in the file says, we don't really have enough
data to know what a good design would look like, and I think
this format will be a bit of a one-off, so I'm just throwing
up some barriers to keep people from doing silly things with it.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 89a3738d2b0678ae8fb1e7191e01caf6c5ece1f9
Author: Luke Kanies <luke at madstop.com>
Date: Sun Aug 24 12:18:42 2008 -0500
Adding suitability as a requirement for a format being supported.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a0bda8532f5e1e9f5bb29eb92f389383ae0857d5
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 22:00:19 2008 -0500
Removing the yaml conversion code from FileContent.
Also fixing some integration tests that were failing
because of the change to the terminus selection code
for file serving.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6335b143a312481aaa200f71cd25dffd4f88c8ae
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 21:59:14 2008 -0500
Causing the Indirection to fail if a terminus selection hook does not return a value.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1104edb13926a53ee90685d96700cb03eaeca509
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 21:20:21 2008 -0500
Correcting whitespace in a test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2f224c9fc97cf632ee8a551180aaa08e263d77df
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 19:02:43 2008 -0500
Spell-correcting a comment
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bcd40fb58338e44d46452c47c0ef150a96a5f829
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 18:36:03 2008 -0500
Cleaning up an exception.
Only adding option information when options are present.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0a05720e6c4bd0875fc03b53263ff26c6fe14de2
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 18:25:18 2008 -0500
FileServing Configurations now expect unqualified files.
This fits in with the fact that the indirection requests split URIs
and set the request key to an unqualified path rather than
a fully-qualified path.
The whole system is unqualified end-to-end, now, except when you're
specifically asking for a full, local file name.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 237b7b294bf90c87891964d01429bbdd42a92524
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 18:17:08 2008 -0500
Fixing whitespace in docs of some tests.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 91b8252755c78dde752c2e06cf13ab0d757aad42
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 18:16:38 2008 -0500
Fixing the fileserving terminus selection hook.
It now uses the fact that the indirection request does
URI parsing, rather than doing the parsing on its own.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit f5ba99fd24ce2e7cdba7c81153c46df14811d193
Author: Luke Kanies <luke at madstop.com>
Date: Sat Aug 23 18:15:56 2008 -0500
Special-casing 'file' URIs in the indirection requests.
These just get converted to full file paths, since
we know they will never pass over the wire.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a215abaef97ea1fb0187f46c5e6a880ff1d29036
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 21 23:09:27 2008 -0500
Dividing server/port configuration responsibility between the REST terminus and the indirection request.
Previously, the REST terminus did all of the configuration,
but it required rewriting the request key if it was a URI
because you can't have a uri in a uri (i.e., you can't use
http://host/puppet://host/dist/file).
Now the request parses the URI and sets host/port/key/protocol
appropriately, and the REST terminus has its own overrides
and defaults so that subclasses like certificate classes
can provide specific values.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit d1746054b8617271941e7307b2ecee0b61976818
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 21 22:41:01 2008 -0500
Fixing a test that relied on hash ordering.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 5b9dd01326a61b9ae89ae978e29a8170f76deb5e
Merge: 7034882fdfbd3846e77c518e43bdea1f9154e250 b50e718490abe41f09e16e1edc0d8de93aac8bfe
Author: Luke Kanies <luke at madstop.com>
Date: Tue Aug 26 22:40:26 2008 -0700
Merge commit 'turnbull/0.24.x'
commit 7034882fdfbd3846e77c518e43bdea1f9154e250
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 20 23:37:13 2008 -0500
Adding parameter and URL support to the REST terminus.
Previously, the server side correctly pulled parameters out of
the query strings, but the REST terminus never passed them on. It does
now, at least for finding and searching. It appears that at least
WEBrick doesn't support parameters for anything other than forms
and GET.
I've also added the ability for the REST terminus to pull
host/port information from the request key, if it's a URI.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 66c40b374d7315d11575d701ce195ce656abbeb7
Merge: c8190421a351ed327361a5daca82441be39ce834 c5fb092720afefbf904822a5604b5b3520b5c194
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 20 23:45:02 2008 -0500
Merge branch '0.24.x'
commit c8190421a351ed327361a5daca82441be39ce834
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 20 12:57:26 2008 -0500
Fixing the String format (fixes #1522).
The string format no longer provides any support methods,
which means that I had to create to_multiple_s and from_multiple_s
methods on the SSL classes. I created them in the base class
and tested them just in the cert class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 78bc32d0153dd98fadae99dcd71d26fc97210d3c
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 18 21:51:27 2008 -0500
Removing dead-end file work as promised.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a5ab52c628cae7ac9ed5ca1bd5de779944840802
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 18 21:50:59 2008 -0500
Adding files temporarily, since I've decided this work is a dead-end.
I'm merely adding these so that they're in the history if I decided to
look at them again.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4f275b669b0336c6032204bfa9694fa6522eb267
Author: Luke Kanies <luke at madstop.com>
Date: Wed Aug 20 12:11:52 2008 -0500
Fixing #1514 - format tests now work again.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e3971b9751141cd448a8197da024be43581f6dcd
Merge: 025edc5c3737f476119df4bab73ebdc68be19430 2ec4e298c3274abc8eaad4230bca8d39a48d2e35
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 18 11:47:40 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
test/util/posixtest.rb
commit 025edc5c3737f476119df4bab73ebdc68be19430
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 18:41:28 2008 -0700
puppetd now uses the Indirected SSL.
This means it now uses REST for certificate saving
and retrieval, which is awesome.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 62202bf55723096d05a61efefae46ee98a2948dd
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 18:40:30 2008 -0700
Adding 'require' statements as necessary for Puppet::SSL to work.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 86a718856f4ca3c67450159645307b3c542db799
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 18:40:06 2008 -0700
Fixing the SSL::Host#waitforcert method.
It now works the way puppetd needs it to, rather
than the way I thought it would need to work.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a31c578e73ed76903c6382016e46b9d6aef34457
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 18:21:45 2008 -0700
Adding logging when files are removed.
This is currently mostly useful for puppetca.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 09ee814a8203c33c074a09e5a9802adc395ae309
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 18:16:01 2008 -0700
Removing now-obsolete the wait-for-cert module.
This functionality has moved into the SSL::Host class.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit cd314fa0531b0d71017e22b9db4cec2fc21c7e7c
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 17:44:45 2008 -0700
Documenting a bit of a test
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 113d74aaa630f499c8b7989aac6680e22e8e38c8
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 17:39:13 2008 -0700
Certificates now work over REST.
All of the format work is done, they all
support plaintext successfully, and I've got
integration tests that demonstrate that it
actually works.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 2cad30a18c5e0e4fb93603ab422c290a62d45131
Author: Luke Kanies <luke at madstop.com>
Date: Thu Aug 7 17:38:26 2008 -0700
Caching the SSL store for the SSL Host.
We were creating a new SSL store every time, which
caused problems during testing -- it created
an infinite loop when trying to create the
store while looking up the CRL.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 93fd55fdaa409020f18001ac436ddad9b6c491e4
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 4 13:52:55 2008 -0500
Enhancing formatting errors with class and format.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 6c80e0ff6ae5e69bccd46bb2bd6261b78626f01e
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 4 11:01:34 2008 -0500
Making all certificates only support the plaintext format.
None of them actually support yaml or marshal by default,
and plaintext is easiest anyway.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c464bf21676c907642be3ad2c71b941318469325
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 4 11:00:57 2008 -0500
Adding wait_for_cert functionality to the ssl host class.
This essentially deprecates the CertHandler module.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c854dbe416939a930776405a5fa7ac87f84901d8
Author: Luke Kanies <luke at madstop.com>
Date: Mon Aug 4 10:28:10 2008 -0500
Adding a plaintext network format.
Certs don't seem to support yaml, for some reason.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 818599db7dc6210cc015d8888d119726eb6c3323
Author: Marcel Haerry <haerry at puzzle.ch>
Date: Mon Jul 28 16:02:10 2008 +0200
lazy load latest package definitions with yumhelper 2.2
I have to admit that the version 2.1 one of this patch
was not good tested from my side and it simply didn't work.
I'm very sorry for that.
However I did now extensive (manual) testing and it works
the way it should for me.
I can confirm that yumhelper isn't called if there is no
latest ensure and it is called if there is at least one.
So correct commit message:
After discussion on the list, this is the new version for
lazy loading yum latest package versions. It is implemented
mainly in the way that Luke proposed. However it stores
the latest informations in the variable latest_info so
the latest method didn't get too hackish and could nearly be
left like it was before.
+ fixed copy&paste regression, so :latest_info is not anymore
on the class side
+ fixed package iteration and ensure usage.
commit 8457856c0abb58e0521532148b368be1a8b4790e
Author: Luke Kanies <luke at madstop.com>
Date: Thu Jul 31 12:40:06 2008 -0500
Fixing a group test that failed after merging 0.24.x
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c2c8941de5973137d631c1f90f7c07e54cc89e3d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 23:19:08 2008 -0500
Correctly handling when REST searches return nothing.
We return a 404, which the client can correctly handle.
That wasn't the actual problem causing failing tests, of course --
the problem was that one side of our stub was autodetecting
marshal, and the other side was forcing yaml, which strangely didn't
work. It was only happening with searching, though, not finding et al.
The 'search returning nil' problem was a bit of a red herring but
needed to be fixed, too.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 186f3cd34fb7fa3bc1ff683a5178444526259f92
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 22:22:57 2008 -0500
Removing an obsolete method from the rest indirector
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 29d704c3f7d69f04e27aae69f4c1ef9dfc979972
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 22:19:01 2008 -0500
The REST formats are now fully functional, with yaml and marshal support.
This is the last of the REST plumbing. The only flaw right now
is that the formats are managed by name rather than by
mimetype, which I'll fix next.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c55acee2264b126541ea26d49e1994b263568548
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 11:09:07 2008 -0500
Adding some support for case insensivity in format names.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 8033bd4b7398785048cf789698c1b341049c5983
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 11:04:01 2008 -0500
Moving validation from FormatHandler to Format.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 3405841140ad118a500f44b6d35c9977b5eca473
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 30 11:00:15 2008 -0500
Moving functionality out of the FormatHandler into the Format class.
The Format class now takes care of deciding whether it's supported,
and it also does method dispatch to classes and instances as necessary.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 43a6911f656178efb5c2236c8b890127ab0880d3
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 29 19:11:58 2008 -0500
Searching again works over REST, including full content-type translation.
The format management is a bit clunky right now, though, so I
need to fix how they're managed. Some of these tests fail,
but 99% of the remaining work is in other classes so I wanted
this as a discrete commit.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1064b5bdcd207efc20ae4ed0fd509364402964f9
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 29 12:13:34 2008 -0500
Fixing the format_handler tests so that they clean up after themselves.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 167831ee3b34eb42b6ca45fcbde2d66a015d90fa
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 29 00:55:10 2008 -0500
Fixing a test I broke while rebasing
Signed-off-by: Luke Kanies <luke at madstop.com>
commit e78b1a642050c94bf7d3027048318613505cdaed
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 28 18:51:47 2008 -0500
Fixing a test to be order-independent.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 352e2d0fb74fd7226ecac06b6108e672c221baa1
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 28 18:50:24 2008 -0500
Adding rudimentary support for directly managing formats.
We have a simple Format class, and the FormatHandler
module is responsible for managing its instances,
including providing access by mime type or name.
It will soon replace some of the testing functionality
in the FormatHandler module, but for now, it's just
there as a name => mimetype converter, which makes it
seem a lot like overkill.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 55e29444c15fe2f810b3d5332605f27ac5942fda
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 28 18:05:41 2008 -0500
Adding support for rendering and converting multiple instances.
It's a touch hackish in terms of design, but it should work,
and it's the last major piece of plumbing necessary for REST support.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 4632cfd9e6ce0ff59dfa7562a02a1ae3f14488d4
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 28 11:23:08 2008 -0500
All error and format handling works over REST except searching.
Searching operates on multiple instances, and I have not
yet figured out how we should handle converting multiple
instances to a given format -- we can't use the instance
method (e.g., to_yaml), because it would be on Array
instead of the class we're operating on. That would work
for yaml, but not, for instance, for xml.
commit e3350caeec3a662b0b92ec2dee372563a493fa11
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jul 26 22:46:26 2008 -0500
Drastically simplifying the REST implementation tests.
Nearly all of the tests are now written just once, in
the Handler module. The Mongrel and Webrick tests just
validate that they provide the interface and how they do
so.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit b3914c367f470dd37a846d01207228d6ded40c6d
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jul 26 22:45:19 2008 -0500
Removing an apparently-obsolete hook from the handler
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 739a87152f7d7fbab714de76ea846991a4cd6e45
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jul 26 22:05:00 2008 -0500
Adding explicit tests for the HTTP::Handler module.
This will help to remove a ton of duplication among the
Mongrel and Webrick tests, and it also helps make the
interface between the servers and the handler more explicit,
and thus more maintainable.
I still need to switch all of the servers over.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0ce92f1e0245bc3218c4ef34c9d218f586407636
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 22 19:55:53 2008 -0500
The REST terminus now uses the content-type and http result codes.
Things are currently broken -- this is a checkpoint commit
so that it's safe to make mistakes and will probably be
removed.
Signed-off-by: Luke Kanies <luke at madstop.com>
The REST terminus now completely does error handling and serialization.
The Integration tests are still completely broken.
Signed-off-by: Luke Kanies <luke at madstop.com>
The Mongrel and Webrick rest handlers no longer yaml-encode exceptions.
They just store the exceptions in plain text in the message body.
They also set the status to 400, rather than 404.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit a4170ba27bdda9e7aab8dfaf78f81781c95106f9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 21 17:19:45 2008 -0500
Removing a now-obsolete pending test.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit bf5b086ca7fb89f941873e95feae2fc2b259037a
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jul 21 17:19:17 2008 -0500
The REST terminus now provides an Accept header with supported formats.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 1f15725263812be347c42a2ea3777fee7b2129c9
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 9 19:07:47 2008 -0700
Using the FormatHandler in indirected classes automatically.
Signed-off-by: Luke Kanies <luke at madstop.com>
Changing the FormatHandler#render method to render_to
Signed-off-by: Luke Kanies <luke at madstop.com>
Adding the ability for the format handler to query supported formats.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 0e7e16d19b12cf7748215d3dd3adf5190fb90d20
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 9 19:07:30 2008 -0700
Adding a FormatHandler module for managing format conversions.
Signed-off-by: Luke Kanies <luke at madstop.com>
commit 40375a8fc34dbd85d87f507ba72c7394b25b7271
Merge: 93eeff59d807261ed154cc104e318ae604602430 8f5800f0608dff46407cb5f23ee73f314fe051e8
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 29 00:46:11 2008 -0500
Merge branch '0.24.x' into merging
Conflicts:
test/ral/type/filesources.rb
commit 93eeff59d807261ed154cc104e318ae604602430
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 8 15:03:53 2008 -0500
Fixing the user ldap provider tests
Signed-off-by: Luke Kanies <luke at madstop.com>
commit c1dc92b9a14c04096e0bed0f2c4acc4dfe1ed7d2
Merge: b0febd263c0cb8e61d512898f7c79868ea77e619 edf99c508dabb58342eeff251ad5701d2755426d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jul 8 15:03:13 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
commit b0febd263c0cb8e61d512898f7c79868ea77e619
Merge: df528a66cafc8538c3208bf0b52fdbe1065f6e48 81be1c5c3f85f514505e99fab5b8a2b2ae6fbec8
Author: Luke Kanies <luke at madstop.com>
Date: Fri Jul 4 22:14:37 2008 -0500
Merge branch '0.24.x'
Conflicts:
lib/puppet/util/settings.rb
spec/integration/defaults.rb
spec/unit/node/catalog.rb
spec/unit/type/interface.rb
spec/unit/type/ssh_authorized_key.rb
commit df528a66cafc8538c3208bf0b52fdbe1065f6e48
Merge: 00b7da39f79436950245f44ab1f7db71e81d3499 d56deb378704dbb07ae616df011a2ed7cb375920
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 2 20:56:22 2008 -0500
Merge branch '0.24.x'
commit 00b7da39f79436950245f44ab1f7db71e81d3499
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 2 19:33:46 2008 -0500
Fixing the new-form version of #1382.
It only works when finding certificates, but that should be sufficient.
commit 3795654323dfdfe468f5dddfdc16787b883752db
Merge: 8e4312ed249d83ece754b80e993fa0d86bd36d46 e03c1be35c5f04ba0e3d301579e8493c00d2ecf9
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 2 18:36:05 2008 -0500
Merge branch '0.24.x'
commit 8e4312ed249d83ece754b80e993fa0d86bd36d46
Merge: 49016bb29312bfeb6f41ce420159e6ffc477eebe d3a81255245eec19ac21902ae3b877e00e620628
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jul 2 00:32:52 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
spec/unit/node/catalog.rb
spec/unit/type/package.rb
spec/unit/type/schedule.rb
spec/unit/type/service.rb
spec/unit/util/settings.rb
commit 49016bb29312bfeb6f41ce420159e6ffc477eebe
Merge: 6b69a86e48be082a6d03ce69f2700c4c874e222f 5273b22b4fda6f9aa7a8366a1dfbae092594d391
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jun 16 10:56:55 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
lib/puppet/defaults.rb
spec/integration/defaults.rb
commit 6b69a86e48be082a6d03ce69f2700c4c874e222f
Merge: c542dc065fd618ae85bb6e8960d8819f42aefaeb d3a4d9ad72ae12199163864582bfbb0f30a7f271
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jun 15 20:21:51 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
Finally adding release names to the changelog so we can keep the changes aligned in the right part of the log.
commit c542dc065fd618ae85bb6e8960d8819f42aefaeb
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jun 15 16:47:14 2008 -0500
Fixing #1168 for REST -- all ssl classes downcase their names.
This is a much cleaner fix than the xmlrpc version, thankfully. :)
commit 7b10c39bdc20cad3d4652008c404d576461d75e1
Merge: 6a61198f9293674a4bf0aa75bfbca10e20f64d20 575f37a0656f5a1f94fe6fb1b189d1701a98cadc
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jun 14 21:32:10 2008 -0500
Merge branch '0.24.x'
Conflicts:
lib/puppet/executables/client/certhandler.rb
spec/unit/executables/client/certhandler.rb
commit 6a61198f9293674a4bf0aa75bfbca10e20f64d20
Merge: eaa6eabc680cb6264594e30fd6a56e3e36765269 7b2c310e18b214424ae082e6ed2354a07b708c6f
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jun 14 13:53:56 2008 -0500
Merge branch '0.24.x'
Also added the fixes to make the certhandler tests pass
even when certs exist; I'll deal with the conflict later.
Conflicts:
CHANGELOG
bin/puppetd
lib/puppet/network/http/handler.rb
lib/puppet/network/http/mongrel/rest.rb
spec/integration/indirector/rest.rb
spec/integration/network/server/mongrel.rb
spec/integration/network/server/webrick.rb
spec/unit/network/http/webrick.rb
commit eaa6eabc680cb6264594e30fd6a56e3e36765269
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 20:22:01 2008 -0500
Fixing #1258 -- Removing a Rails idiom.
This idiom is only functional when you have
Rails loaded, which is why it was failing for others
but not me.
commit eb5e42263c109096a2ab4aa31f062f3e603db0dd
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 20:17:55 2008 -0500
Fixing #1256 -- CA tests now work with no ~/.puppet.
I've set the default cadir and vardir to /dev/null, to
hopefully catch this kind of test sooner next time.
commit 66c36f0f85f6914372980c66432d1ba122a50321
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 17:13:51 2008 -0500
Fixing another failing test -- the new CA tests correctly clear the cache.
I was previously not clearing the cache using the Cacher.invalidate
method, which caused a test to fail.
commit 447507c5f8e2c72d6962c29423fbf6fc8d8238a4
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 17:05:28 2008 -0500
Fixing #1245 -- ssh_authorized_keys tests work in master.
I just had to remove the '.clear' call.
commit 6f533d11277dea2c57755cf379342a6bfb818eb8
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 16:01:26 2008 -0500
Fixing #1247 -- no more clear_cache failures.
I had clearly only run spec/ since this work.
commit 29f5f1b862112179ce1b77ae0177811ab2208aeb
Merge: fe157f239a301abb52f81c62719355c8e50c970c 7b02f2ba443ba35d7305c24b87028456eaf6bd29
Author: Luke Kanies <luke at madstop.com>
Date: Sun May 25 16:00:48 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
lib/puppet/transaction.rb
commit fe157f239a301abb52f81c62719355c8e50c970c
Merge: 3cb0d60d3d0870f1d9ac83e5dbeaa06d2888231f 84a787a2a764a5035f7cbb8d30f94fc601bed154
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 20 10:19:10 2008 -0500
Merge branch '0.24.x'
Conflicts:
CHANGELOG
spec/integration/defaults.rb
spec/integration/node/catalog.rb
spec/unit/rails.rb
spec/unit/type/mount.rb
commit 3cb0d60d3d0870f1d9ac83e5dbeaa06d2888231f
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 16 14:34:40 2008 -0500
Fixing how the mongrel server sets up xmlrpc handlers.
It was trying to use arguments but they were never actually
set.
commit 6efe4000dda3379e867786a9c2d4ae0f0cdfc3be
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 13 16:00:58 2008 -0500
Using the new Cacher class for handling cached data.
This provides a single, global bit for determining whether
a given piece of cached data is still valid.
commit 68d8d0ae0686939d94dae8ccc70e5582187335dc
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 18:28:35 2008 -0500
Adding a module for handling caching information.
I keep having issues with integration tests keeping
cached values around, and this module should hopefully
give us a single place to invalidate all caches, thus
making testing this much easier.
commit e936ef2426464b901638bf338c1c42590245b58f
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 14:45:13 2008 -0500
Fixing some broken tests.
The HttpPool module now removes its cached ssl_host instance
when clearing its cache. This is really only useful
for testing, but it correctly causes the pool to use
new certificates when they're available.
commit 1cfb0215a4d56af9ac1e0c672d9ae597dfde846e
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 13:29:38 2008 -0500
The CRL is now automatically used or ignored.
Previously, you had to configure whether you wanted the CRL or not,
which resulted in errors all the time when it was configured but
unavailable.
Now, Puppet will always create and try to use it, but you won't
get failures if it's unavailable.
commit 0365184aaec4d71f7fa93fc1534ae10f8f842bb7
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 13:28:51 2008 -0500
Removing obsolete tests
commit 330359015602eba83077fccaa708c819d2d78b53
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 12:29:58 2008 -0500
The master and client now successfully speak xmlrpc using the new system.
The server is actually serving REST, but the client can't use
it until we resolve the format and security issues that REST
hasn't yet tackled.
commit 8fd68e388aa0b26d2dacc201086960385ff5c834
Author: Luke Kanies <luke at madstop.com>
Date: Wed May 7 12:25:00 2008 -0500
Adding pidfile management and daemonization to the Server
class.
commit dd4d8684fc19adcb68c681ba1c446a737498cda0
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 6 19:02:45 2008 -0500
Fixing the HttpPool module to get rid of an infinite loop.
We can't have the HttpPool class use the Indirector to see
if it has a cert available, because it might be being used to
try to download one, which would cause it to make an http instance,
which would cause it to... Well, you get the idea.
Adding and fixing a few other tests I ran into on the way.
commit 57c753419ac4700ab87689a3e3c3eb7302fff693
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 6 18:58:41 2008 -0500
Adding REST terminuses for the SSL-related indirections.
commit d78b4ba48a0fdf63906fb0ede2cd8c2e634ef442
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 6 16:45:29 2008 -0500
Adding autosigning to the new CA.
Now the CSR class triggers autosigning when any CSR is
saved, if it's running on a CA host.
commit a822ef9ce5c6d603f4a98b9dda0dbf4661528128
Author: Luke Kanies <luke at madstop.com>
Date: Tue May 6 15:39:18 2008 -0500
Moving the CA Interface class to a separate file.
commit 38e2dcf35a1d9b19970d1fb253f6c09b0529e083
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 22:36:59 2008 -0500
The master is now functionally serving REST and xmlrpc.
...as far as I can tell. The client, however, is broken,
since it used the old http_pool/ssl_support stuff, which
no longer works.
I have to port puppetd over to using the new ssl stuff,
then I'll at least be able to verify that the master can
still speak xmlrpc.
commit 6e0d6ddf5ef1cd6b23a672020bb657744b5a2c59
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 22:25:42 2008 -0500
The REST infrastructure now correctly the SSL certificates.
I don't think the whole thing is done, but at least the
basic flows are in place. Now it's just a question of
doing real-world tests and fleshing out the unit tests
as necessary.
commit 51ce6746bc4c865b307af77b0967b345bf095aa8
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:16:25 2008 -0500
Fixing the webrick integration tests to use the newly-functional
SSL code.
commit 62f1f5e1514b4283750558f0019331de8e9460a4
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:15:39 2008 -0500
The Certificate Authority now automatically creates a CRL when appropriate.
This requires less setup and configuration on the part of the user.
commit e57436f1056cceb8ecdfadfa618911c5595c72e2
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:14:46 2008 -0500
The Settings class now clears the 'used' sections when a value is changed.
This makes is so that if you, for instance, reset the vardir,
then the next time an initialization call is made, we reuse
any previously used sections, thus (hopefully) correctly
creating any newly needed directories.
This is mostly helpful during testing.
commit 137e29ff0e33ff5cbb4032d452abc5a5aef2c941
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:13:07 2008 -0500
Moving some http configuration values to the main
defaults section, rather than the puppetd section.
commit a3b88041570a35827c82993d7559d3583b31232c
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:12:39 2008 -0500
The http pool manager now uses new-style certificate management.
It uses an instance of SSL::Host for getting its certificate
and ssl store.
commit e596bc5267bdbbe2e4ea0e7722047d1354f10826
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:01:33 2008 -0500
Fixing some tests that were insufficiently mocking their configurations.
These were still writing to ~.
commit 160f9d99e33b051d40f00971683cf54a0ff00c32
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 21:00:29 2008 -0500
Fixing a critical problem in how CRLs were saved and moving SSL Store responsibilities to the SSL::Host class.
I was previously saving invalid CRLs unless they'd had a revocation
done in them; this commit fixes them so that they're always valid.
Also, I've added to SSL::Host the ability to generate a valid
SSL Store, suitable for validation. This is now used by
Webrick and can be used by the http clients, too.
This should have been two commits, but I'm kind of down the
rabbit hole ATM.
commit ce6d5787aaefc4c980e51c394328c2ddc2f7cb9c
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 17:16:03 2008 -0500
The SSL::Host class now uses the CA to generate its certificate when appropriate.
It uses the CA singleton method to determine
whether it's on valid CA host, and if so, uses
the CA instance to sign its generated CSR.
commit 67dc268fae0489de93f247b08fdaf7b1eec0e15d
Author: Luke Kanies <luke at madstop.com>
Date: Mon May 5 17:10:07 2008 -0500
The CA now initializes itself.
I realized that it never made sense to have a CA
that didn't know how to initialize itself, so we
now have a singleton method for the CA, and it also
automatically initializes itself.
commit 6356c043a44c771d707750f96f7660a1093be9ac
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 2 13:47:44 2008 -0500
Switched puppetmasterd to use the new-style server plumbing.
The code is much cleaner, and it seems to be mostly
functional, but we have to pick a strategy for signing
the host's certificate on first startup. Also, I haven't
actually done end-to-end testing yet, which needs the certs
working first.
commit 4c590df607f3d2cb6921b8d8269862a4f8f2456c
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 2 13:20:00 2008 -0500
Adding xmlrpc backward compatibility to the new Mongrel code.
commit 31b79fa7760f95059a4e2afb35e734de283cf4a0
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 2 12:58:35 2008 -0500
Adding xmlrpc support to webrick.
This provides the backward compatibility for webrick,
and only Mongrel is left.
commit 7a876ed6a06bc5decb257126eb57368aeb178a81
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 2 12:28:23 2008 -0500
Fixing some whitespace
commit 72673413c8ead5adcb321fe1ce9cfe0410e0eb54
Author: Luke Kanies <luke at madstop.com>
Date: Fri May 2 12:27:15 2008 -0500
Adding configuration support for XMLRPC handlers.
This provides the interface for configuring backward compatibility
in the new-style server code. It requires a completely different
configuration step, in that REST and xmlrpc handlers are configured
separately, rather than using the same handler names, but this was
considered less evil than having a large abstraction layer for specifying
how the handlers are related.
commit 8c9b04d807b34ade704da3584b72d39bb129aa75
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 28 17:52:02 2008 -0500
I think I've now got the Webrick SSL support working.
Now I just need to get xmlrpc working alongside REST in
both mongrel and webrick.
commit 83519f4e59f68f867f8ddbe141ac8bd9a6238ae1
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 28 12:16:16 2008 -0500
Interim commit, since I want to work but have no network available.
commit 0e8a1c9f6ac45e9e6f6dcf6464ad4d2780201ce1
Merge: 58fb416e9f52a9dc834b735ffa7e5c425495c982 62ca72608c8fcded624c46c6951b9381a7284a80
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 21 23:45:53 2008 -0500
Merge branch '0.24.x'
Conflicts:
bin/puppetca
commit 58fb416e9f52a9dc834b735ffa7e5c425495c982
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 21 22:30:01 2008 -0500
Changing the File certificate terminus so that it
saves to the :localcacert instead of :cacert.
This way the :ca terminus saves to :cacert and the :file
terminus saves to :localcacert.
commit 79ca44404af29b2bae621f9a6cb80467d95468aa
Author: Luke Kanies <luke at madstop.com>
Date: Mon Apr 21 17:33:58 2008 -0500
Renaming the 'ca_file' ssl terminus type to 'ca'.
commit a116d10b5e4412c362a246f12b77fc2e979aedbe
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 19:37:22 2008 -0500
Temporarily disabling the revoke/verify test in the CA.
It looks like it's not taking the CRL into account, so
I can't seem to actually get a cert to fail verification.
commit d87e018ab84646de94aea70c2bd0270e1721940d
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 19:20:25 2008 -0500
Fixing how the CRL is used for certificate verification.
The CRL was not correctly being added to the Store used
for verification.
It does not appear to be working, though, since revoked
certificates still pass verification.
commit 6c539c001e26b5a344d1f6e582f2f25cf16542bc
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 19:13:14 2008 -0500
Fixing puppetca so it uses the :local ca setting.
This causes it to use both the :ca_file and :file terminus
types.
commit ebdbe4880d8c20965ac21a473b2bfc1ab953b6d4
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 19:08:36 2008 -0500
Added an Interface class to the CA to model puppetca's usage.
This class provides all of the semantics from puppetca,
and appears to entirely duplicate the behaviour of the existing
executable, with basically all of the code in a library
file, instead of the executable.
As such, I've deleted the test for the executable. We should have
one, but it's not nearly as important.
commit 934fbba81cb18f05e07675d79a2e830c4e95c918
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 15:30:11 2008 -0500
Making the SSL::Host's destroy method a class method,
rather than an instance method.
commit d4813f1e03d96551e91b104e48b028fb4074d398
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 14:59:11 2008 -0500
Adding the last functionality needed for puppetca to use the Indirector.
This commit adds 'list' and 'print' support to the CA.
They're mostly delegator methods, but now the CA should be
the sole interface for puppetca.
commit 809fc77bc767fb3acabc83d55183686200b1e384
Author: Luke Kanies <luke at madstop.com>
Date: Sat Apr 19 14:50:18 2008 -0500
Finishing the interface between the CA and the CRL.
Certificate revocation now works, the CA knows how
to generate the CRL, and the SSL::Host class knows
how to configure the CRL class for indirection.
commit 16056a24c65a7c6485b65f15700ff3971781031b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 11:57:50 2008 -0500
Adding inventory support to the new certificate authority.
The new-style CA now keeps track of all of its signed
certificates in its inventory file.
commit d498c4ac4c7b97b5f8e004b3e31d8cbeed914711
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 11:53:59 2008 -0500
Adding support within the inventory for real certs or Puppet cert wrappers.
commit 67f9d6977a21a96bf0a2a4d1d9ebde190a58e7bc
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 11:47:44 2008 -0500
Changing the Inventory class to rebuild when the
first cert is added, so it's easier to test.
commit 7cca66985a0f84b3904702df842d461c2b6431b7
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 11:40:48 2008 -0500
Adding a comment to the inventory class.
commit 98db9850a7ef8bde01ffae2a80d640ff1e8e92b3
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 11:39:42 2008 -0500
Adding an SSl::Inventory class for managing the ssl inventory.
This models the existing Inventory module in the sslcertificates/
directory, but does so as an instance, rather than a module.
commit 92a7d76e8a160ba1ddb684d52eab6639cf801cb7
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 18 10:49:58 2008 -0500
All SSL terminus classes now force the CA information into the right place.
Without this, then you could end up duplicating your CA
key into the normal directory depending on how caching
was set up.
Again, this design aspect isn't the most straightforward,
but at least it's functional now.
commit fb56deae3488e5d97e10e38cba98393a5a8f8414
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 22:12:21 2008 -0500
Switching the SSL::Host class to return Puppet instances.
Previously, the class was returning OpenSSL instances
(e.g, OpenSSL::X509::Certificate) instead of Puppet instances
(e.g., Puppet::SSL::Certificate). This made some things
easier, but it made them asymmetric (e.g., you assigned the
key as a Puppet instance but got back an OpenSSL instance), and
it also reduced your flexibility and introspectiveness.
commit f7e0990fb436ce14e5f7ed295c004438d7735f95
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 21:51:14 2008 -0500
Setting the expiration date of certificate objects to the expiry of the actual
cert.
commit 71db9b58349f75a54649d9b0d1fead8d01593f7a
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 21:39:24 2008 -0500
Adding integration tests for a lot of the SSL code.
This flushed out some problems, and things mostly look good
now, but I don't think we're quite there yet.
commit e5c4687593766955de09e5613c892ce82a2a989d
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 20:11:34 2008 -0500
Moving the password file handling into the SSL::Key class.
This was necessary because when the Indirector is used, there
isn't necessarily enough context available to know when a
password file should be used (e.g., when reading a Key from disk,
you don't know if that key was encrypted).
Now, the Key class automatically uses the right password file, and
only tries to use those files that actually exist.
This isn't very flexible, in that it only allows one CA file and
one non-CA file, but no one really uses anything but
the CA file anyway.
commit d8bb81eabb6ad85d985ae7407e4260e800a0cf30
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 18:09:33 2008 -0500
Moving all of the ca-specific settings to the ca_file
terminus classes, rather than the normal :file classes.
This is unfortunately complicated, and it means that the Key
:ca_file is only ever actually used for retrieving the CA key
itself.
commit cbe522169ed6eb2426ecf5a77e24e27b6f7a4edf
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 17:47:03 2008 -0500
Adding SSL::Host-level support for managing the terminus and
cache classes. Also, defaulting to the :file terminus
for all of the SSL classes.
commit c5f0eff51626baa76ebc5bd4bee9d319a0b220c5
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 16:49:16 2008 -0500
Fixing the CA so it actually automatically generates its certificate.
commit 3d24b12d73aad0bac74e4b2f1e214b79f3ca9231
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 15:50:40 2008 -0500
The certificate authority now uses a Host instance named 'ca'.
It previously was a subclass of Host, but this should make it
easier to separate between the thing doing the signing and the
thing managing the necessary files.
commit daa8cd57b9f61c40c1b4e6954533f197ee5a2f1d
Author: Luke Kanies <luke at madstop.com>
Date: Thu Apr 17 14:47:27 2008 -0500
Changing all of the SSL terminus classes to treat CA files specially.
This is a kind of weird design situation. For instance, we've got a
collection of certificates in the :certdir, but then there's a special
CA certificate off by itself. Rather than build a whole separate
infrastructure for managing those separate files (cert and key, at least),
I decided to add special support for specifying where to find the CA-specific
bits, and then code for handling them when necessary.
This requires that we have a standard way of knowing whether we should be
managing the CA bits or normal host files. The Puppet::SSL::Host class now has
a 'ca_name' method that returns the string we're using for the CA name; this
name is currently 'ca'. We have to use a name, because the name is the only
thing that all methods have access to (e.g., when trying to 'find' the right
cert, we only have the name available).
What this means is that if you want access to the CA key or cert, then create
a Puppet::SSL::Host instance with the name 'ca'.
You'll still get the CA cert created with the host's :certname; it will just
be stored in a different location.
commit 7d2c05e86eb14bc7600dcf1d61ba447cd9b4cab8
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 16 14:21:31 2008 -0500
The 'destroy' method for the ssl_file terminus base class
now returns false on missing files, rather than failing.
commit 7555af6de90a42bc7ff12381b3c198335c651299
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 16 12:35:10 2008 -0500
Marking a test as pending, because it's not ready yet.
commit c19c9d436d4d8ca0a5773065b53348242d237651
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 16 12:34:53 2008 -0500
Removing all the cases where the ssl host specifies
a terminus. Also, getting rid of some metaprogramming
that wasn't really helping.
commit 054e4e431a145737c42d767249f1b94685c9a6d7
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 15 21:28:57 2008 -0500
Making the first pass at using requests instead of
specifying the terminus class. The individual ssl
classes now work, but the ssl host class doesn't yet.
commit 6900f9776a7875ea13cbb5fe1f2eaa48fe05e667
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 2 10:53:40 2008 -0500
Adding a :to_text method that will convert the contained
thing to readable human text.
commit 174b9c99f7eb904ec7d415d3884f3620b6b65d40
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 2 10:53:14 2008 -0500
Actually signing the certificates in the CA.
commit 546ac97398caa1e9defb34df9567d798e4959020
Author: Luke Kanies <luke at madstop.com>
Date: Wed Apr 2 10:52:49 2008 -0500
Adding the first attempt at managing the certificate
revocation list.
commit c98ad25403dbb27289048513af48d0b3e1723b18
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 1 18:24:46 2008 -0500
Adding a :search method to the ssl_file terminus type
and the SSL::Host class.
commit d184b3539db2e857b8df424171a1beed4560a035
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 1 17:07:05 2008 -0500
Fixing a failing test that had not been updated from previous coding
commit b9d647974915da05af8036933e71bc1e6dc00374
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 19 23:46:43 2008 -0500
We have a basically functional CA -- it can sign
requests and return certificates. There's still plenty
more work to do, but I'm probably not much more than a
day away from redoing puppetca to use this code.
commit 1efed0304ebdc13a55eb2d865cdc4965c5253d3a
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 19 17:50:09 2008 -0500
Adding tests for the easy bits of the CertificateFactory.
I probably am going to skip the tests for the rest, since
the code is unlikely to ever change, and it's going to be
a royal pain to test.
commit ee07d0b7f198857f700b9ad09713fe6b992ffee8
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 19 17:30:39 2008 -0500
Adding tests for the certificate serial numbers
commit dc5c73bc72810bf63236581cdc9407b039ea135d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 19 13:16:40 2008 -0500
The certificate authority is now functional and tested.
commit a776a12c10a857ea275de8d25190fb840d94d611
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 12 13:26:20 2008 -0500
refactoring the cert request test a bit
commit 7641bd4505640729d549b56746e592fd20ee0c76
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 12 01:57:02 2008 -0500
This is a first pass at the certificate authority.
The tests are basically entirely absent still, but
the structure is all there.
commit 0f46815b4e7b7970e9516166f47c0ec074bf0fa2
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 11 19:27:32 2008 -0500
It looks like all of the new ssl classes for managing
keys, certificates, and requests now work, including
talking to the certificate authority. Now we just
need the authority itself, along with the necessary
REST terminii.
commit 00e35bce4e8b7f4e0e4ee039a1d82ad9d08a6b96
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 11 15:02:15 2008 -0700
Adding he last of the indirection classes for the ssl
classes, finally including the certificate requests.
commit 8347b0605612128b1a9e9f2d2d2e5ea73dae288d
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 11 14:19:11 2008 -0700
The certificate and key are now correctly interacting
with the existing cert/key store. Certificate requests
are not yet handled, nor are the ca-specific collections.
commit 50f3c18c4e1d54790983262b5e285c529358fb43
Author: Luke Kanies <luke at madstop.com>
Date: Mon Mar 10 22:32:10 2008 -0700
Removing obsolete indirection classes
commit ec5bdf3b2d089d53f1f8fd986df83768564e79ac
Author: Luke Kanies <luke at madstop.com>
Date: Mon Mar 10 10:37:57 2008 -0700
The basics for the certificate and certificate request
indirection terminii are done. I need to move most of
the test code to a shared behaviour now.
commit bb87464f75cf3ea2e17bb660e7d1880bc36e141f
Author: Luke Kanies <luke at madstop.com>
Date: Sun Mar 9 16:38:05 2008 -0700
Fixing a couple of broken tests.
commit b0811ad60527e97554e3f3e1f64d961fc72077b1
Author: Luke Kanies <luke at madstop.com>
Date: Sun Mar 9 16:37:45 2008 -0700
The new SSL classes basically work, but they're not
functionally connected to any kind of indirection.
commit 3970818881b1f9e108ff6b06d2bc36698a3219d9
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 7 15:38:41 2008 -0700
Finished the certificate request wrapper class.
commit 4ca6fd3e476dbc582ebc69f5fdf9709a8703613b
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 7 15:31:15 2008 -0700
First stage of cert refactoring: Private
keys kind of work.
commit ef7d914aee89b6ea023f030350d04923a7b63fd2
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 15 21:33:49 2008 -0500
Oops; final fix on the integration test failures resulting
from my partial support for ssl in webrick.
commit 0ca0ef63d5e38de2926e14ca616cef03250e2a79
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 15 21:06:07 2008 -0500
Fixing whitespace problems.
commit 4640a3da925387fd2bf88b70f0b37c482926d8b8
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 15 21:05:57 2008 -0500
Fixing an integration test of the rest terminus; it was
broken by my incomplete cert support in webrick. I just
stubbed out the cert usage for now; once all the cert stuff is done
we'll need to go back and unstub it.
commit d738f31dd33f6f4683b78f49041a302e4d95eae7
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 15 12:09:13 2008 -0500
Adding the necessary tests for webrick to have logging and
ssl. The tests can't be completed until the certificate work
is all done.
commit d834242db13a827a34340c5f2e51c8df532d5196
Merge: fb05ef3c96038d67a46eb142202af186ad6cb0b3 d9846fc3f06f61fcb4b8806740f77747a7f6939e
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 11 15:21:50 2008 -0500
Merge branch '0.24.x'
Conflicts:
spec/unit/network/server.rb
commit fb05ef3c96038d67a46eb142202af186ad6cb0b3
Merge: b49fb68f768e8b98c555ef0ae08a7bd22f5d36bd b49fd495622b15f96faf944db1e70cbe9e7fe7c4
Author: Luke Kanies <luke at madstop.com>
Date: Fri Apr 11 13:01:42 2008 -0500
Merge branch '0.24.x'
commit b49fb68f768e8b98c555ef0ae08a7bd22f5d36bd
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 1 00:45:45 2008 -0500
Fixing the tests in test/ that were broken as
a result of the move to no global resources.
commit 5e78151d1736e2c4cb741c2cbb7c6b5a59ed3e13
Author: Luke Kanies <luke at madstop.com>
Date: Tue Apr 1 00:08:15 2008 -0500
Fixing tests that were failing as a result of the merge,
including removing some now-obsolete code and tests from
the Settings class.
commit 88dc49cb7b0efe757c92ce28c807b91335acb07a
Merge: 4165edaeb71ee2883b1bb85ff39a52d5628b259f a8592f1009040ebf30a98268610915cc33bb3f63
Author: Luke Kanies <luke at madstop.com>
Date: Mon Mar 31 23:56:09 2008 -0500
Merge branch 'master' into master_no_global_resources
Conflicts:
lib/puppet/node/catalog.rb
lib/puppet/type/pfile.rb
lib/puppet/type/pfilebucket.rb
lib/puppet/util/filetype.rb
spec/unit/node/catalog.rb
spec/unit/other/transbucket.rb
spec/unit/ral/provider/mount/parsed.rb
spec/unit/ral/types/file.rb
spec/unit/ral/types/interface.rb
spec/unit/ral/types/mount.rb
spec/unit/ral/types/package.rb
spec/unit/ral/types/schedule.rb
spec/unit/ral/types/service.rb
test/language/compile.rb
test/language/lexer.rb
test/language/snippets.rb
test/lib/puppettest.rb
test/ral/types/basic.rb
test/ral/types/cron.rb
test/ral/types/exec.rb
test/ral/types/file.rb
test/ral/types/file/target.rb
test/ral/types/filebucket.rb
test/ral/types/fileignoresource.rb
test/ral/types/filesources.rb
test/ral/types/group.rb
test/ral/types/host.rb
test/ral/types/parameter.rb
test/ral/types/sshkey.rb
test/ral/types/tidy.rb
test/ral/types/user.rb
test/ral/types/yumrepo.rb
commit a8592f1009040ebf30a98268610915cc33bb3f63
Merge: e1907798425a7b163ac1b831b0cf11e88985815e 491a69682728818e04b8a20a5d8f4f783ad6ddaf
Author: Luke Kanies <luke at madstop.com>
Date: Tue Mar 25 18:18:34 2008 -0500
Merge branch '0.24.x'
Conflicts:
install.rb
lib/puppet/defaults.rb
man/man8/puppet.8
commit e1907798425a7b163ac1b831b0cf11e88985815e
Merge: 9f8bb7e42aeea4670d9292f935529f8db5d57bc5 e00065a8e63a7222eacbc7e8aaa925e967fd5c60
Author: Luke Kanies <luke at madstop.com>
Date: Thu Mar 20 11:55:42 2008 -0500
Merge branch '0.24.x'
commit 9f8bb7e42aeea4670d9292f935529f8db5d57bc5
Merge: c2b33acd5c1e6fe4021d7609f806b7bd8af834f8 e8029cc61a1956263935a0df469cc77b8e80a102
Author: Luke Kanies <luke at madstop.com>
Date: Fri Mar 7 12:28:58 2008 -0600
Merge branch '0.24.x'
commit c2b33acd5c1e6fe4021d7609f806b7bd8af834f8
Merge: 93a2189ef7c31bd31821eddc87f91b02b7f5a233 443db2009d0f5033eb51ebd210af2a198572fad0
Author: Luke Kanies <luke at madstop.com>
Date: Wed Mar 5 12:30:45 2008 -0600
Merge branch '0.24.x'
commit 93a2189ef7c31bd31821eddc87f91b02b7f5a233
Merge: 9d2f45df3d951ef59a44a7fb81a38586f04884b4 9a3348764b30ad355f14c27b497ae18ed20f9ea8
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 25 18:46:36 2008 -0500
Merge branch '0.24.x'
commit 9d2f45df3d951ef59a44a7fb81a38586f04884b4
Merge: 0afea69c06742eff1e8d8bd7df13c9c0e4c397c0 04892ee723d1a687c83eb6c99b5c6a6c76bbcbc9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 25 18:28:26 2008 -0500
Merge branch '0.24.x'
commit 0afea69c06742eff1e8d8bd7df13c9c0e4c397c0
Merge: a53106cf08c28e996502cba703f64944250a4b29 39f9818276e49020c1a6db9667371f7617d5cc93
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 18 22:07:12 2008 -0600
Merge branch '0.24.x'
Conflicts:
CHANGELOG
commit a53106cf08c28e996502cba703f64944250a4b29
Merge: be58bb5c4bc19e59685e0a8953eaf2d3b7844110 62d7616a457f33eb660454fcdcefe8dab84522c0
Author: Luke Kanies <luke at madstop.com>
Date: Mon Feb 18 09:38:32 2008 -0600
Merge branch '0.24.x'
Conflicts:
CHANGELOG
man/man8/puppet.8
commit be58bb5c4bc19e59685e0a8953eaf2d3b7844110
Merge: 11ef70aa357a081fd14158e70acc8d943b5caffa 98dbfa2865ad270d5fd9821c6518f6f30ce9aec4
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 12 23:00:52 2008 -0600
Merge branch '0.24.x'
commit 11ef70aa357a081fd14158e70acc8d943b5caffa
Merge: da78d96cb139db0775e634b2fa4bd9c173752127 bcb9b564281003e22d72752d84fa9dc9c8c7107b
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 12 17:39:26 2008 -0600
Merge branch '0.24.x'
commit da78d96cb139db0775e634b2fa4bd9c173752127
Merge: bee9aba2da453151a80c6e1f25f16bec3bfde8d2 3af6827875f4e02b47fe2293280ff9afe811485f
Author: Luke Kanies <luke at madstop.com>
Date: Tue Feb 12 17:37:51 2008 -0600
Merge branch '0.24.x'
Conflicts:
CHANGELOG
commit bee9aba2da453151a80c6e1f25f16bec3bfde8d2
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jan 20 22:14:10 2008 -0800
Environments are now available as variables in manifests,
and specs can be directly executed again.
commit b225e86b120091b213d32e657180ecc446057c0a
Author: Luke Kanies <luke at madstop.com>
Date: Sun Jan 20 22:00:05 2008 -0800
Fixing #1017 -- environment-specific modulepath is no
longer ignored.
commit 4ede432f4da9bb5529830f7a5c022a3245219303
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Jan 20 10:29:23 2008 +1100
Tidied the man page creation function and created "master" branch man pages
commit 0a7b028a9abf48e5358e7032cf3f3184c4c3ba5e
Merge: 1f15c80587529192321658a2e51fda33d481ced5 4618140eb0dad58fd54e0543b9a2629c2d675623
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jan 19 11:30:04 2008 -0800
Merge branch '0.24.x'
commit 1f15c80587529192321658a2e51fda33d481ced5
Merge: c751058722e10c6900f99f095d3be6e30c186a3e f335dc31f11f4bed80e91df041febdca6e33d3c2
Author: Luke Kanies <luke at madstop.com>
Date: Sat Jan 19 11:29:57 2008 -0800
Merge commit 'turnbull/ticket_198'
commit f335dc31f11f4bed80e91df041febdca6e33d3c2
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 19 09:45:14 2008 +1100
Updated defaults.rb to fix foru error stopping man page creation - links are not as neat as before but puppet.conf.man file will create neatly now.
commit c751058722e10c6900f99f095d3be6e30c186a3e
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 19 04:17:33 2008 +1100
Removed remaining elements of old_parse - closing Ticket #990
commit 31e08507cbe8444528aaaac2778374eea040709c
Author: James Turnbull <james at lovedthanlost.net>
Date: Fri Jan 18 22:03:36 2008 +1100
Removed old configuration file behaviour and deprecation warning - closes ticket #990
commit 4165edaeb71ee2883b1bb85ff39a52d5628b259f
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jan 15 19:41:38 2008 -0800
More fixes to the testing.
commit cfda651f88d12249f29706d2bedbfddce7a2e6f7
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 14 13:34:06 2008 -0800
Another round of test-fixes toward eliminating global resource
references. This should have gotten rid of all of them,
and now it's just a question of fixing a few hopefully unrelated
failing tests.
commit 488c43771aea482e0212b605bde054bf8cb0533c
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 14 09:30:30 2008 -0800
Fixing automatic relationships. I was previously looking them
up in the relationship graph, which only stores the vertices, not
the resource table.
commit d8991abac0b5302fe4202940b637dc4477d5e44e
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 15 00:47:17 2008 +1100
Updated install.rb to product puppet.conf.man page - updating ticket #198
commit 5a0388f654f3bdbe099ecf05099f441c243fda67
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 12 23:20:15 2008 +1100
Disabled new man page creation support
commit e5888af8848e5e54821a1a238c4b4af253160afa
Author: James Turnbull <james at lovedthanlost.net>
Date: Sat Jan 12 23:16:39 2008 +1100
Added support for man page creation - requires rst2man.py and writer - closed ticket #198
commit 5bef4a55b3489a6404ee34b900621af8b784749a
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 9 13:03:15 2008 -0800
Another round of fixes toward making global resources work.
The only remaining failures are more complicated ones (which I'll
need to not be on a plane to debug, for battery reasons) or those
related to the broken directory_service providers.
commit 3cc3e0f5b21deee4fbdbcbae18fba47c7a0cbb1e
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jan 8 09:23:34 2008 -0600
Lots o' bug-fixes toward getting rid of global resources.
We still have about 60 failing tests, but some of them are
the failing directory service tests (probably 20 or so),
and most are simple fixes to the tests themselves.
commit fe9b453650755e66e29eca259075e2e7245a5219
Merge: b7b11bd4858a4d6dd0661aa7c546d03b4a85ca7d 40addcd1920b0fa2f558c415e65ea665bac812f9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Jan 7 22:19:18 2008 -0600
Merge branch '0.24.x' into no_global_resources
commit b7b11bd4858a4d6dd0661aa7c546d03b4a85ca7d
Author: Luke Kanies <luke at madstop.com>
Date: Wed Jan 2 14:32:54 2008 -0600
Fixing a couple of failing tests
commit ebe5cc0979b57517f81c84a4d3ee771c12c6a19f
Merge: aed51b4818d64e97778e7e959f258586a36519ad efd035b73299efd19302cd47edacd5b860a2af55
Author: James Turnbull <james at lovedthanlost.net>
Date: Wed Jan 2 11:01:24 2008 +1100
Merge branch 'master' of git://reductivelabs.com/puppet
commit efd035b73299efd19302cd47edacd5b860a2af55
Merge: 1deb7fd487dca1046beb933dca2cccadf44fa6f5 99f9047d0200664461603c40379cdcea8191be99
Author: Luke Kanies <luke at madstop.com>
Date: Tue Jan 1 17:38:37 2008 -0600
Merge branch 'routing'
commit aed51b4818d64e97778e7e959f258586a36519ad
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 1 13:06:24 2008 +1100
Fixed puppet logcheck issues
commit 7aa79e2d17341e0be2f978b8081132474d181a72
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 1 12:58:12 2008 +1100
Revert "Fixed documentation for code option in defaults.rb"
This reverts commit e6547f03c48dde95f86538c5d4d25137e124792b.
commit f2991a21726e384e5099436c6b36b923380f053d
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 1 12:57:56 2008 +1100
Revert "Fixed indentation error in pkgdmg.rb documentation"
This reverts commit badf97777a9090b0645202217dcf217fbfdd5425.
commit 754129e93de4cc557e600890eab331ec9d0c3107
Author: James Turnbull <james at lovedthanlost.net>
Date: Tue Jan 1 10:46:46 2008 +1100
Revert "Fixed issue where permissions are incorrectly set on Debian for /var/puppet/run directory"
This reverts commit 594a5a3522a653ac0d2ddd6217c66c056fad1b60.
commit 20628ea51651c95f3ca35c4f9ed3c74a7b6d90b7
Author: James Turnbull <james at lovedthanlost.net>
Date: Mon Dec 31 08:04:13 2007 +1100
Added patch to ext/logcheck/puppet to fix ticket #978
commit badf97777a9090b0645202217dcf217fbfdd5425
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Dec 30 22:36:54 2007 +1100
Fixed indentation error in pkgdmg.rb documentation
commit e6547f03c48dde95f86538c5d4d25137e124792b
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Dec 30 22:02:05 2007 +1100
Fixed documentation for code option in defaults.rb
commit 594a5a3522a653ac0d2ddd6217c66c056fad1b60
Author: James Turnbull <james at lovedthanlost.net>
Date: Sun Dec 30 20:57:57 2007 +1100
Fixed issue where permissions are incorrectly set on Debian for /var/puppet/run directory
commit 1deb7fd487dca1046beb933dca2cccadf44fa6f5
Merge: f3fd7091d3db9dff1b177867589289890e9a3a66 c4ed43c2a1ad9ab865e3da6b8b7fad28222c3451
Author: Luke Kanies <luke at madstop.com>
Date: Sat Dec 22 21:44:37 2007 -0600
Merge branch '0.24.x'
Conflicts:
conf/redhat/puppet.spec
commit f3fd7091d3db9dff1b177867589289890e9a3a66
Merge: 5efde5a305b182ed581270107cd426b2cf38d9f5 933b1df6d84ec34a6ff347240c0151434ecc80a9
Author: Luke Kanies <luke at madstop.com>
Date: Mon Dec 17 17:23:27 2007 -0600
Merge branch '0.24.x'
commit 5efde5a305b182ed581270107cd426b2cf38d9f5
Merge: 9736b3cffa2294849d0536f303a5edc8b50b2183 e0dab9a48896f3d92b2845f5a886885ede777305
Author: Luke Kanies <luke at madstop.com>
Date: Mon Dec 17 15:55:20 2007 -0600
Merge branch '0.24.x'
commit 9736b3cffa2294849d0536f303a5edc8b50b2183
Author: David Lutterkort <dlutter at redhat.com>
Date: Fri Dec 14 11:19:07 2007 -0800
Updated for 0.24.0
commit 99f9047d0200664461603c40379cdcea8191be99
Author: Rick Bradley <rick at rickbradley.com>
Date: Fri Dec 7 16:07:23 2007 -0600
tweaking spec language; require Puppet::Network::HTTP class since it is referenced by Puppet::Network::Server
commit 87e1e815bf5fdb2d9a81c56b2f8c8ce1cf4a6b1c
Merge: d267fb2a0b6539ea08c3f855fab4666dd6506f11 9ad7d1a7255a89383bc2b8c6b72c79bc050945a3
Author: Rick Bradley <rick at rickbradley.com>
Date: Fri Dec 7 11:43:47 2007 -0600
Merge branch 'master' of git://reductivelabs.com/puppet into routing
commit d267fb2a0b6539ea08c3f855fab4666dd6506f11
Merge: b38f5384ed3a2427672a1b2008500bfa2a704731 507406bd44f01e151483f148fadc8d50a9640984
Author: Rick Bradley <rick at rickbradley.com>
Date: Thu Dec 6 16:04:35 2007 -0600
Merge branch 'master' of git://reductivelabs.com/puppet into routing
commit b38f5384ed3a2427672a1b2008500bfa2a704731
Author: Rick Bradley <rick at rickbradley.com>
Date: Wed Dec 5 12:32:46 2007 -0600
Moving $PUPPET/spec/lib/autotest up to $PUPPET/autotest as something has changed and it can't be found otherwise.
Adding $PUPPET/vendor/gems, with unpacked rspec gem there, introducing to spec_helper.rb LOAD_PATH incantation. Eliminating ad hoc unpacked rspec from spec/lib.
Moving monkey_patches and shared_behaviors up under spec/. Adjusting spec_helper.rb accordingly.
Nuking spec/lib.
Fixing up autotest/puppet_rspec.rb to be able to hunt down our vendor/gems/rspec/bin/spec binary. We can now run rspec without having to have the rspec gem installed.
commit e1abfac0d8230b0ea230b7420562250ff2e23c52
Author: Rick Bradley <rick at rickbradley.com>
Date: Wed Dec 5 11:32:52 2007 -0600
moving autotest directory to make it possible to run autotest again
-----------------------------------------------------------------------
--
Puppet packaging for Debian
More information about the Pkg-puppet-devel
mailing list