[Pkg-puppet-devel] Bug#579643: Bug#579643: Bug#579643: puppetdlock doesn't get removed always

[Nigel Kersten]

2010/4/29 micah anderson <micah at riseup.net>:
> On Thu, 29 Apr 2010 15:00:03 +0200, Joerg Herzinger <joerg.herzinger at global2000.at> wrote:
>> Package: puppet
>> Version: 0.24.8-2ubuntu4
>> Severity: normal
>> Tags: patch
>>
>> Im running a small company (60 clients, 15 Servers and VMs) all managed by puppet. My clients are Ubuntu, my Servers mostly lenny, some squeeze. From time to time I find that the lock file isn't removed after a reboot and puppetd doesn't start.
>> This happens mostly with my clients so I guess its problem with rebooting when puppet is currently running. I would suggest adding something like
>>
>> if [ -f /var/lib/puppet/state/puppetdlock ] &&  [ `pgrep -cx puppet` -eq "0" ]
>> then
>>     rm /var/lib/puppet/state/puppetdlock
>> fi
>>
>> to the start daemon part at the init script to delete the lockfile if it exists and puppet is not running.
>
> Hmm, maybe it would be better to ship the default configuration to have
> the lock file be put in /var/run so this would be avoided?

Given upstream seem quite keen on being as compliant as possible, I
suggest we should do this upstream, this seems like a rather big
behavior divergence for just Debian?

I'd be happier us doing it if upstream is planning to.

/var/run seems like a much more sane location for this, I don't think
we should break people like Russ who are relying upon this behavior.

Russ, would you be happy with simply having to override your own
puppetdlockfile location to keep your existing behavior if we/upstream
changed to a location that doesn't persist across reboots?