[Pkg-puppet-devel] Commit practices, code review, etc

[Andrew Pollock]

Hi,

While we're on the topic of commits...

Coming from Google, I'm totally sold on principle of doing code reviews
prior to submitting changes.

I feel that at the moment, we're all just commiting changes to the Git
repository on Alioth in a fairly uncoordinated manner. If we had a code
review prior to a commit, this would at least give everyone advance warning
of an impending commit.

The question is how to insert this into the workflow? I know of Gerrit,
which seems pretty cool, because it's like the code review tool we use
internally at Google. I don't know much about how it integrates with Git, or
what it would take to spin up an instance of it (I think it's Java-based).

It seems like one for all of Alioth would be the way go.

Anyone got any thoughts on this?

regards

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20100218/51b9ab8e/attachment.pgp>