[Pkg-puppet-devel] Bug#571130: puppet-common: Package purge should remove all puppet directories

[Mathias Gug]

Package: puppet-common
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu lucid ubuntu-patch


In Ubuntu we've applied the following patch:
  * debian/puppet-common.postrm:
    - On purge delete all puppet directories: /etc/puppet, /var/log/puppet and
      /var/lib/puppet.

IIUC /var/lib/puppet isn't deleted when the puppet package was purged
because it would break puppetmaster. Now that common files are shared
with the puppet-common package, purging the puppet package shouldn't
break puppetmaster anymore. 

Moreover log files should be removed when the package is purged.

-- System Information:
Debian Release: squeeze/sid
  APT prefers lucid-updates
  APT policy: (500, 'lucid-updates'), (500, 'lucid-security'), (500, 'lucid')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-25-server (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
=== modified file 'debian/puppet-common.postrm'
--- debian/puppet-common.postrm	2010-02-16 06:30:55 +0000
+++ debian/puppet-common.postrm	2010-02-16 14:39:11 +0000
@@ -2,11 +2,10 @@
 
 case "$1" in
     purge)
-		# Remove puppetd.conf (used in > 0.24)
-		rm -f /etc/puppet/puppetd.conf
-
-		# Remove explicitly created state directory
-		rm -rf /var/lib/puppet/state
+		# Remove puppet directories
+		rm -rf /etc/puppet/
+		rm -rf /var/lib/puppet/
+		rm -rf /var/log/puppet/
 		;;
     remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)