[Pkg-puppet-devel] [SCM] Puppet packaging for Debian branch, upstream, updated. 0.25.5-639-g8f94f35

[Markus Roberts]

The following commit has been merged in the upstream branch:
commit bee843a5c37584a9bd68ec69319949a361f8fb6e
Author: Jesse Wolfe <jes5199 at gmail.com>
Date:   Thu Jul 1 17:03:22 2010 -0700

    maint: fix stubbing in package_spec.rb
    
    Puppet::Util::Storage was trying to create state.yaml during unrelated
    specs.

diff --git a/spec/unit/type/package_spec.rb b/spec/unit/type/package_spec.rb
index 11bd597..7cbd76a 100755
--- a/spec/unit/type/package_spec.rb
+++ b/spec/unit/type/package_spec.rb
@@ -3,6 +3,11 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 
 describe Puppet::Type.type(:package) do
+    before do
+        Puppet::Util::Storage.stubs(:store)
+    end
+
+
     it "should have an :installable feature that requires the :install method" do
         Puppet::Type.type(:package).provider_feature(:installable).methods.should == [:install]
     end
@@ -27,210 +32,210 @@ describe Puppet::Type.type(:package) do
         pkg = Puppet::Type.type(:package).new(:name => "yay")
         pkg.should(:ensure).should == :present
     end
-end
 
-describe Puppet::Type.type(:package), "when validating attributes" do
-    [:name, :source, :instance, :status, :adminfile, :responsefile, :configfiles, :category, :platform, :root, :vendor, :description, :allowcdrom].each do |param|
-        it "should have a #{param} parameter" do
-            Puppet::Type.type(:package).attrtype(param).should == :param
+    describe "when validating attributes" do
+        [:name, :source, :instance, :status, :adminfile, :responsefile, :configfiles, :category, :platform, :root, :vendor, :description, :allowcdrom].each do |param|
+            it "should have a #{param} parameter" do
+                Puppet::Type.type(:package).attrtype(param).should == :param
+            end
         end
-    end
 
-    it "should have an ensure property" do
-        Puppet::Type.type(:package).attrtype(:ensure).should == :property
+        it "should have an ensure property" do
+            Puppet::Type.type(:package).attrtype(:ensure).should == :property
+        end
     end
-end
 
-describe Puppet::Type.type(:package), "when validating attribute values" do
-    before do
-        @provider = stub 'provider', :class => Puppet::Type.type(:package).defaultprovider, :clear => nil
-        Puppet::Type.type(:package).defaultprovider.expects(:new).returns(@provider)
-    end
+    describe "when validating attribute values" do
+        before do
+            @provider = stub 'provider', :class => Puppet::Type.type(:package).defaultprovider, :clear => nil
+            Puppet::Type.type(:package).defaultprovider.expects(:new).returns(@provider)
+        end
 
-    it "should support :present as a value to :ensure" do
-        Puppet::Type.type(:package).new(:name => "yay", :ensure => :present)
-    end
+        it "should support :present as a value to :ensure" do
+            Puppet::Type.type(:package).new(:name => "yay", :ensure => :present)
+        end
 
-    it "should alias :installed to :present as a value to :ensure" do
-        pkg = Puppet::Type.type(:package).new(:name => "yay", :ensure => :installed)
-        pkg.should(:ensure).should == :present
-    end
+        it "should alias :installed to :present as a value to :ensure" do
+            pkg = Puppet::Type.type(:package).new(:name => "yay", :ensure => :installed)
+            pkg.should(:ensure).should == :present
+        end
 
-    it "should support :absent as a value to :ensure" do
-        Puppet::Type.type(:package).new(:name => "yay", :ensure => :absent)
-    end
+        it "should support :absent as a value to :ensure" do
+            Puppet::Type.type(:package).new(:name => "yay", :ensure => :absent)
+        end
 
-    it "should support :purged as a value to :ensure if the provider has the :purgeable feature" do
-        @provider.expects(:satisfies?).with([:purgeable]).returns(true)
-        Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged)
-    end
+        it "should support :purged as a value to :ensure if the provider has the :purgeable feature" do
+            @provider.expects(:satisfies?).with([:purgeable]).returns(true)
+            Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged)
+        end
 
-    it "should not support :purged as a value to :ensure if the provider does not have the :purgeable feature" do
-        @provider.expects(:satisfies?).with([:purgeable]).returns(false)
-        proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged) }.should raise_error(Puppet::Error)
-    end
+        it "should not support :purged as a value to :ensure if the provider does not have the :purgeable feature" do
+            @provider.expects(:satisfies?).with([:purgeable]).returns(false)
+            proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => :purged) }.should raise_error(Puppet::Error)
+        end
 
-    it "should support :latest as a value to :ensure if the provider has the :upgradeable feature" do
-        @provider.expects(:satisfies?).with([:upgradeable]).returns(true)
-        Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest)
-    end
+        it "should support :latest as a value to :ensure if the provider has the :upgradeable feature" do
+            @provider.expects(:satisfies?).with([:upgradeable]).returns(true)
+            Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest)
+        end
 
-    it "should not support :latest as a value to :ensure if the provider does not have the :upgradeable feature" do
-        @provider.expects(:satisfies?).with([:upgradeable]).returns(false)
-        proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest) }.should raise_error(Puppet::Error)
-    end
+        it "should not support :latest as a value to :ensure if the provider does not have the :upgradeable feature" do
+            @provider.expects(:satisfies?).with([:upgradeable]).returns(false)
+            proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => :latest) }.should raise_error(Puppet::Error)
+        end
 
-    it "should support version numbers as a value to :ensure if the provider has the :versionable feature" do
-        @provider.expects(:satisfies?).with([:versionable]).returns(true)
-        Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0")
-    end
+        it "should support version numbers as a value to :ensure if the provider has the :versionable feature" do
+            @provider.expects(:satisfies?).with([:versionable]).returns(true)
+            Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0")
+        end
 
-    it "should not support version numbers as a value to :ensure if the provider does not have the :versionable feature" do
-        @provider.expects(:satisfies?).with([:versionable]).returns(false)
-        proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0") }.should raise_error(Puppet::Error)
-    end
+        it "should not support version numbers as a value to :ensure if the provider does not have the :versionable feature" do
+            @provider.expects(:satisfies?).with([:versionable]).returns(false)
+            proc { Puppet::Type.type(:package).new(:name => "yay", :ensure => "1.0") }.should raise_error(Puppet::Error)
+        end
 
-    it "should accept any string as an argument to :source" do
-        proc { Puppet::Type.type(:package).new(:name => "yay", :source => "stuff") }.should_not raise_error(Puppet::Error)
+        it "should accept any string as an argument to :source" do
+            proc { Puppet::Type.type(:package).new(:name => "yay", :source => "stuff") }.should_not raise_error(Puppet::Error)
+        end
     end
-end
 
-module PackageEvaluationTesting
-    def setprops(properties)
-        @provider.stubs(:properties).returns(properties)
+    module PackageEvaluationTesting
+        def setprops(properties)
+            @provider.stubs(:properties).returns(properties)
+        end
     end
-end
 
-describe Puppet::Type.type(:package) do
-    before :each do
-        @provider = stub 'provider', :class => Puppet::Type.type(:package).defaultprovider, :clear => nil, :satisfies? => true, :name => :mock
-        Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
-        Puppet::Type.type(:package).defaultprovider.stubs(:instances).returns([])
-        @package = Puppet::Type.type(:package).new(:name => "yay")
-
-        @catalog = Puppet::Resource::Catalog.new
-        @catalog.add_resource(@package)
-    end
+    describe Puppet::Type.type(:package) do
+        before :each do
+            @provider = stub 'provider', :class => Puppet::Type.type(:package).defaultprovider, :clear => nil, :satisfies? => true, :name => :mock
+            Puppet::Type.type(:package).defaultprovider.stubs(:new).returns(@provider)
+            Puppet::Type.type(:package).defaultprovider.stubs(:instances).returns([])
+            @package = Puppet::Type.type(:package).new(:name => "yay")
 
-    describe Puppet::Type.type(:package), "when it should be purged" do
-        include PackageEvaluationTesting
+            @catalog = Puppet::Resource::Catalog.new
+            @catalog.add_resource(@package)
+        end
 
-        before { @package[:ensure] = :purged }
+        describe Puppet::Type.type(:package), "when it should be purged" do
+            include PackageEvaluationTesting
 
-        it "should do nothing if it is :purged" do
-            @provider.expects(:properties).returns(:ensure => :purged)
-            @catalog.apply
-        end
+            before { @package[:ensure] = :purged }
 
-        [:absent, :installed, :present, :latest].each do |state|
-            it "should purge if it is #{state.to_s}" do
-                @provider.stubs(:properties).returns(:ensure => state)
-                @provider.expects(:purge)
+            it "should do nothing if it is :purged" do
+                @provider.expects(:properties).returns(:ensure => :purged)
                 @catalog.apply
             end
+
+            [:absent, :installed, :present, :latest].each do |state|
+                it "should purge if it is #{state.to_s}" do
+                    @provider.stubs(:properties).returns(:ensure => state)
+                    @provider.expects(:purge)
+                    @catalog.apply
+                end
+            end
         end
-    end
 
-    describe Puppet::Type.type(:package), "when it should be absent" do
-        include PackageEvaluationTesting
+        describe Puppet::Type.type(:package), "when it should be absent" do
+            include PackageEvaluationTesting
 
-        before { @package[:ensure] = :absent }
+            before { @package[:ensure] = :absent }
 
-        [:purged, :absent].each do |state|
-            it "should do nothing if it is #{state.to_s}" do
-                @provider.expects(:properties).returns(:ensure => state)
-                @catalog.apply
+            [:purged, :absent].each do |state|
+                it "should do nothing if it is #{state.to_s}" do
+                    @provider.expects(:properties).returns(:ensure => state)
+                    @catalog.apply
+                end
             end
-        end
 
-        [:installed, :present, :latest].each do |state|
-            it "should uninstall if it is #{state.to_s}" do
-                @provider.stubs(:properties).returns(:ensure => state)
-                @provider.expects(:uninstall)
-                @catalog.apply
+            [:installed, :present, :latest].each do |state|
+                it "should uninstall if it is #{state.to_s}" do
+                    @provider.stubs(:properties).returns(:ensure => state)
+                    @provider.expects(:uninstall)
+                    @catalog.apply
+                end
             end
         end
-    end
 
-    describe Puppet::Type.type(:package), "when it should be present" do
-        include PackageEvaluationTesting
+        describe Puppet::Type.type(:package), "when it should be present" do
+            include PackageEvaluationTesting
 
-        before { @package[:ensure] = :present }
+            before { @package[:ensure] = :present }
 
-        [:present, :latest, "1.0"].each do |state|
-            it "should do nothing if it is #{state.to_s}" do
-                @provider.expects(:properties).returns(:ensure => state)
-                @catalog.apply
+            [:present, :latest, "1.0"].each do |state|
+                it "should do nothing if it is #{state.to_s}" do
+                    @provider.expects(:properties).returns(:ensure => state)
+                    @catalog.apply
+                end
             end
-        end
 
-        [:purged, :absent].each do |state|
-            it "should install if it is #{state.to_s}" do
-                @provider.stubs(:properties).returns(:ensure => state)
-                @provider.expects(:install)
-                @catalog.apply
+            [:purged, :absent].each do |state|
+                it "should install if it is #{state.to_s}" do
+                    @provider.stubs(:properties).returns(:ensure => state)
+                    @provider.expects(:install)
+                    @catalog.apply
+                end
             end
         end
-    end
 
-    describe Puppet::Type.type(:package), "when it should be latest" do
-        include PackageEvaluationTesting
+        describe Puppet::Type.type(:package), "when it should be latest" do
+            include PackageEvaluationTesting
+
+            before { @package[:ensure] = :latest }
 
-        before { @package[:ensure] = :latest }
+            [:purged, :absent].each do |state|
+                it "should upgrade if it is #{state.to_s}" do
+                    @provider.stubs(:properties).returns(:ensure => state)
+                    @provider.expects(:update)
+                    @catalog.apply
+                end
+            end
 
-        [:purged, :absent].each do |state|
-            it "should upgrade if it is #{state.to_s}" do
-                @provider.stubs(:properties).returns(:ensure => state)
+            it "should upgrade if the current version is not equal to the latest version" do
+                @provider.stubs(:properties).returns(:ensure => "1.0")
+                @provider.stubs(:latest).returns("2.0")
                 @provider.expects(:update)
                 @catalog.apply
             end
-        end
 
-        it "should upgrade if the current version is not equal to the latest version" do
-            @provider.stubs(:properties).returns(:ensure => "1.0")
-            @provider.stubs(:latest).returns("2.0")
-            @provider.expects(:update)
-            @catalog.apply
-        end
+            it "should do nothing if it is equal to the latest version" do
+                @provider.stubs(:properties).returns(:ensure => "1.0")
+                @provider.stubs(:latest).returns("1.0")
+                @provider.expects(:update).never
+                @catalog.apply
+            end
 
-        it "should do nothing if it is equal to the latest version" do
-            @provider.stubs(:properties).returns(:ensure => "1.0")
-            @provider.stubs(:latest).returns("1.0")
-            @provider.expects(:update).never
-            @catalog.apply
+            it "should do nothing if the provider returns :present as the latest version" do
+                @provider.stubs(:properties).returns(:ensure => :present)
+                @provider.stubs(:latest).returns("1.0")
+                @provider.expects(:update).never
+                @catalog.apply
+            end
         end
 
-        it "should do nothing if the provider returns :present as the latest version" do
-            @provider.stubs(:properties).returns(:ensure => :present)
-            @provider.stubs(:latest).returns("1.0")
-            @provider.expects(:update).never
-            @catalog.apply
-        end
-    end
+        describe Puppet::Type.type(:package), "when it should be a specific version" do
+            include PackageEvaluationTesting
 
-    describe Puppet::Type.type(:package), "when it should be a specific version" do
-        include PackageEvaluationTesting
+            before { @package[:ensure] = "1.0" }
 
-        before { @package[:ensure] = "1.0" }
+            [:purged, :absent].each do |state|
+                it "should install if it is #{state.to_s}" do
+                    @provider.stubs(:properties).returns(:ensure => state)
+                    @provider.expects(:install)
+                    @catalog.apply
+                end
+            end
 
-        [:purged, :absent].each do |state|
-            it "should install if it is #{state.to_s}" do
-                @provider.stubs(:properties).returns(:ensure => state)
-                @provider.expects(:install)
+            it "should do nothing if the current version is equal to the desired version" do
+                @provider.stubs(:properties).returns(:ensure => "1.0")
+                @provider.expects(:install).never
                 @catalog.apply
             end
-        end
-
-        it "should do nothing if the current version is equal to the desired version" do
-            @provider.stubs(:properties).returns(:ensure => "1.0")
-            @provider.expects(:install).never
-            @catalog.apply
-        end
 
-        it "should install if the current version is not equal to the specified version" do
-            @provider.stubs(:properties).returns(:ensure => "2.0")
-            @provider.expects(:install)
-            @catalog.apply
+            it "should install if the current version is not equal to the specified version" do
+                @provider.stubs(:properties).returns(:ensure => "2.0")
+                @provider.expects(:install)
+                @catalog.apply
+            end
         end
     end
 end

-- 
Puppet packaging for Debian