[Pkg-puppet-devel] Bug#653439: "puppet agent --disable" doesn't disable if puppet agent is already running

[Andrei POPESCU]

Package: puppet
Version: 2.6.2-5+squeeze3
Severity: normal

Hi,

This is probably upstream, but...

Running 'puppet agent --disable' while puppet agent is already running 
will not disable the agent, nor will it inform the admin about this (not 
even with --verbose). 

I would suggest that --disable check for an existing lockfile and 
depending on its contents

if it contains a pid exit with a message like "puppet agent already 
running, retry later - puppet agent NOT disabled"
if it doesn't have a pid exit with a message like "puppet agent already 
disabled".

Does this make sense?

Thanks,
Andrei


-- System Information:
Debian Release: 6.0.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.39-bpo.2-amd64 (SMP w/2 CPU cores)
Locale: LANG=ro_RO.UTF-8, LC_CTYPE=ro_RO.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages puppet depends on:
ii  adduser              3.112+nmu2          add and remove users and groups
ii  facter               1.5.7-3             a library for retrieving facts fro
pn  libopenssl-ruby      <none>              (no description available)
ii  libruby [libxmlrpc-r 4.5                 Libraries necessary to run Ruby 1.
ii  libshadow-ruby1.8    1.4.1-8             Interface of shadow password for R
ii  lsb-base             3.2-23.2squeeze1    Linux Standard Base 3.2 init scrip
ii  puppet-common        2.6.2-5+squeeze3    Centralized configuration manageme
ii  ruby1.8              1.8.7.302-2squeeze1 Interpreter of object-oriented scr

Versions of packages puppet recommends:
ii  libaugeas-ruby1.8             0.3.0-1.1  Augeas bindings for the Ruby langu
ii  ruby [rdoc]                   4.5        An interpreter of object-oriented 

Versions of packages puppet suggests:
pn  libselinux-ruby1.8      <none>           (no description available)
pn  puppet-el               <none>           (no description available)
ii  vim-puppet              2.6.2-5+squeeze3 syntax highlighting for puppet man

-- Configuration Files:
/etc/default/puppet changed [not included]

-- no debconf information