[Pkg-puppet-devel] Bug#703204: unblock: puppet/2.7.18-4

[Stig Sandbeck Mathisen]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock

Please unblock package puppet

A bug (http://bugs.debian.org/698294)  prevents the use of symbolic links at
the source when using puppet to distribute files; they fail with a checksum
error.  This is a regression from puppet in stable.  Puppet Labs recently
included the fix for this bug into their 2.7.x maintenance branch.

A test with puppet 2.7.18-3 (with the bug) and 2.7.18-4 (bug fixed) shows the
following:

,----[ setup ]
| # echo testing > testfile
| # ln -s testfile testlink
| # md5sum testfile 
| eb1a3227cdc3fedbaec2fe38bf6c044a  testfile
`----

,----[ test with 2.7.18-3 ]
| # dpkg -i /home/ssm/Debian/pbuilder/unstable_result/{puppet-common,puppetmaster-common,puppetmaster}_2.7.18-3_all.deb
| # puppet resource file $(pwd)/newfile ensure=file links=follow source=$(pwd)/testlink mode=0644
| err: /File[/root/newfile]/ensure: change from absent to present
| failed: Could not rename temporary file /root/newfile.puppettmp_1534
| to /root/newfile: File written to disk did not match checksum;
| discarding changes ( vs {md5}d41d8cd98f00b204e9800998ecf8427e)
| file { '/root/newfile':
|   ensure => 'absent',
| }
`----

,----[ test with 2.7.18-4 ]
| # dpkg -i /home/ssm/Debian/pbuilder/unstable_result/{puppet-common,puppetmaster-common,puppetmaster}_2.7.18-4_all.deb
| # puppet resource file $(pwd)/newfile ensure=file links=follow source=$(pwd)/testlink mode=0644
| notice: /File[/root/newfile]/ensure: defined content as '{md5}eb1a3227cdc3fedbaec2fe38bf6c044a'
| file { '/root/newfile':
|   ensure  => 'file',
|   content => '{md5}eb1a3227cdc3fedbaec2fe38bf6c044a',
|   group   => '0',
|   mode    => '644',
|   owner   => '0',
| }
`----

The list of patches are taken from
https://github.com/puppetlabs/puppet/pull/1532, minus one patch for a newer
puppet version, and area added to the packaging as follows (debdiff also
attached):

* fix-symlink-1-ee4c6f7c697737aa919b9f90436ab0cc69934b03
  fixes broken tests, which prevented the fix from being accepted.

* fix-symlink-2-1b0e812ad9e33b3cc148fac30a28490f60f40c63
  the actual bugfix. Two lines changed. :)

* fix-symlink-3-3a00ed468617c17b5a527c68cfc37d7d1fddaa72
  updates tests to reflect new behaviour

* fix-symlink-4-1d8a76e060f610a9db20cf1bdd4ff95dddba9309
  add acceptance test

Since we also package the tests as "puppet-testsuite", the patches updating the
tests are included.

unblock puppet/2.7.18-4

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
-------------- next part --------------
A non-text attachment was scrubbed...
Name: puppet_2.7.18-4.debdiff
Type: text/x-diff
Size: 14367 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20130316/0a8c61be/attachment.diff>