[Pkg-puppet-devel] [facter] 64/352: (Maint) Change canonize to canonicalize

Stig Sandbeck Mathisen ssm at debian.org
Sun Apr 6 22:21:32 UTC 2014


This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit 132c25ebf5115b60996c67ada4b96d5db450b58e
Author: Josh Cooper <josh at puppetlabs.com>
Date:   Thu Dec 5 22:12:24 2013 -0800

    (Maint) Change canonize to canonicalize
    
    To canonize is to officially declare a dead person to be a saint,
    which isn't what we want.
---
 lib/facter/util/collection.rb | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/facter/util/collection.rb b/lib/facter/util/collection.rb
index cb9359b..7c02ce0 100644
--- a/lib/facter/util/collection.rb
+++ b/lib/facter/util/collection.rb
@@ -21,7 +21,7 @@ class Facter::Util::Collection
   # Add a resolution mechanism for a named fact.  This does not distinguish
   # between adding a new fact and adding a new way to resolve a fact.
   def add(name, options = {}, &block)
-    name = canonize(name)
+    name = canonicalize(name)
 
     unless fact = @facts[name]
       fact = Facter::Util::Fact.new(name)
@@ -78,7 +78,7 @@ class Facter::Util::Collection
 
   # Return a fact by name.
   def fact(name)
-    name = canonize(name)
+    name = canonicalize(name)
 
     # Try to load the fact if necessary
     load(name) unless @facts[name]
@@ -143,9 +143,7 @@ class Facter::Util::Collection
 
   private
 
-  # Provide a consistent means of getting the exact same fact name
-  # every time.
-  def canonize(name)
+  def canonicalize(name)
     name.to_s.downcase.to_sym
   end
 end

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git



More information about the Pkg-puppet-devel mailing list