[Pkg-puppet-devel] [facter] 201/352: (FACT-273) Always log warnings regardless of log level

Stig Sandbeck Mathisen ssm at debian.org
Sun Apr 6 22:21:45 UTC 2014


This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit 6c6c3945d558849610f2b58b2d04c63498c9c0f1
Author: Adrien Thebo <git at somethingsinistral.net>
Date:   Mon Feb 3 11:06:00 2014 -0800

    (FACT-273) Always log warnings regardless of log level
    
    If a class is trying to emit a warning the expected behavior is to log
    it, since if it's worth warning about it's worth seeing every time, and
    if it's not worth warning about every time about then it should debug
    message. This commit ensures that all warnings are actually handled.
---
 lib/facter/core/logging.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/facter/core/logging.rb b/lib/facter/core/logging.rb
index a573f4a..185440d 100644
--- a/lib/facter/core/logging.rb
+++ b/lib/facter/core/logging.rb
@@ -52,7 +52,7 @@ module Facter::Core::Logging
   #
   # @return [void]
   def warn(msg)
-    if self.debugging? and msg and not msg.empty?
+    if msg and not msg.empty?
       Kernel.warn msg
     end
   end

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git



More information about the Pkg-puppet-devel mailing list