[Pkg-puppet-devel] [facter] 211/352: (fact-273) Return a string for stub of :kernel fact

Stig Sandbeck Mathisen ssm at debian.org
Sun Apr 6 22:21:46 UTC 2014


This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit d56f472c2ffda12e572f8f849513efc34dc81b66
Author: Kylo Ginsberg <kylo at puppetlabs.com>
Date:   Wed Feb 5 13:28:34 2014 -0800

    (fact-273) Return a string for stub of :kernel fact
    
    Previous to this change, this spec test was stubbing :kernel
    as :windows. But now facter a) does type-checking on fact
    values (Symbol is not allowed) and b) warns on type-check
    errors.
    
    Changing this stub to return 'windows' reduces warning
    messages during spec runs.
---
 spec/unit/util/macaddress_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/unit/util/macaddress_spec.rb b/spec/unit/util/macaddress_spec.rb
index 17e5500..7435dfb 100755
--- a/spec/unit/util/macaddress_spec.rb
+++ b/spec/unit/util/macaddress_spec.rb
@@ -90,7 +90,7 @@ describe "The macaddress fact" do
     include FacterSpec::WindowsNetwork
 
     before :each do
-      Facter.fact(:kernel).stubs(:value).returns(:windows)
+      Facter.fact(:kernel).stubs(:value).returns('windows')
       Facter::Util::Registry.stubs(:hklm_read).returns(nic_bindings)
     end
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git



More information about the Pkg-puppet-devel mailing list