[Pkg-puppet-devel] [facter] 229/352: (FACT-321) Remove deprecated 'memorytotal' fact

Stig Sandbeck Mathisen ssm at debian.org
Sun Apr 6 22:21:48 UTC 2014


This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit 1d876748f3d619ec4ab1a9092327b6002face557
Author: Adrien Thebo <git at somethingsinistral.net>
Date:   Thu Feb 6 10:54:38 2014 -0800

    (FACT-321) Remove deprecated 'memorytotal' fact
---
 lib/facter/memory.rb     | 11 -----------
 spec/unit/memory_spec.rb |  7 -------
 2 files changed, 18 deletions(-)

diff --git a/lib/facter/memory.rb b/lib/facter/memory.rb
index a8b0590..b9f1d82 100644
--- a/lib/facter/memory.rb
+++ b/lib/facter/memory.rb
@@ -160,14 +160,3 @@ Facter.add("swapfree_mb") do
     "%.2f" % [(swapfree.to_f / 1024.0) / 1024.0]
   end
 end
-
-# http://projects.puppetlabs.com/issues/11436
-#
-# Unifying naming for the amount of physical memory in a given host.
-# This fact is DEPRECATED and will be removed in Facter 2.0 per
-# http://projects.puppetlabs.com/issues/11466
-Facter.add("MemoryTotal") do
-  setcode do
-    Facter.value("memorysize")
-  end
-end
diff --git a/spec/unit/memory_spec.rb b/spec/unit/memory_spec.rb
index 311a742..dd1eb76 100755
--- a/spec/unit/memory_spec.rb
+++ b/spec/unit/memory_spec.rb
@@ -534,13 +534,6 @@ SWAP
         Facter::Util::WMI.stubs(:execquery).returns([computer])
 
         Facter.fact(:memorysize_mb).value.should == '3999.55'
-        Facter.fact(:MemoryTotal).value.should == '3.91 GB'
     end
   end
-
-  it "should use the memorysize fact for the memorytotal fact" do
-    Facter.fact("memorysize").expects(:value).once.returns "16.00 GB"
-    Facter::Util::Resolution.expects(:exec).never
-    Facter.fact(:memorytotal).value.should == "16.00 GB"
-  end
 end

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git



More information about the Pkg-puppet-devel mailing list