[Pkg-puppet-devel] [facter] 247/352: (maint) Remove nonfunctional tests

[Stig Sandbeck Mathisen]

This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit 71f650f364b908ad624515b1efe9d6c873ae56dc
Author: Adrien Thebo <git at somethingsinistral.net>
Date:   Tue Feb 11 17:56:36 2014 -0800

    (maint) Remove nonfunctional tests
    
    Passing a block to #expects() ignores the passed block which means that
    this code was catching the wrong thing and we don't want to test this
    anyways.
---
 spec/unit/core/aggregate_spec.rb | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/spec/unit/core/aggregate_spec.rb b/spec/unit/core/aggregate_spec.rb
index f22d150..64b4450 100644
--- a/spec/unit/core/aggregate_spec.rb
+++ b/spec/unit/core/aggregate_spec.rb
@@ -98,17 +98,6 @@ describe Facter::Core::Aggregate do
     end
   end
 
-  describe "evaluating chunks" do
-    it "emits a warning and returns nil when a chunk raises an error" do
-      Facter.expects(:warn) do |msg|
-        expect(msg).to match /Could not run chunk boom.*kaboom!/
-      end
-
-      subject.chunk(:boom) { raise 'kaboom!' }
-      subject.value
-    end
-  end
-
   describe "aggregating chunks" do
     it "passes all chunk results as a hash to the aggregate block" do
       subject.chunk(:data) { 'data chunk' }
@@ -125,16 +114,6 @@ describe Facter::Core::Aggregate do
       subject.aggregate { "who needs chunks anyways" }
       expect(subject.value).to eq "who needs chunks anyways"
     end
-
-    it "generates a warning and returns if the aggregate raises an error" do
-      subject.aggregate { raise 'kaboom!' }
-
-      Facter.expects(:warn) do |msg|
-        expect(msg).to match /Could not aggregate chunks for boom.*kaboom!/
-      end
-
-      subject.value
-    end
   end
 
   describe "evaluating" do

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git