[Pkg-puppet-devel] Bug#738465: puppetmaster: Init script returns exit 4 for status when not running

[Daniel 'DaB.' Baur]

Package: puppetmaster
Version: 2.7.23-1~deb7u3
Severity: normal
Tags: patch

Hello,

/etc/init.d/puppetmaster status returns a 4 if the puppet-master is not
running. This habbens because its pid-file can not be found. The
return-code of 4 confuses the pacemaker/corosync here, so I had to patch
the init-file localy to return a 3 if there is no pid-file. Maybe you could
include it in a coming version.

Thanks for your great service :-).

Sincerley,
DaB.

--patch starts ---
--- /tmp/puppetmaster   2014-01-13 19:03:52.000000000 +0000
+++ /etc/init.d/puppetmaster    2014-02-09 20:24:57.000000000 +0000
@@ -52,6 +52,10 @@
 }
 
 status_puppet_master() {
+    if [ ! -e "/var/run/puppet/${NAME}.pid" ]; then
+       echo "Not running."
+        exit 3
+    fi                                               
     status_of_proc -p "/var/run/puppet/${NAME}.pid" "${DAEMON}" "${NAME}"
 }

--patch ends ---

-- System Information:
Debian Release: 6.0.8
  APT prefers oldstable
  APT policy: (500, 'oldstable'), (400, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages puppetmaster depends on:
ii  puppetmaster-common 2.7.23-1~deb7u3      Puppet master common scripts
ii  ruby1.8             1.8.7.358-7.1+deb7u1 Interpreter of object-oriented scr

puppetmaster recommends no packages.

puppetmaster suggests no packages.

-- Configuration Files:
/etc/default/puppetmaster changed [not included]
/etc/init.d/puppetmaster changed [not included]

-- no debconf information