[Pkg-puppet-devel] [facter] 146/180: (maint) Ensure gems are not required in Gemfile

Stig Sandbeck Mathisen ssm at debian.org
Mon Jun 30 15:06:41 UTC 2014


This is an automated email from the git hooks/post-receive script.

ssm pushed a commit to branch master
in repository facter.

commit 743b81f5fb52f9cf6f77b8b807d4abdb5f461647
Author: Josh Cooper <josh at puppetlabs.com>
Date:   Wed Jun 18 11:46:32 2014 -0700

    (maint) Ensure gems are not required in Gemfile
    
    Previously, I omitted the `require => false` line in the Gemfile,
    which means bundler will magically require the library. That's ok
    when running from source, but if Facter is not running from source
    and forgets to explicity require a gem, then Facter will fail hard.
    
    This commit ensure Facter explicitly requires all Windows dependencies.
---
 Gemfile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Gemfile b/Gemfile
index 1f15099..35fa8b2 100644
--- a/Gemfile
+++ b/Gemfile
@@ -32,16 +32,16 @@ data['gem_platform_dependencies'].each_pair do |gem_platform, info|
 end
 
 platform(:mingw_19) do
-  gem 'win32console', '~> 1.3.2'
+  gem 'win32console', '~> 1.3.2', :require => false
 end
 
 mingw = [:mingw]
 mingw << :x64_mingw if Bundler::Dsl::VALID_PLATFORMS.include?(:x64_mingw)
 
 platform(*mingw) do
-  gem 'ffi', '~> 1.9.3'
-  gem 'win32-dir', '~> 0.4.8'
-  gem 'win32-security', '~> 0.2.5'
+  gem 'ffi', '~> 1.9.3', :require => false
+  gem 'win32-dir', '~> 0.4.8', :require => false
+  gem 'win32-security', '~> 0.2.5', :require => false
 end
 
 gem 'facter', ">= 1.0.0", :path => File.expand_path("..", __FILE__)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-puppet/facter.git



More information about the Pkg-puppet-devel mailing list