[Pkg-puppet-devel] Bug#775795: Patch to use /usr/sbin/service in Debian service provider

[Gaudenz Steinlin]

Hi

Gaudenz Steinlin <gaudenz at debian.org> writes:

> Stephen Gran <sgran at debian.org> writes:
>
>> Hi,
>>
>> This one time, at band camp, Stig Sandbeck Mathisen said:
>>> 
>>> Hello,
>>> 
>>> Thanks for the patch.  It looks like it has the correct solution, using
>>> the Debian abstraction layer over the alternative init systems.
>>> 
>>> However, I've found a problem with it using the "puppet resource"
>>> command. Could you see if you find what causes it?
>
> The idea in my patch is to add the service_cmd definition to ensure that
> this provider is only choosen if the service command is available. But
> you can't use this command because of the way the provider works. The
> problem is that startcmd, stopcmd, etc. should return an array with the
> command and it's argument.
>
> The problem is probably that I replaced the hardcoded /usr/sbin/service
> by a variable after testing the patch and screwed that up somehow. I'm
> right now looking into this and will send a new patch as soon as it's
> fixed.

Attached is an updated patch that uses a propoer Ruby constant for
/usr/sbin/service. The first patch was botched by my "Pythonistic"
approach to code this.

>
> If I understand Stephens patch correctly it directly executes the
> service comamnd during the call to XXXcmd. As far as I can see this is
> not the way things should work (looking at provider/service/base.rb).

I did not manage to get this patch to run at all :-(.

Gaudenz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-usr-sbin-service-in-Debian-service-provider.patch
Type: text/x-diff
Size: 3191 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150205/8a42152a/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150205/8a42152a/attachment-0001.sig>