[Pkg-puppet-devel] Bug#774643: verify_active_connections is not present in ruby-activerecord 4.1.8

[intrigeri]

Hi,

intrigeri wrote (09 Feb 2015 15:02:36 GMT) :
> Adding the previous maintainers of ruby-activerecord-3.2 into the
> loop, in case they have an idea. E.g. would it be an option to
> reintroduce the 'verify_active_connections!' method from 3.2 into
> Jessie's ActiveRecord::Base:Class? (I guess not, but if it is, then it
> would possibly be the easiest way forward.)

I gave this option a try, and failed. Here's what I see in the journal:

  puppet-master[25887]: ActiveRecord-based storeconfigs and inventory are deprecated. See http://links.puppetlabs.com/activerecord-deprecation
  puppet-master[25887]: (at /usr/lib/ruby/vendor_ruby/puppet/indirector/facts/active_record.rb:13:in `initialize')
  puppet-master[25887]: Cached facts for jenkins.lizard failed: wrong number of arguments (2 for 1)
  puppet-master[25887]: Could not retrieve facts for jenkins.lizard: Couldn't find all Puppet::Rails::FactValues with 'id': (all, {:include=>:fact_name}) [WHERE "fact_values"."host_id" = ?] (found 0 results, but was looking for 2)

My Ruby skills are poor, and the affected area (connection pool
handling) has seen quite some refactoring since 3.x so it was a bit
ambitious for me to try. Perhaps someone who knows Ruby or the Rails
codebase better would easily success where I failed :)

I'm attaching the patches I've added to debian/patches/, and the
resulting debian/patches/series, in case someone wants to try and
avoid starting from scratch. Any taker?

Cheers,
--
intrigeri

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Revert-removes-verify_active_connections.patch
Type: text/x-diff
Size: 2473 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150227/9f69b4ba/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deprecated-clear_stale_active_connections-can-call-r.patch
Type: text/x-diff
Size: 1124 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150227/9f69b4ba/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Adjust-reintroduced-verify_active_connections-to-mat.patch
Type: text/x-diff
Size: 1117 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150227/9f69b4ba/attachment-0002.patch>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: series
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150227/9f69b4ba/attachment.ksh>