[Pkg-puppet-devel] Bug#778891: Bug#778891: puppet: systemd unit file does not load environment from /etc/default/puppet - breaks upgrades

[Apollon Oikonomopoulos]

Hi all,

I'd like to note that since 3.2.4-1, the package's maintainer scripts 
actually _remove_ /etc/default/puppet if it's unmodified or save it as 
/etc/default/puppet.dpkg-bak if it has been modified by the user. The 
latter means that even for sysvinit users where the initscript is 
functional, upgrading from wheezy to jessie will break their setups if 
they used /etc/default/puppet to pass daemon arguments.

In my understanding to fix all of these issues the following actions are 
required:

 - change puppet.service to read /etc/default/puppet and use 
   $DAEMON_OPTS.

 - remove the dpkg-maintscript-helper rm_conffile calls from the 
   maintainer scripts. We still will not be shipping 
   /etc/default/puppet, put we don't want to remove it since the 
   initscript and the systemd unit file will be using it if it exists.

 - apart from new installations, also disable the agent when upgrading 
   from pre-3.2.4-1 versions if /etc/default/puppet exists *and* $START 
   is not true.

If so, the attached patch should¹ fix this bug.

Regards,
Apollon

¹ still untested
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 778891.diff
Type: text/x-diff
Size: 5155 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150310/517be2e5/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20150310/517be2e5/attachment.sig>