[Pkg-puppet-devel] Bug#859454: puppet: package upgrade fails due to preinst not stopping puppet daemon

[Dan Urist]

Package: puppet
Version: 4.8.2-3~bpo8+1
Severity: important

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

It appears that there is no check for a running puppet daemon in the preinst phase of the package installation. The preinst phase should check whether the puppet daemon is running and stop it, but apparently it doesn't do that, so the upgrade fails at the end when it attempts to start the puppet daemon since the old daemon is still running. If I manually stop the daemon before upgrade, the upgrade proceeds without error, and the puppet agent is started at the end of the process.

Note that I am using sysvinit (rather than systemd).

Here are the errors from apt-get (following the running puppet agent's own attempt to install the packages; hence the "not fully installed" state):

# apt-get dist-upgrade
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
2 not fully installed or removed.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] 
Setting up puppet (4.8.2-3~bpo8+1) ...
[FAIL] Starting puppet agent failed!
invoke-rc.d: initscript puppet, action "start" failed.
dpkg: error processing package puppet (--configure):
 subprocess installed post-installation script returned error exit status 1
dpkg: dependency problems prevent configuration of puppet-common:
 puppet-common depends on puppet; however:
  Package puppet is not configured yet.
dpkg: error processing package puppet-common (--configure):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 puppet
 puppet-common

-- System Information:
Debian Release: 8.7
Architecture: amd64 (x86_64)

Kernel: Linux 4.1.35-vs2.3.8.5.2-beng (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages puppet depends on:
ii  adduser                     3.113+nmu3
ii  facter                      2.4.6-1~bpo8+1
ii  hiera                       1.3.4-1
ii  init-system-helpers         1.22
ii  lsb-base                    4.1+Debian13+nmu1
ii  ruby                        1:2.1.5+deb8u2
ii  ruby-augeas                 0.5.0-2+b2
ii  ruby-deep-merge             1.1.1-1~bpo8+1
ii  ruby-rgen                   0.7.0-1
ii  ruby-safe-yaml              1.0.3-1
ii  ruby-shadow                 2.3.4-2
ii  ruby2.1 [ruby-interpreter]  2.1.5-2+deb8u3

Versions of packages puppet recommends:
ii  debconf-utils  1.5.56
ii  lsb-release    4.1+Debian13+nmu1
ii  ruby-selinux   2.3-2

Versions of packages puppet suggests:
pn  ruby-rrd  <none>

-- Configuration Files:
/etc/puppet/puppet.conf changed [not included]

-- no debconf information