[Pkg-puppet-devel] Bug#851967: unattended-upgrades broken with more than one origin

[Mike Gabriel]

Package: puppet-module-puppetlabs-apt
Version: 1.4.2-1
Severity: important
Tags: patch

Dear maintainer,

This week I tested APT / unattended-upgrades management for puppet on a Debian
jessie machine. The config patch that added the feature on our side is this:

```
diff --git a/manifests/site.pp b/manifests/site.pp
index 72db306..2a411d8 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1,3 +1,5 @@
+include apt
+
 class ssh_pubkeys_admins {
    # Mike Gabriel, IT-Zukunft Schule
    ssh_authorized_key { 'mike at minobo':
@@ -65,6 +67,27 @@ node "all_hosts" {
    class { 'ssh_pubkeys_admins': }
    class { 'ssh_pubkeys_firedadmins': }
 #	class { 'login_manager': }
+
+	# settings appropriate for workstation hosts
+	class { 'apt::unattended_upgrades': 
+		origins => [
+			'o=Debian,n=${distro_codename}',
+			'o=Debian,n=${distro_codename}-updates',
+			'o=Debian,n=${distro_codename},l=Debian-Security',
+			'o=IT-Zukunft Schule,n=${distro_codename},l=IT-Zukunft Schule',
+		],
+		update => "1",
+		download => "1",
+		upgrade => "1",
+		autoclean => "7",
+		auto_fix => true,
+		minimal_steps => true,
+		install_on_shutdown => false,
+		remove_unused => true,
+		auto_reboot => false,
+		download_delta => "1",
+	}
+
 }
 
 node "all_servers" {
```

The resulting /etc/apt/apt.conf.d/50unattended-upgrades did not really
work afterwards. It worked with one origin in the above snippet though,
but not with more than one.

I checked the 50unattended-upgrades template file in this package and
patched it (like seen in the attached .debdiff) and then things worked.

Could you please upload a fixed puppet-module-puppetlabs-apt to
jessie-pu, please? If needed, I can help with the Release Team
formalities. Please let me know.

Thanks,
Mike

-- System Information:
Debian Release: 8.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'proposed-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: puppet-module-puppetlabs-apt_1.4.2-1_1.4.2-1+deb8u1.debdiff
Type: text/x-diff
Size: 2093 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20170120/ff39ec92/attachment.diff>