[Pkg-puppet-devel] Bug#879230: puppet-common: puppet warns about a duplicate key :queue_type in defaults.rb on every run

[Gabriel Filion]

Package: puppet-common
Version: 3.7.2-4+deb8u1
Severity: minor
Tags: patch

Hello,

I'm running puppet 3.7 from jessie with ruby 2.3 in stretch (I know this
is a bit convoluted, but that's because the master is still running 3.7)

On every run of the puppet client, I'm getting the following warning
message:

/usr/lib/ruby/vendor_ruby/puppet/defaults.rb:465: warning: key :queue_type is duplicated and overwritten on line 466

Indeed by looking at the code, key :queue_type is defined twice
in a row with the exact same value. removing the second occurrence as in
the diff below removes the warning message:


# diff -burN /usr/lib/ruby/vendor_ruby/puppet/defaults.rb.orig /usr/lib/ruby/vendor_ruby/puppet/defaults.rb
--- /usr/lib/ruby/vendor_ruby/puppet/defaults.rb.orig	2017-10-20 15:06:15.417868622 -0400
+++ /usr/lib/ruby/vendor_ruby/puppet/defaults.rb	2017-10-20 15:06:20.518122058 -0400
@@ -463,10 +463,6 @@
       :default    => "stomp",
       :desc       => "Which type of queue to use for asynchronous processing.",
     },
-    :queue_type => {
-      :default    => "stomp",
-      :desc       => "Which type of queue to use for asynchronous processing.",
-    },
     :queue_source => {
       :default    => "stomp://localhost:61613/",
       :desc       => "Which type of queue to use for asynchronous processing.  If your stomp server requires


v- below information was modified manually.. I'm not reporting from the
affected machine. so there might be some inconsistencies.

-- System Information:
Debian Release: stretch
  APT prefers stretch
  APT policy: (500, 'stretch')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-4-amd64 #1 SMP
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8), LANGUAGE=en_CA.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages puppet-common depends on:
ii  puppet  3.7.2-4+deb8u1

puppet-common recommends no packages.

puppet-common suggests no packages.

-- no debconf information