[Pkg-puppet-devel] Bug#981566: puppet: Fix further dep8 test that requires a 'no proxy' entry to work with a proxied autopkgtest

[Neil Wilson]

Package: puppet
Version: 5.5.22-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch

*** /tmp/tmpcldu3hrj/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

This change allows autopkgtest to complete when run through a proxy 
(as it is with the release system in Ubuntu)

    - d/t/control: fix second dep8 test by telling it to not use a proxy
      for the "puppet" hostname, and allow stderr because of a ruby
      deprecation warning

Thanks for considering the patch.


-- System Information:
Debian Release: bullseye/sid
  APT prefers focal-updates
  APT policy: (500, 'focal-updates'), (500, 'focal-security'), (500, 'focal')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-65-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru puppet-5.5.22/debian/tests/control puppet-5.5.22/debian/tests/control
--- puppet-5.5.22/debian/tests/control	2020-09-24 12:45:17.000000000 +0000
+++ puppet-5.5.22/debian/tests/control	2021-02-01 13:51:27.000000000 +0000
@@ -2,9 +2,9 @@
 Depends: puppet,ruby-serverspec
 Restrictions: needs-root,isolation-container
 
-Test-Command: cd debian/tests && (puppet cert print $(hostname --fqdn) >/dev/null 2>&1 || puppet cert generate $(hostname --fqdn) --dns_alt_names=puppet) && rspec spec/puppet-master/*_spec.rb
+Test-Command: cd debian/tests && (puppet cert print $(hostname --fqdn) >/dev/null 2>&1 || puppet cert generate $(hostname --fqdn) --dns_alt_names=puppet) && no_proxy=puppet,$no_proxy rspec spec/puppet-master/*_spec.rb
 Depends: puppet-master,ruby-serverspec
-Restrictions: needs-root,isolation-container
+Restrictions: needs-root,isolation-container,allow-stderr
 
 Test-Command: cd debian/tests && no_proxy=puppet,$no_proxy rspec spec/puppet-master-passenger/*_spec.rb
 Depends: puppet-master-passenger,ruby-serverspec,curl