[Pkg-puppet-devel] Bug#1050337: Bug#1050337: puppetserver: missing Recommends on puppet-module-puppetlabs-mailalias-core

[Antoine Beaupré]

On 2023-08-23 13:31:43, Cyril Brulebois wrote:
> Package: puppetserver
> Version: 7.9.5-2
> Severity: important
>
> Hi,
>
> One of the problems that showed up while upgrading my puppet
> {master,server} from bullseye to bookworm was losing support for the
> mailalias resource. Some basic research led to discovering it's been
> split away from the core and moved to a module. One `puppet module
> install` later, that problem went away.
>
> Evgeni Golov kindly pointed out that we have a package for that module,
> and given the list of Recommends in puppetserver, it looks like it
> could and should have been there, so possibly just an oversight and not
> a deliberate decision?

There's a ton of modules like this, cron is another we had to install by
hand here. It seems like a good idea to add them to Recommends!

Here's the deprecation notice:

https://www.puppet.com/docs/puppet/6/release_notes_puppet#new_features_puppet_x-0-0-select-moved-modules-types

And that's the actual module list:

https://www.puppet.com/docs/puppet/6/type#supported-type-modules-in-puppet-agent

It seems like `cron` and `mailalias` are supported differently and cron
actually *should* have shipped with the agent. But that's kinf of a
cosmetic distinction, maybe it could be the difference between
Recommends and Suggests in our case? I would also "recommend" (no pun
intended) to *not* include any sort of dependency against the
"Deprecated types" (e.g. Nagios). What do you think?

In our case (for cron), we decided to move away from the module
altogether, towards systemd timers:

https://gitlab.torproject.org/tpo/tpa/team/-/issues/41303

Thanks for the report!

-- 
La propriété est un piège: ce que nous croyons posséder nous possède.
                        - Alphonse Karr