[Pkg-puppet-devel] Bug#1030323: /etc/default/puppet refers to non-existent /etc/init.d/puppet-agent

[Antoine Beaupre]

Package: puppet-agent
Version: 7.22.0-3
Severity: normal

Today's upgrade suggested this patch to the configuration file:

Configuration file '/etc/default/puppet'
 ==> File on system created by you or by a script.
 ==> File also in package provided by package maintainer.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** puppet (Y/I/N/O/D/Z) [default=N] ? d
--- /etc/default/puppet 2022-09-29 12:50:59.011237328 -0400
+++ /etc/default/puppet.dpkg-new        2023-01-29 10:45:20.000000000 -0500
@@ -1 +1,4 @@
-START=no
+# Defaults for puppet - sourced by /etc/init.d/puppet
+
+# Startup options
+DAEMON_OPTS=""

Yet that file doesn't exist:

cat: /etc/init.d/puppet: No such file or directory

The init file is actually /etc/init.d/puppet-agent now, so the default
file needs to be corrected.

It should also be noted (perhaps in the NEWS.Debian?) that the
previous START=no variable will probably not work to disable the agent
daemon... Considering `exit 0` in there, not sure.


-- System Information:
Debian Release: bookworm/sid
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'testing'), (500, 'stable'), (1, 'experimental'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-1-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages puppet-agent depends on:
ii  adduser                3.130
ii  debconf [debconf-2.0]  1.5.82
ii  facter                 4.2.13-2
ii  hiera                  3.10.0-1
ii  init-system-helpers    1.65.2
ii  ruby                   1:3.1
ii  ruby-augeas            1:0.5.0+gem-1
ii  ruby-concurrent        1.1.6+dfsg-5
ii  ruby-deep-merge        1.1.1-2
ii  ruby-semantic-puppet   1.0.4-1
ii  ruby-shadow            2.5.1-1
ii  ruby-sorted-set        1.0.3-3

Versions of packages puppet-agent recommends:
ii  augeas-tools   1.14.0-1
ii  debconf-utils  1.5.82
ii  lsb-release    12.0-1
ii  ruby-selinux   3.4-1+b5

Versions of packages puppet-agent suggests:
pn  hiera-eyaml                            <none>
pn  puppet-module-puppetlabs-augeas-core   <none>
pn  puppet-module-puppetlabs-cron-core     <none>
pn  puppet-module-puppetlabs-host-core     <none>
pn  puppet-module-puppetlabs-mount-core    <none>
pn  puppet-module-puppetlabs-selinux-core  <none>
pn  puppet-module-puppetlabs-sshkeys-core  <none>
pn  puppet-module-puppetlabs-stdlib        <none>
ii  ruby-hocon                             1.3.1-2
pn  ruby-msgpack                           <none>

-- Configuration Files:
/etc/puppet/puppet.conf changed [not included]

-- debconf information:
  puppet-agent/postrm_purge_data: true