[Pkg-puppet-devel] Bug#1089579: Wish: Please use Environment instead of EnvironmentFile in puppetserver.service

[Dirk Heinrichs]

Package: puppetserver
Severity: wishlist

Dear Maintainer,

in the puppetserver.service file an EnvironmentFile= setting is used to
set needed environment variables from /etc/default/puppetserver.

But because of

"Settings from these files override settings made with Environment=. If
the same variable is set twice from these files, the files will be read
in the order they are specified and the later setting will override the
earlier setting."

(see systemd.exec(5)) it's more complicated than needed to override single environment
variables using an overlay file in
/etc/systemd/system/puppetserver.service.d, because it currently also
requires another file in /etc/default, because it requires another
EnvironmentFile setting.

Moving the environment variables directly into the service file would
allow to explicitly overwrite one or more of them by simply using a
systemd overlay file.

Thanks...

    Dirk


-- System Information:
Debian Release: 12.8
  APT prefers stable-updates
  APT policy: (600, 'stable-updates'), (600, 'stable-security'), (600, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-28-cloud-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to de_DE.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages puppetserver depends on:
ii  default-jre-headless                         2:1.17-74
ii  facter                                       4.3.0-2
ii  hiera                                        3.10.0-1
pn  jruby                                        <none>
pn  libclj-time-clojure                          <none>
pn  libclj-yaml-clojure                          <none>
pn  libclojure-java                              <none>
pn  libcomidi-clojure                            <none>
pn  libcommons-exec-java                         <none>
pn  libcommons-io-java                           <none>
pn  libcommons-lang-java                         <none>
pn  libdropwizard-metrics-java                   <none>
pn  libdujour-version-check-clojure              <none>
pn  libjruby-utils-clojure                       <none>
pn  libkitchensink-clojure                       <none>
pn  libliberator-clojure                         <none>
pn  libprismatic-schema-clojure                  <none>
pn  libpuppetlabs-http-client-clojure            <none>
pn  libpuppetlabs-i18n-clojure                   <none>
pn  libpuppetlabs-ring-middleware-clojure        <none>
pn  libraynes-fs-clojure                         <none>
pn  libsemver-clojure                            <none>
pn  libshell-utils-clojure                       <none>
pn  libslingshot-clojure                         <none>
pn  libssl-utils-clojure                         <none>
pn  libtrapperkeeper-authorization-clojure       <none>
pn  libtrapperkeeper-clojure                     <none>
pn  libtrapperkeeper-comidi-metrics-clojure      <none>
pn  libtrapperkeeper-filesystem-watcher-clojure  <none>
pn  libtrapperkeeper-metrics-clojure             <none>
pn  libtrapperkeeper-scheduler-clojure           <none>
pn  libtrapperkeeper-status-clojure              <none>
pn  libtrapperkeeper-webserver-jetty9-clojure    <none>
pn  libyaml-snake-java                           <none>
ii  puppet-agent                                 7.23.0-1
ii  ruby                                         1:3.1
ii  ruby-deep-merge                              1.1.1-2
pn  ruby-fast-gettext                            <none>
pn  ruby-gettext                                 <none>
ii  ruby-hocon                                   1.3.1-2
pn  ruby-locale                                  <none>
pn  ruby-puppet-resource-api                     <none>
pn  ruby-puppetserver-ca-cli                     <none>
ii  ruby-semantic-puppet                         1.0.4-1
pn  ruby-text                                    <none>

Versions of packages puppetserver recommends:
ii  puppet-module-puppetlabs-augeas-core   1.1.2-1
ii  puppet-module-puppetlabs-cron-core     1.1.0+dfsg1-1
ii  puppet-module-puppetlabs-host-core     1.1.0-1
ii  puppet-module-puppetlabs-mount-core    1.0.4+dfsg1-2
ii  puppet-module-puppetlabs-selinux-core  1.2.0-1
ii  puppet-module-puppetlabs-sshkeys-core  2.3.0-1

puppetserver suggests no packages.