[Pkg-puppet-devel] Bug#1040767: facter: inconsistent detection of Xen dom0

[Jérôme Charaoui]

Control: reassign -1 virt-what 1.25

Le 2024-09-02 à 05 h 34, Sergio.Gelato at astro.su.se a écrit :
> On Sat, Aug 31, 2024 at 01:36:52AM +0200, Jérôme Charaoui wrote:
>> If you look at the virt-what resolver [0], it's just matching for
>> strings in the output. If the output of virt-what contains both
>> 'xen-hvm' and 'xen-dom0' then 'xenhvm' is going to be used because
>> 'xen-hvm' will match first. It's possible we might want to actually
>> match for 'xen-dom0' *first*, but this all depends on virt-what's full
>> output.
>>
>> Would it be possible to share here what virt-what is outputting both on
>> dom0 and domU?
> 
> Here is a fresh transcript from a bookworm dom0:

According to this output, it definitely looks like virt-what is at fault 
here. Reassigning.

> I also think it's wrong for the fact value to depend on whether
> virt-what is installed. (In a guest, I get "xenu" if virt-what is absent,
> "xen" if it is present. This adds unnecessary complexity to Puppet
> manifests.) As far as I'm concerned facter should not use virt-what.
> I achieve this on my systems by removing virt-what (I had to re-add it
> manually in order to produce the test output above).

At best, facter and virt-what should agree on about the virtualisation 
environment, otherwise virt-what should more precise than facter by itself.

-- Jérôme