Bug#489722: git patches to migrate to PEP 8 conformant names
Stefano Zacchiroli
zack at debian.org
Thu Sep 11 10:04:47 UTC 2008
On Mon, Jul 21, 2008 at 01:56:31PM +1000, Ben Finney wrote:
> I have updated the patch for this bug report, so that it applies
> against the current 'git' repository
> <URL:git://git.debian.org/git/pkg-python-debian/python-debian.git>,
> revision 0dd8cdb639253581f97dcd74071eef719c1247d8.
>
> The patches were generated with 'git format-patch', they should apply
> cleanly against the repository.
Thanks a lot: I've investigated with the other maintainers and no voices
against your request were raised, we will be happy to integrate your
patch (and thanks for the deprecation module, which will probably be
useful also for other stuff in the future).
Still, your patch at the moment is a bit messy and suboptimal to review.
Take for example the patch about the example
examples/debtags/tagsByRelevance; your patch first remove all the code
and then read it, probably using the right calls.
Can you please:
- provide 2 patches instead of 3: one for the deprecation module, the
other (instead of 2) for all the method renamings.
- avoid stuff like the example above and keep your patches minimal.
Once that is ready, I'll be more than happy to review, apply, and
upload.
Thanks in advance!
Cheers.
--
Stefano Zacchiroli -*- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
I'm still an SGML person,this newfangled /\ All one has to do is hit the
XML stuff is so ... simplistic -- Manoj \/ right keys at the right time
More information about the pkg-python-debian-maint
mailing list