Bug#590805: Updated patch

[John Wright]

On Mon, Aug 02, 2010 at 10:24:24PM +0200, Jelmer Vernooij wrote:
> On Sun, 2010-08-01 at 01:40 -0700, John Wright wrote:
> > On Fri, Jul 30, 2010 at 12:45:07PM +0200, Jelmer Vernooij wrote:
> > > Attached patch updates the changelog as well and removes the conflict
> > > with older versions of apt.
> > Thanks - how about this one?  It's a little simpler since the only thing
> > we use apt_pkg for in deb822 is TagFile.
> Nice, I hadn't thought of that.
> 
> > Also...are you just using the deb822 module on its own?  There are
> > plenty of dependencies in python-debian that aren't satisfiable in
> > Dapper.  Also, I just added a feature that depends on UnicodeWarning
> > being available, but that's only in python2.5.  Thinking about it,
> > though, it's better to make a new warning class anyway, hence the second
> > patch.  With both patches, I think at least deb822 should work fine in a
> > Dapper environment.
> We're using Python2.5 on Hardy at the moment, and will hopefully be
> switching to the next LTS (Lucid) in a couple of months. Sorry if I said
> dapper.

Ah, ok.  I'm rethinking the second patch - UnicodeWarning, according to
the Python documentation, is actually intended as a base category for
unicode related warnings, which this is...and if you don't need
python2.4 support, there's no need to rip it out.  (The "What's new in
Python 2.5" document suggested that the warning was intended for a very
specific problem, but the warning categories documentation makes it seem
more general.)

> > Shall I commit?
> Please do, thanks!

Ok, no problem. :)

-- 
John Wright <jsw at debian.org>