Bug#686731: edos-distcheck: Stopped to work

[Stefano Zacchiroli]

clone 686731 -1
reassign -1 edos-distcheck
retitle -1 add-sources.py should use forward compatible "in" syntax instead of "has_key"
severity -1 wishlist
tags -1 + pending
thanks

On Wed, Sep 05, 2012 at 11:20:10AM +0100, Colin Watson wrote:
> edos-distcheck should be changed to use "if field in src:" rather than
> "if src.has_key(field):" - the latter syntax will not work in Python 3.

Thanks for noticing, I've just pushed a fix for that to edos-distcheck
Git repo. (Debian OCamlers: I've tested it and it seems to work
properly, but more testing is welcome!)

> However, the regression in the Python 2 case is clearly a bug in my NMU,
> which I'll fix.

And while we're at it: thanks also for your python-debian NMU, without
which we would still be without a Python 3 port of it. Regression
happens when doing stuff: they're no big deal, especially when someone
is as quick as you've been in cleaning up after them :-)

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack at upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Debian Project Leader . . . . . . @zack on identi.ca . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-python-debian-maint/attachments/20120905/34ea0d75/attachment.pgp>