Python annotations and pylint cleansing

[Enrico Zini]

On Thu, Jul 26, 2018 at 03:08:22AM +1000, Stuart Prescott wrote:

> Please find code I would like to merge into python-debian at:
> 
> https://salsa.debian.org/python-debian-team/python-debian/merge_requests/5
> 
> This MR includes 
> 
> * type annotations (compatible with both Python 2 and 3) for the module
> * changes needed to fix bugs highlighted by the type annotations
> * changes needed to fix bugs highlighted by pylint
> * a pylint config to silence more annoying warnings that we are unlikely to 
> fix
> 
> The final code is clean with mypy (type checking) and pylint3 (current 
> upstream release, since the Debian package is not currently installable).
> 
> I might enable mypy and pylint as part of the CI on salsa so that we can 
> continue to polish the code and ensure that this current status continues.
> 
> Comments welcome! I'd like to merge this branch in the next few days -- it 
> touches almost every file in the package many many places meaning that it is 
> impossible to do anything else on python-debian while this MR remains 
> unmerged.

Wow, thanks, I like this patch. You can claim a drink from me anytime
for the hard work you did getting the type annotations in, in a way
still compatible from python2.

I really look forward to the day when we can drop support for python2 in
Debian.

I added a note here:
  https://salsa.debian.org/python-debian-team/python-debian/merge_requests/5/diffs#b7da941352b66558fbf7c7512b3593ecdedef749_37_63


Enrico

-- 
GPG key: 4096R/634F4BD1E7AD5568 2009-05-08 Enrico Zini <enrico at enricozini.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-python-debian-maint/attachments/20180726/f6eefc77/attachment.sig>