[Pkg-raspi-maintainers] Bug#961377: raspi3-firmware: recent stable update causes non-booting systems

[Thorsten Glaser]

Package: raspi3-firmware
Version: 1.20190215-1+deb10u3
Severity: critical
Tags: patch buster
Justification: breaks the whole system

/etc/kernel/postinst.d/z50-raspi3-firmware in +deb10u3 contains:

   67   for dtn in ${dtb_path}/bcm*.dtb; do
   68     [ -e "${dtb}" ] && cp "${dtb}" /boot/firmware/
   69   done

It’s hard to see, a typo, and not in unstable (where commit
165f43a6ca14d240f199e8ab8924e503ca5f427d got it right), but
commit fc3df0e8c64c2c62a54e0efcd226e36f28ccd3a4 uses “dtn”,
not “dtb”, as for variable, but refers to “dtb”.

This causes creation of systems that cannot boot (user error
description “[…] but when I install the SD card on the Pi and
boot it, I end up with this multicolored starting screen. It
does not go any further.”) which is really tricky to debug.

The following patch causes the four files…
-rwxr-xr-x 1 root root    13593 May 23 20:53 bcm2837-rpi-3-a-plus.dtb
-rwxr-xr-x 1 root root    13637 May 23 20:53 bcm2837-rpi-3-b-plus.dtb
-rwxr-xr-x 1 root root    13445 May 23 20:53 bcm2837-rpi-3-b.dtb
-rwxr-xr-x 1 root root    13433 May 23 20:53 bcm2837-rpi-cm3-io3.dtb
… to show up in /boot/firmware/ and should (I cannot boot-test
it currently) therefore fix this problem:


diff --git a/debian/kernel/postinst.d/z50-raspi3-firmware b/debian/kernel/postinst.d/z50-raspi3-firmware
index 5d3dd8e..04ebb1d 100755
--- a/debian/kernel/postinst.d/z50-raspi3-firmware
+++ b/debian/kernel/postinst.d/z50-raspi3-firmware
@@ -64,7 +64,7 @@ else
 fi
 
 if [ "$KERNEL" = "auto" ]; then
-  for dtn in ${dtb_path}/bcm*.dtb; do
+  for dtb in ${dtb_path}/bcm*.dtb; do
     [ -e "${dtb}" ] && cp "${dtb}" /boot/firmware/
   done
 


-- System Information:
Debian Release: 10.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: arm64 (aarch64)

Kernel: Linux 5.5.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect

Versions of packages raspi3-firmware depends on:
ii  dosfstools  4.1-2

raspi3-firmware recommends no packages.

raspi3-firmware suggests no packages.

-- Configuration Files:
/etc/default/raspi3-firmware changed:
CMA=128M


-- no debconf information