[Pkg-raspi-maintainers] Bug#1092826: raspi-firmware: read-write mount of root filesystem prevents fsck at boot on trixie

[Ryutaroh Matsumoto]

Package: raspi-firmware
Version: 1.20240424+ds-6
Severity: normal
Tags: patch

Dear Maintainer,

/lib/systemd/system/systemd-fsck-root.service has
ConditionPathIsReadWrite=!/
on trixie.
For systemd-fsck-root.service to run fsck on the root filesystem,
it must be mounted read-only at boot.

But /etc/kernel/postinst.d/z50-raspi-firmware hard-coded the read-write mount
into /boot/firmware/cmdline. The root filesystem is never fsck'ed at boot time on trixie.

A suggested patch is attached.

Best regards, Ryutaroh Matsumoto



-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: arm64 (aarch64)

Kernel: Linux 6.12.6-rt-arm64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CRAP
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages raspi-firmware depends on:
ii  dosfstools  4.2-1.1+b1
ii  dpkg        1.22.11

raspi-firmware recommends no packages.

Versions of packages raspi-firmware suggests:
ii  bluez-firmware         1.2-11.1
ii  firmware-brcm80211     20241210-1
ii  firmware-misc-nonfree  20241210-1

-- Configuration Files:
/etc/default/raspi-firmware changed:
ROOTPART="LABEL=RASPIROOT"
KERNEL_ARCH="arm64"
CMA="256M at 256M"


-- no debconf information
-------------- next part --------------
--- etc/kernel/postinst.d/z50-raspi-firmware	2025-01-12 12:39:38.846272642 +0900
+++ root/z50-raspi-firmware	2025-01-12 12:29:35.184652715 +0900
@@ -245,7 +245,7 @@
 fi
 
 cat >/boot/firmware/cmdline.txt <<EOF
-${pre_cmdline} root=$ROOTPART rw fsck.repair=yes net.ifnames=0 $SET_CMA rootwait ${post_cmdline}
+${pre_cmdline} root=$ROOTPART ro fsck.repair=yes net.ifnames=0 $SET_CMA rootwait ${post_cmdline}
 EOF
 
 cd /boot/firmware