Bug#855536: xrdp: Xorg fails to start with pam_mkhomedir

[Tim Fischer]

Package: xrdp
Version: 0.9.1-4
Severity: normal

Dear Maintainer,
when using xrdp with pam_mkhomedir to create users home directory
when they log in first, xrdp fails to start a Xorg-Session.
The reason for this (including possibles solution) is described on 
https://github.com/neutrinolabs/xrdp/issues/350
auth_start_session() should be called before Xorg is forked.
Maybe the following is resolving the bug:

--- xrdp-0.9.1.orig/sesman/session.c
+++ xrdp-0.9.1/sesman/session.c
@@ -540,6 +540,7 @@ session_start_fork(tbus data, tui8 type,
.
         g_waitpid(bsdsespid);
 #endif
+        auth_start_session(data, display);
         wmpid = g_fork(); /* parent becomes X,
                              child forks wm, and waits, todo */
         if (wmpid == -1)
@@ -548,7 +549,6 @@ session_start_fork(tbus data, tui8 type,
         else if (wmpid == 0)
         {
             wait_for_xserver(display);
-            auth_start_session(data, display);
             pampid = g_fork(); /* parent waits, todo
                                   child becomes wm */
             if (pampid == -1)



-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xrdp depends on:
ii  adduser              3.115
ii  init-system-helpers  1.47
ii  libc6                2.24-9
ii  libfuse2             2.9.7-1
ii  libjpeg62-turbo      1:1.5.1-2
ii  libopus0             1.2~alpha2-1
ii  libpam0g             1.1.8-3.5
ii  libssl1.1            1.1.0d-2
ii  libx11-6             2:1.6.4-3
ii  libxfixes3           1:5.0.3-1
ii  libxrandr2           2:1.5.1-1
ii  lsb-base             9.20161125
ii  ssl-cert             1.0.38

Versions of packages xrdp recommends:
ii  fuse      2.9.7-1
ii  xorgxrdp  0.9.1-4

Versions of packages xrdp suggests:
pn  guacamole  <none>

Versions of packages xorgxrdp depends on:
ii  libc6                                  2.24-9
pn  xorg-input-abi-24                      <none>
ii  xserver-xorg-core [xorg-video-abi-23]  2:1.19.1-4

Versions of packages xorgxrdp recommends:
ii  xorg  1:7.7+18

Versions of packages xrdp is related to:
pn  vnc-server           <none>
pn  xserver-xorg-legacy  <none>

-- no debconf information