Bug#898448: Makes vinagre segfault on authentication failure

[James Lu]

Dear maintainers,

With libfreerdp2-2 2.0.0~git20180411.1.7a7b1802+dfsg1-2+b1 and vinagre
3.22.0-5, I get a very similar crash if the target host is unreachable
or does not have RDP open.
When running in gdb, an "Error connecting to host." dialog pops up and
vinagre immediately segfaults afterwards.

The backtrace is as follows:

(gdb) bt full
#0  clear_context_free (clear=0x1) at ./libfreerdp/codec/clear.c:1216
        i = <optimized out>
        clear = 0x1
        i = <optimized out>
        i = <optimized out>
#1  0x00007ffff6d8b67d in codecs_free (codecs=0x555555de8560) at
./libfreerdp/core/codecs.c:213
No locals.
#2  0x00007ffff6d85907 in freerdp_disconnect (instance=0x555555dd0ff0)
at ./libfreerdp/core/freerdp.c:508
        rc = 1
        rdp = <optimized out>
#3  0x0000555555584769 in vinagre_rdp_tab_dispose
(object=0x555555c8a880) at plugins/rdp/vinagre-rdp-tab.c:182
        rdp_tab = 0x555555c8a880
        priv = 0x555555c8a690
#4  0x00007ffff734dc13 in g_object_unref () from
/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
No symbol table info available.
#5  0x00007ffff78e0099 in gtk_container_remove () from
/usr/lib/x86_64-linux-gnu/libgtk-3.so.0
No symbol table info available.
#6  0x0000555555570748 in vinagre_notebook_close_tab (nb=0x555555b6e240,
tab=0x555555c8a880) at vinagre/vinagre-notebook.c:697
        position = 0
        notebook = 0x555555b6e240
        previous_active_tab = 0x555555c8a880
        __func__ = "vinagre_notebook_close_tab"
#7  0x0000555555583074 in idle_close (tab=0x555555c8a880) at
plugins/rdp/vinagre-rdp-tab.c:272
No locals.
#8  0x00007ffff7268ae8 in g_main_context_dispatch () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#9  0x00007ffff7268ed8 in ?? () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#10 0x00007ffff7268f6c in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#11 0x00007ffff742f13d in g_application_run () from
/usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
No symbol table info available.
#12 0x00005555555655cf in main (argc=1, argv=0x7fffffffe118) at
vinagre/vinagre-main.c:196
        app = 0x5555557ed1a0
        res = <optimized out>

Best,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-remote-team/attachments/20181104/38362e4e/attachment.sig>