[request-tracker-maintainers] [RFR] templates://rt-extension-assettracker/{templates}

[Christian PERRIER]

Please find, for review, the debconf templates and packages descriptions for the rt-extension-assettracker source package.

This review will last from Wednesday, June 08, 2011 to Saturday, June 18, 2011.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- rt-extension-assettracker.old/debian/templates	2011-06-07 06:17:36.812963791 +0200
+++ rt-extension-assettracker/debian/templates	2011-06-08 06:31:47.379737271 +0200
@@ -5,8 +5,9 @@
 _Description: Permission to modify the Request Tracker database:
  Asset Tracker needs some modifications in the Request Tracker
  database to be functional. These modifications can be made
- automatically or you may be prompted when they are needed.
- Alternatively, you can run the necessary commands manually.
+ automatically (choose "allow") or you may be prompted when they are
+ needed (choose "prompt").
+ Alternatively, you can run the necessary commands manually (choose "deny").
  .
  Please check the README.Debian file for more details.

This is a usability improvement proposal: reminding users which of the
three choices has which consequence.

 
@@ -34,7 +35,7 @@
  .
  ${error}
  .
- The full output should be available in the RT log, most probably
+ The full output should be available in Request Tracker log, most probably
  syslog.
  .
  You can retry the modification, abort the installation or ignore the

s/RT/Request Tracker as the full software name is used everywhere else.


--- rt-extension-assettracker.old/debian/control	2011-06-07 06:17:36.812963791 +0200
+++ rt-extension-assettracker/debian/control	2011-06-07 06:39:01.930147389 +0200
@@ -12,6 +12,6 @@
 Package: rt3.8-extension-assettracker
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, request-tracker3.8 (>= 3.8.1), libset-scalar-perl, libxml-parser-perl, libxml-simple-perl
-Description: Asset tracking extension for Request Tracker
- Asset Tracker is an extension for Request Tracker. It add the
+Description: asset tracking extension for Request Tracker
+ Asset Tracker is an extension for Request Tracker. It adds the
  ability to track assets in the same way one tracks tickets.

Grammar fix.

-- 


-------------- next part --------------
Template: rt3.8-extension-assettracker/modify-database-permission
Type: select
__Choices: allow, prompt, deny
Default: allow
_Description: Permission to modify the Request Tracker database:
 Asset Tracker needs some modifications in the Request Tracker
 database to be functional. These modifications can be made
 automatically (choose "allow") or you may be prompted when they are
 needed (choose "prompt").
 Alternatively, you can run the necessary commands manually (choose "deny").
 .
 Please check the README.Debian file for more details.

Template: rt3.8-extension-assettracker/setup-database-prompt
Type: boolean
Default: true
_Description: Set up the Request Tracker database?
 New tables must be created in the Request Tracker database for Asset
 Tracker to be functional.

Template: rt3.8-extension-assettracker/upgrade-database-prompt
Type: boolean
Default: true
_Description: Upgrade the Request Tracker database?
 The Request Tracker database schema and contents must be upgraded for
 this version of Asset Tracker.

Template: rt3.8-extension-assettracker/modify-database-error
Type: select
__Choices: abort, retry, ignore
Default: abort
#flag:translate!:3
_Description: Action after database modification error:
 An error occurred while modifying the database:
 .
 ${error}
 .
 The full output should be available in Request Tracker log, most probably
 syslog.
 .
 You can retry the modification, abort the installation or ignore the
 error. If you abort the installation, the operation will fail and you
 will need to manually intervene (for instance by purging and
 reinstalling). If you choose to ignore the error, the upgrade process
 will continue.
-------------- next part --------------
--- rt-extension-assettracker.old/debian/templates	2011-06-07 06:17:36.812963791 +0200
+++ rt-extension-assettracker/debian/templates	2011-06-08 06:31:47.379737271 +0200
@@ -5,8 +5,9 @@
 _Description: Permission to modify the Request Tracker database:
  Asset Tracker needs some modifications in the Request Tracker
  database to be functional. These modifications can be made
- automatically or you may be prompted when they are needed.
- Alternatively, you can run the necessary commands manually.
+ automatically (choose "allow") or you may be prompted when they are
+ needed (choose "prompt").
+ Alternatively, you can run the necessary commands manually (choose "deny").
  .
  Please check the README.Debian file for more details.
 
@@ -34,7 +35,7 @@
  .
  ${error}
  .
- The full output should be available in the RT log, most probably
+ The full output should be available in Request Tracker log, most probably
  syslog.
  .
  You can retry the modification, abort the installation or ignore the
--- rt-extension-assettracker.old/debian/control	2011-06-07 06:17:36.812963791 +0200
+++ rt-extension-assettracker/debian/control	2011-06-07 06:39:01.930147389 +0200
@@ -12,6 +12,6 @@
 Package: rt3.8-extension-assettracker
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, request-tracker3.8 (>= 3.8.1), libset-scalar-perl, libxml-parser-perl, libxml-simple-perl
-Description: Asset tracking extension for Request Tracker
- Asset Tracker is an extension for Request Tracker. It add the
+Description: asset tracking extension for Request Tracker
+ Asset Tracker is an extension for Request Tracker. It adds the
  ability to track assets in the same way one tracks tickets.
-------------- next part --------------
Source: rt-extension-assettracker
Section: perl
Priority: optional
Maintainer: Debian Request Tracker Group <pkg-request-tracker-maintainers at lists.alioth.debian.org>
Uploaders: Bradley Bell <btb at debian.org>
Build-Depends: debhelper (>= 7.0.50~)
Standards-Version: 3.9.2
Homepage: https://github.com/chakatodd/rt-extension-assettracker
Vcs-Git: git://git.debian.org/pkg-request-tracker/rt-extension-assettracker.git
Vcs-Browser: http://git.debian.org/?p=pkg-request-tracker/rt-extension-assettracker.git

Package: rt3.8-extension-assettracker
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}, request-tracker3.8 (>= 3.8.1), libset-scalar-perl, libxml-parser-perl, libxml-simple-perl
Description: asset tracking extension for Request Tracker
 Asset Tracker is an extension for Request Tracker. It adds the
 ability to track assets in the same way one tracks tickets.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20110608/16c44314/attachment.pgp>