[request-tracker-maintainers] Review: request-tracker4 improvements

[Dmitry Smirnov]

Hi Dominic,


On Wed, 25 Jan 2012 07:10:12 Dominic Hargreaves wrote:
> > +Format:
> > http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?view=markup&path
> > rev=174
> 
> Looks like
> 
> http://dep.debian.net/deps/dep5/
> 
> is a better URL.
> 

Thank you. (I learned about it shortly after I submitted the patch)


> I'm not aware of any decision to change the licensing, so this should be
> GPL-2, just like RT itself.

My bad, thanks for noticing.

> 
> The copyright years do not reflect the real state of contributions; mine
> go back to 2008, and Niko's go further (probably see the changelog to
> request-tracker3.{8,6,4}. Ths list of contributors is also incomplete;
> if we're going to include a list at all, it may as well be complete
> (again, see the older packages).
> 
> Otherwise, this patch looks fine - thanks for a thorough job.
> 

Good, this would be easy to correct.
Sorry about that. I was cross-referencing only debian/changelog.
Besides this is more like work-in-progress rather than final version.
(I expected you to review or change this.)

I think you can commit the updated patch attached to the other message and we 
can make necessary corrections later on. 


> 
> This looks plausible, but I haven't used nginx so can't comment further.
> 

I can only say it's a working configuration I use. 
It's mine as I couldn't find anything useful in Internet.


> > +# Defaults for request-tracker4 initscript
> > +# sourced by /etc/init.d/rt4-fcgi
> > +# installed at /etc/default/rt4-fcgi by the maintainer scripts
> 
> Being very picky here... this file is shipped in place in the .deb,
> not installed by a maintainer script.

Pedantic but true. :)

> 
> > + .
> > + This package provides fcgi interface for nginx web server
> > + (but not limited to).
> 
> I'd reword this to:
> 
> This package provides an FCGI interface for web servers including,
> but not limited to, nginx.
> 

Very well. 


Regards,
Dmitry.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20120125/b20e4b04/attachment.pgp>