[request-tracker-maintainers] RFS: libmodule-install-rtx-perl

[Dominic Hargreaves]

On Thu, Nov 17, 2016 at 08:33:10PM +0900, Satoru KURASHIKI wrote:
> hi,
> 
> I've updated and staged the package:
> https://mentors.debian.net/package/libmodule-install-rtx-perl
> https://anonscm.debian.org/git/pkg-request-tracker/libmodule-install-rtx-perl.git?h=dpkg
> 
> Major changes are:
> New upstream release which includes our local patches, so dropped them.
> 
> And apply reviews below (sorry tooo late action):
> 
> > - the dpkg branch does not match the upstream tarball; SIGNATURE is
> >   missing and MANIFEST changes. I suggest you fix this by creating an
> >   upstream branch based on master, running git-import-orig and then
> >   merge the result onto the dpkg branch
> 
> > - please add '-b dpkg' to the Vcs-Git URLs or change HEAD to point to the
> >   dpkg branch so it's obvious where the Debian packaging is happening

Hi,

Thanks for this work. I reviewed your changes and tried to build the
package and got this:

$ dpkg-buildpackage -uc -us -S
[...]
dpkg-source: info: building libmodule-install-rtx-perl using existing ./libmodule-install-rtx-perl_0.38.orig.tar.gz
patching file MANIFEST
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file SIGNATURE,
which already exists!  Skipping patch.
1 out of 1 hunk ignored
dpkg-source: info: the patch has fuzz which is not allowed, or is malformed
dpkg-source: info: if patch '00-fix-cpan-release-changes.patch' is correctly applied by quilt, use 'quilt refresh' to update it
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/00-fix-cpan-release-changes.patch/ --reject-file=- < libmodule-install-rtx-perl.orig.Jdd_eT/debian/patches/00-fix-cpan-release-changes.patch gave error exit status 1
dpkg-buildpackage: error: dpkg-source -b libmodule-install-rtx-perl gave error exit status 2

so this isn't quite right yet.

I noticed you didn't follow my suggestion to merge the changes from the
upstream tarball into the dpkg branch. AFAICT this is the only sane
way to fix this kind of problem when trying commits from the upstream
repository.

Could you have a look a the upstream and dom/dpkg branches I've pushed to
see what I mean and whether you agree, and let me know whether you're
happy for me to upload or whether you think we should be doing
it differently?

Cheers,
Dominic.