[request-tracker-maintainers] Small patch for RT

Dominic Hargreaves dom at earth.li
Tue Aug 29 10:33:51 UTC 2017


On Tue, Aug 29, 2017 at 09:46:47AM +0300, Max Kosmach wrote:
> Hi, RT maintainers
> 
> Would You please review my small patch and add it to Debian RT package?
> 
> With this patch RT will show description of CF value as tooltip when value is selected.
> 
> https://github.com/bestpractical/rt/pull/228
> 
> Patch:
> 
> diff --git a/share/html/Elements/EditCustomFieldSelect b/share/html/Elements/EditCustomFieldSelect
> index 764f5886ea..6d5e22ea84 100644
> --- a/share/html/Elements/EditCustomFieldSelect
> +++ b/share/html/Elements/EditCustomFieldSelect
> @@ -179,6 +179,7 @@ $MaxValues => 1
>  % my @levels;
>  % while ( my $value = $CFVs->Next ) {
>  %       my $name = $value->Name;
> +%       my $descr = $value->Description;
>  %       my $category = $value->Category || '';
>  %       my $level = (split /:/, $category, 2)[0] || '';
>  %       while (@levels) {
> @@ -198,6 +199,9 @@ $MaxValues => 1
>  %           push @levels, $level;
>  %       }
>          <option value="<% $name %>"
> +%       if ($descr) {
> +            title="<% $descr %>"
> +%       }
>  %       if ( grep $_ eq lc $name, @Default )
>  %       {
>  %           $$SelectedRef = 1;

Hi,

Please file such requests through a wishlist bug in the BTS so that we
can track the status better, thanks.

For this particular case, I would like to see this change committed,
or at least approved, by upstream if possible, which given that there
has been no response on the PR is a bit of a problem.

The patch itself is uncontroversial, but I'd prefer to avoid applying
non-Debian-specific feature patches to the Debian package due to the
overhead of maintaining the patch series.

Thanks,
Dominic.



More information about the pkg-request-tracker-maintainers mailing list